249146 2022-12-12 07:09:49 -0800 Regular expression fails in WebKit only: invalid group specifier name 2022-12-18 21:32:56 -0800 1 1 1 Unclassified WebKit JavaScriptCore Safari 16 Unspecified Unspecified RESOLVED DUPLICATE 174931 BrowserCompat, InRadar P2 Normal --- 1 vprelovac webkit-unassigned karlcow mark.lam msaboff webkit-bug-importer oldest_to_newest 1918481 0 vprelovac 2022-12-12 07:09:49 -0800 The following regular expression works in Chrome and Firefox, but fails in WebKit: let tokens = "test".match(/(?<=\s+|^)["'‘“'"[({⟨]?(.*?[.?!])(\s[.?!])*["'’”'"\])}⟩]?(?=\s+|$)|(?<=\s+|^)\S(.*?[.?!])(\s[.?!])*(?=\s+|$)/g); SyntaxError: Invalid regular expression: invalid group specifier name 1920088 1 webkit-bug-importer 2022-12-16 15:02:31 -0800 <rdar://problem/103461779> 1920096 2 msaboff 2022-12-16 15:30:28 -0800 This was fixed with commit 257823@main (46e6b3f97425): <https://commits.webkit.org/257823@main>. *** This bug has been marked as a duplicate of bug 174931 *** 1920165 3 vprelovac 2022-12-16 18:48:57 -0800 (In reply to Michael Saboff from comment #2) > This was fixed with commit 257823@main (46e6b3f97425): > <https://commits.webkit.org/257823@main>. > > *** This bug has been marked as a duplicate of bug 174931 *** I've compiled trunk with the patch in and want to report that this problem is still not fixed. 1920166 4 mark.lam 2022-12-16 18:54:27 -0800 (In reply to Vladimir Prelovac from comment #3) > > *** This bug has been marked as a duplicate of bug 174931 *** > > I've compiled trunk with the patch in and want to report that this problem > is still not fixed. Are you sure you're building the latest trunk? I just tried against trunk also, and I also no longer see that SyntaxError. Looks fixed to me. 1920168 5 vprelovac 2022-12-16 18:59:06 -0800 (In reply to Mark Lam from comment #4) > (In reply to Vladimir Prelovac from comment #3) > > > *** This bug has been marked as a duplicate of bug 174931 *** > > > > I've compiled trunk with the patch in and want to report that this problem > > is still not fixed. > > Are you sure you're building the latest trunk? I just tried against trunk > also, and I also no longer see that SyntaxError. Looks fixed to me. Thanks for double checking. I did indeed pull the trunk an hour ago and verified it is latest trunk by verifying the patch was applied. (for example Source/JavaScriptCore/runtime/RegExp.cpp line 252 is " && !pattern.m_containsLookbehinds") The Webkit version also shows as 615.1.15+ Then I went to https://runjs.co (since don't have inspector in minibrowser/run-safari) and ran: let tokens = "test".match(/(?<=\s+|^)["'‘“'"[({⟨]?(.*?[.?!])(\s[.?!])*["'’”'"\])}⟩]?(?=\s+|$)|(?<=\s+|^)\S(.*?[.?!])(\s[.?!])*(?=\s+|$)/g); Producing: SyntaxError: Invalid regular expression: invalid group specifier name 1920172 6 vprelovac 2022-12-16 19:09:38 -0800 My bad, run-minibrowser does not produce error, run-safari does, so I will assume that the problem is on my end. Thanks.