24914 2009-03-28 12:42:22 -0700 empty-string assertion crash when running storage tests 2009-03-28 17:16:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 darin darin mrowe oldest_to_newest 115692 0 darin 2009-03-28 12:42:22 -0700 I have the fix for the assertion we're seeing in the storage tests. 115693 1 29039 darin 2009-03-28 12:47:31 -0700 Created attachment 29039 patch 115705 2 darin 2009-03-28 17:16:41 -0700 http://trac.webkit.org/changeset/42076 29039 2009-03-28 12:47:31 -0700 2009-03-28 12:51:55 -0700 patch StorageCrashPatch.txt text/plain 2895 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjA3MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDMtMjggIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAy NDkxNDogZW1wdHktc3RyaW5nIGFzc2VydGlvbiBjcmFzaCB3aGVuIHJ1bm5pbmcgc3RvcmFnZSB0 ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ5 MTQKKworICAgICAgICAqIHN0b3JhZ2UvRGF0YWJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RGF0YWJhc2U6OnBlcmZvcm1PcGVuQW5kVmVyaWZ5KTogRG9uJ3Qgc3RvcmUgZW1wdHkgdmVyc2lv biBzdHJpbmdzCisgICAgICAgIGluIHRoZSBtYXAsIHNpbmNlIGVtcHR5IHN0cmluZ3MgYXJlIHBl ci10aHJlYWQuCisKIDIwMDktMDMtMjggIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpJbmRleDogV2ViQ29y ZS9zdG9yYWdlL0RhdGFiYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3N0b3JhZ2UvRGF0 YWJhc2UuY3BwCShyZXZpc2lvbiA0MjA3MykKKysrIFdlYkNvcmUvc3RvcmFnZS9EYXRhYmFzZS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTQyNiwxOCArNDI2LDIzIEBAIGJvb2wgRGF0YWJhc2U6OnBl cmZvcm1PcGVuQW5kVmVyaWZ5KEV4Y2UKICAgICAgICAgfQogICAgIH0KIAotCiAgICAgU3RyaW5n IGN1cnJlbnRWZXJzaW9uOwogICAgIHsKICAgICAgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKGd1aWRN dXRleCgpKTsKLSAgICAgICAgY3VycmVudFZlcnNpb24gPSBndWlkVG9WZXJzaW9uTWFwKCkuZ2V0 KG1fZ3VpZCk7CiAKLSAgICAgICAgaWYgKGN1cnJlbnRWZXJzaW9uLmlzTnVsbCgpKQotICAgICAg ICAgICAgTE9HKFN0b3JhZ2VBUEksICJDdXJyZW50IGNhY2hlZCB2ZXJzaW9uIGZvciBndWlkICVp IGlzIG51bGwiLCBtX2d1aWQpOwotICAgICAgICBlbHNlCisgICAgICAgIC8vIE5vdGU6IEl0IGlz IG5vdCBzYWZlIHRvIHB1dCBhbiBlbXB0eSBzdHJpbmcgaW50byB0aGUgZ3VpZFRvVmVyc2lvbk1h cCgpIG1hcC4KKyAgICAgICAgLy8gVGhhdCdzIGJlY2F1c2UgdGhlIG1hcCBpcyBjcm9zcy10aHJl YWQsIGJ1dCBlbXB0eSBzdHJpbmdzIGFyZSBwZXItdGhyZWFkLgorICAgICAgICAvLyBUaGUgY29w eSgpIGZ1bmN0aW9uIG1ha2VzIGEgdmVyc2lvbiBvZiB0aGUgc3RyaW5nIHlvdSBjYW4gdXNlIG9u IHRoZSBjdXJyZW50CisgICAgICAgIC8vIHRocmVhZCwgYnV0IHdlIG5lZWQgYSBzdHJpbmcgd2Ug Y2FuIGtlZXAgaW4gYSBjcm9zcy10aHJlYWQgZGF0YSBzdHJ1Y3R1cmUuCisgICAgICAgIC8vIEZJ WE1FOiBUaGlzIGlzIGEgcXVpdGUtYXdrd2FyZCByZXN0cmljdGlvbiB0byBoYXZlIHRvIHByb2dy YW0gd2l0aC4KKworICAgICAgICBHdWlkVmVyc2lvbk1hcDo6aXRlcmF0b3IgZW50cnkgPSBndWlk VG9WZXJzaW9uTWFwKCkuZmluZChtX2d1aWQpOworICAgICAgICBpZiAoZW50cnkgIT0gZ3VpZFRv VmVyc2lvbk1hcCgpLmVuZCgpKSB7CisgICAgICAgICAgICAvLyBNYXAgbnVsbCBzdHJpbmcgdG8g ZW1wdHkgc3RyaW5nIChzZWUgY29tbWVudCBhYm92ZSkuCisgICAgICAgICAgICBjdXJyZW50VmVy c2lvbiA9IGVudHJ5LT5zZWNvbmQuaXNOdWxsKCkgPyBTdHJpbmcoIiIpIDogZW50cnktPnNlY29u ZDsKICAgICAgICAgICAgIExPRyhTdG9yYWdlQVBJLCAiQ3VycmVudCBjYWNoZWQgdmVyc2lvbiBm b3IgZ3VpZCAlaSBpcyAlcyIsIG1fZ3VpZCwgY3VycmVudFZlcnNpb24uYXNjaWkoKS5kYXRhKCkp OwotCi0gICAgICAgIGlmIChjdXJyZW50VmVyc2lvbi5pc051bGwoKSkgeworICAgICAgICB9IGVs c2UgeworICAgICAgICAgICAgTE9HKFN0b3JhZ2VBUEksICJObyBjYWNoZWQgdmVyc2lvbiBmb3Ig Z3VpZCAlaSIsIG1fZ3VpZCk7CiAgICAgICAgICAgICBpZiAoIWdldFZlcnNpb25Gcm9tRGF0YWJh c2UoY3VycmVudFZlcnNpb24pKSB7CiAgICAgICAgICAgICAgICAgTE9HX0VSUk9SKCJGYWlsZWQg dG8gZ2V0IGN1cnJlbnQgdmVyc2lvbiBmcm9tIGRhdGFiYXNlICVzIiwgZGF0YWJhc2VEZWJ1Z05h bWUoKS5hc2NpaSgpLmRhdGEoKSk7CiAgICAgICAgICAgICAgICAgZSA9IElOVkFMSURfU1RBVEVf RVJSOwpAQCAtNDUyLDExICs0NTcsMTEgQEAgYm9vbCBEYXRhYmFzZTo6cGVyZm9ybU9wZW5BbmRW ZXJpZnkoRXhjZQogICAgICAgICAgICAgICAgICAgICBlID0gSU5WQUxJRF9TVEFURV9FUlI7CiAg ICAgICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgICAgICAgICB9Ci0KICAg ICAgICAgICAgICAgICBjdXJyZW50VmVyc2lvbiA9IG1fZXhwZWN0ZWRWZXJzaW9uOwogICAgICAg ICAgICAgfQogCi0gICAgICAgICAgICBndWlkVG9WZXJzaW9uTWFwKCkuc2V0KG1fZ3VpZCwgY3Vy cmVudFZlcnNpb24uY29weSgpKTsKKyAgICAgICAgICAgIC8vIE1hcCBlbXB0eSBzdHJpbmcgdG8g bnVsbCBzdHJpbmcgKHNlZSBjb21tZW50IGFib3ZlKS4KKyAgICAgICAgICAgIGd1aWRUb1ZlcnNp b25NYXAoKS5zZXQobV9ndWlkLCBjdXJyZW50VmVyc2lvbi5pc0VtcHR5KCkgPyBTdHJpbmcoKSA6 IGN1cnJlbnRWZXJzaW9uLmNvcHkoKSk7CiAgICAgICAgIH0KICAgICB9CiAK