249113 2022-12-11 15:25:53 -0800 Progressive Images (e.g., JPEG) should render while loading 2025-01-11 13:07:43 -0800 1 1 1 Unclassified WebKit Images Safari Technology Preview Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=272350 InRadar P2 Normal --- 1 ahmad.saleem792 webkit-unassigned don.olmstead fujii mateusz.karpow mattwoodrow mmaxfield nekohayo rego sabouhallawa simon.fraser webkit-bug-importer oldest_to_newest 1918348 0 ahmad.saleem792 2022-12-11 15:25:53 -0800 Hi Team, While going through Blink's commit, it seems that Webkit wait for image to be loaded rather than loading it progressively. Failing Test Case - https://jsfiddle.net/6y4zjb17/ Safari 16.1 will take ages to load image while Chrome will load it progressively. Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=198593 Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/bf6ec0b71883ada1ee6d8d0c66a8ea7e421c5e27/Source/WebCore/rendering/RenderLayerBacking.cpp#LL3109 Just wanted to raise this bug so this can be fixed. Thanks! 1919003 1 ahmad.saleem792 2022-12-13 17:09:00 -0800 After discussion with Simon on Slack, it is needed because partially loaded images should not go to Core Animation on Cocoa platforms. There might be strategic fix in future to get rid of this but Simon mentioned that it is still valuable to keep this open for future tracking purposes. 1920388 2 webkit-bug-importer 2022-12-18 15:26:16 -0800 <rdar://problem/103499397> 1941372 3 ahmad.saleem792 2023-03-14 15:45:49 -0700 I think adding #if PLATFORM(COCOA) etc. around this will fix it for WinCairo, WPE and GTK platforms, which does not use 'Core Animation' and make progressive JPEG loading for those platforms better. 1964207 4 ahmad.saleem792 2023-06-29 02:20:26 -0700 (In reply to Ahmad Saleem from comment #3) > I think adding #if PLATFORM(COCOA) etc. around this will fix it for > WinCairo, WPE and GTK platforms, which does not use 'Core Animation' and > make progressive JPEG loading for those platforms better. I think adding: #if !PLATFORM(WPE) && !PLATFORM(GTK) && !PLATFORM(WIN) // We have to wait until the image is fully loaded before setting it on the layer. if (!cachedImage->isLoaded()) return; #endif would make it at least work for other platform and they will get better performance. I am happy to do patch but it wouldn't have test case. 1976224 5 ahmad.saleem792 2023-09-07 14:21:59 -0700 Closing my PR: https://github.com/WebKit/WebKit/pull/15503 Tried to add flags but need input from Simon or someone from Apple team with knowledge of where we use this settings, so we can only allow it on those rather than other way around to disable on non-apple ports. 2000306 6 ahmad.saleem792 2023-12-17 14:30:45 -0800 Test URL - http://home.mcom.com/ 2048013 7 ahmad.saleem792 2024-07-24 06:46:17 -0700 SVN link is gone so reference - https://github.com/chromium/chromium/commit/4c296462f985890e24a2a552f6c6da54a2010ea9