24908 2009-03-27 22:52:20 -0700 run-webkit-tests unable to set timeout manually 2009-04-07 15:24:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 bweinstein webkit-unassigned aroben slewis oldest_to_newest 115654 0 bweinstein 2009-03-27 22:52:20 -0700 run-webkit-tests is currently unable to set the timeout time through a command line argument, which can mean tests are either running for too long (multiple timeouts where the system is in a broken state), or too short (want tests to timeout more quickly, but there are some longer tests). 115655 1 mrowe 2009-03-27 22:57:58 -0700 If tests are taking so long that they're timing out then either the test needs simplified or split, the code being tested improved so that the test doesn't take so long, or the timeout raised. I'm not sure why a command-line argument would be necessary here. 115656 2 29035 bweinstein 2009-03-27 22:58:33 -0700 Created attachment 29035 Timeout able to be set as an argument 115710 3 29035 darin 2009-03-28 17:41:48 -0700 Comment on attachment 29035 Timeout able to be set as an argument The other arguments are mostly in alphabetical order except for merge-leak-depth in the usage message. It would be good to keep them sorted. I'm not sure --timeout-seconds is better than just --timeout r=me though 115971 4 29107 bweinstein 2009-03-30 19:34:30 -0700 Created attachment 29107 Fix argument order, --timeout instead of --timeout-seconds Made the quick fixes requested by Darin 116023 5 29107 aroben 2009-03-31 09:51:14 -0700 Comment on attachment 29107 Fix argument order, --timeout instead of --timeout-seconds > + --timeout Sets the length of time before a test times out The Usage output should indicate that --timeout takes a parameter. It would be good for it to also say what the default value is. > + 'timeout-seconds=i' => \$timeoutSeconds, This wasn't changed to match the new name of the option. Your ChangeLog should also mention that this patch changes the default value back to 60 seconds from 15. Or your patch keep the default at 15 seconds (which might be better). r- since the code doesn't match the Usage statement. 116039 6 29125 bweinstein 2009-03-31 10:53:26 -0700 Created attachment 29125 Allows run-webkit-tests to specify timeout Fixed silly mistakes in last patch. 116809 7 aroben 2009-04-07 15:24:03 -0700 Landed in r42292 29035 2009-03-27 22:58:33 -0700 2009-03-30 19:34:30 -0700 Timeout able to be set as an argument tests_timeout.txt text/plain 2042 bweinstein SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQyMDY4KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDMtMjcgIEJyaWFuIFdlaW5zdGVpbiAg PGJ3ZWluc3RlaW5AZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjQ5MDgKKworICAgICAgICBBbGxvd3MgdGltZW91dCB0byBiZSBzZXQgaW4gcnVuLXdlYmtpdC10 ZXN0cyBhcyBhIGNvbW1hbmQgbGluZSBhcmd1bWVudC4JCisKKyAgICAgICAgKiBTY3JpcHRzL3J1 bi13ZWJraXQtdGVzdHM6CisKIDIwMDktMDMtMjcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBXZWJLaXRUb29s cy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2Ny aXB0cy9ydW4td2Via2l0LXRlc3RzCShyZXZpc2lvbiA0MjA0NSkKKysrIFdlYktpdFRvb2xzL1Nj cmlwdHMvcnVuLXdlYmtpdC10ZXN0cwkod29ya2luZyBjb3B5KQpAQCAtMTMzLDYgKzEzMyw3IEBA IG15ICRyb290OwogbXkgJHJldmVyc2VUZXN0cyA9IDA7CiBteSAkcmFuZG9taXplVGVzdHMgPSAw OwogbXkgJG1lcmdlRGVwdGg7CitteSAkdGltZW91dFNlY29uZHMgPSA2MDsKIG15IEBsZWFrc0Zp bGVuYW1lczsKIAogIyBEZWZhdWx0IHRvIC0tbm8taHR0cCBmb3IgUXQsIEd0ayBhbmQgd3ggZm9y IG5vdy4KQEAgLTIxMCw2ICsyMTEsNyBAQCBVc2FnZTogJHByb2dyYW1OYW1lIFtvcHRpb25zXSBb dGVzdGRpcnx0CiAgIC0tdmFsZ3JpbmQgICAgICAgICAgICAgICAgICAgICAgUnVuIER1bXBSZW5k ZXJUcmVlIGluc2lkZSB2YWxncmluZCAoUXQvTGludXggb25seSkKICAgLXZ8LS12ZXJib3NlICAg ICAgICAgICAgICAgICAgICBNb3JlIHZlcmJvc2Ugb3V0cHV0IChvdmVycmlkZXMgLS1xdWlldCkK ICAgLW18LS1tZXJnZS1sZWFrLWRlcHRoIGFyZyAgICAgICBNZXJnZXMgbGVhayBjYWxsU3RhY2tz IGFuZCBwcmludHMgdGhlIG51bWJlciBvZiB1bmlxdWUgbGVha3MgYmVuZWF0aCBhIGNhbGxzdGFj ayBkZXB0aCBvZiBhcmcuICBEZWZhdWx0cyB0byA1LgorICAtLXRpbWVvdXQtc2Vjb25kcyAgICAg ICAgICAgICAgIFNldHMgdGhlIGxlbmd0aCBvZiB0aW1lIGJlZm9yZSBhIHRlc3QgdGltZXMgb3V0 CiBFT0YKIAogc2V0Q29uZmlndXJhdGlvbigpOwpAQCAtMjQ1LDYgKzI0Nyw3IEBAIG15ICRnZXRP cHRpb25zUmVzdWx0ID0gR2V0T3B0aW9ucygKICAgICAncm9vdD1zJyA9PiBcJHJvb3QsCiAgICAg J2FkZC1wbGF0Zm9ybS1leGNlcHRpb25zJyA9PiBcJGFkZFBsYXRmb3JtRXhjZXB0aW9ucywKICAg ICAnbWVyZ2UtbGVhay1kZXB0aHxtOjUnID0+IFwkbWVyZ2VEZXB0aCwKKyAgICAndGltZW91dC1z ZWNvbmRzPWknID0+IFwkdGltZW91dFNlY29uZHMsCiApOwogCiBpZiAoISRnZXRPcHRpb25zUmVz dWx0IHx8ICRzaG93SGVscCkgewpAQCAtMTgwOSw3ICsxODEyLDcgQEAgc3ViIHJlYWRGcm9tRHVt cFRvb2xXaXRoVGltZXIoKjskKQogCiAgICAgc2V0RmlsZUhhbmRsZU5vbkJsb2NraW5nKCRmaCwg MSk7CiAKLSAgICBteSAkbWF4aW11bVNlY29uZHNXaXRob3V0T3V0cHV0ID0gMTU7CisgICAgbXkg JG1heGltdW1TZWNvbmRzV2l0aG91dE91dHB1dCA9ICR0aW1lb3V0U2Vjb25kczsKICAgICAkbWF4 aW11bVNlY29uZHNXaXRob3V0T3V0cHV0ICo9IDEwIGlmICRndWFyZE1hbGxvYzsKICAgICBteSAk bWljcm9zZWNvbmRzVG9XYWl0QmVmb3JlUmVhZGluZ0FnYWluID0gMTAwMDsKIAo= 29107 2009-03-30 19:34:30 -0700 2009-03-31 10:53:26 -0700 Fix argument order, --timeout instead of --timeout-seconds test_timeout.txt text/plain 2257 bweinstein SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQyMTE3KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDMtMzAgIEJyaWFuIFdlaW5zdGVpbiAg PGJ3ZWluc3RlaW5AZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y NDkwOAorCisgICAgICAgIEFsbG93cyB0aW1lb3V0IHRvIGJlIHNldCBpbiBydW4td2Via2l0LXRl c3RzIGFzIGEgY29tbWFuZCBsaW5lIGFyZ3VtZW50LgkKKworICAgICAgICAqIFNjcmlwdHMvcnVu LXdlYmtpdC10ZXN0czoKKwogMjAwOS0wMy0zMCAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5j b20+CiAKICAgICAgICAgV2luZG93cyBidWlsZCBmaXgKSW5kZXg6IFdlYktpdFRvb2xzL1Njcmlw dHMvcnVuLXdlYmtpdC10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3J1 bi13ZWJraXQtdGVzdHMJKHJldmlzaW9uIDQyMTE3KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy9y dW4td2Via2l0LXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0xMzMsNiArMTMzLDcgQEAgbXkgJHJv b3Q7CiBteSAkcmV2ZXJzZVRlc3RzID0gMDsKIG15ICRyYW5kb21pemVUZXN0cyA9IDA7CiBteSAk bWVyZ2VEZXB0aDsKK215ICR0aW1lb3V0U2Vjb25kcyA9IDYwOwogbXkgQGxlYWtzRmlsZW5hbWVz OwogCiAjIERlZmF1bHQgdG8gLS1uby1odHRwIGZvciBRdCwgR3RrIGFuZCB3eCBmb3Igbm93LgpA QCAtMjA3LDYgKzIwOCw3IEBAIFVzYWdlOiAkcHJvZ3JhbU5hbWUgW29wdGlvbnNdIFt0ZXN0ZGly fHQKICAgLS1zdHJpY3QgICAgICAgICAgICAgICAgICAgICAgICBEbyBhIGNvbXBhcmlzb24gd2l0 aCB0aGUgb3V0cHV0IG9uIE1hYyAoUXQgb25seSkKICAgLS1bbm8tXXN0cmlwLWVkaXRpbmctY2Fs bGJhY2tzICBSZW1vdmUgZWRpdGluZyBjYWxsYmFja3MgZnJvbSBleHBlY3RlZCByZXN1bHRzCiAg IC10fC0tdGhyZWFkZWQgICAgICAgICAgICAgICAgICAgUnVuIGEgY29uY3VycmVudCBKYXZhU2Ny aXB0IHRoZWFkIHdpdGggZWFjaCB0ZXN0CisgIC0tdGltZW91dCAgICAgICAgICAgICAgICAgICAg ICAgU2V0cyB0aGUgbGVuZ3RoIG9mIHRpbWUgYmVmb3JlIGEgdGVzdCB0aW1lcyBvdXQKICAgLS12 YWxncmluZCAgICAgICAgICAgICAgICAgICAgICBSdW4gRHVtcFJlbmRlclRyZWUgaW5zaWRlIHZh bGdyaW5kIChRdC9MaW51eCBvbmx5KQogICAtdnwtLXZlcmJvc2UgICAgICAgICAgICAgICAgICAg IE1vcmUgdmVyYm9zZSBvdXRwdXQgKG92ZXJyaWRlcyAtLXF1aWV0KQogICAtbXwtLW1lcmdlLWxl YWstZGVwdGggYXJnICAgICAgIE1lcmdlcyBsZWFrIGNhbGxTdGFja3MgYW5kIHByaW50cyB0aGUg bnVtYmVyIG9mIHVuaXF1ZSBsZWFrcyBiZW5lYXRoIGEgY2FsbHN0YWNrIGRlcHRoIG9mIGFyZy4g IERlZmF1bHRzIHRvIDUuCkBAIC0yNDUsNiArMjQ3LDcgQEAgbXkgJGdldE9wdGlvbnNSZXN1bHQg PSBHZXRPcHRpb25zKAogICAgICdyb290PXMnID0+IFwkcm9vdCwKICAgICAnYWRkLXBsYXRmb3Jt LWV4Y2VwdGlvbnMnID0+IFwkYWRkUGxhdGZvcm1FeGNlcHRpb25zLAogICAgICdtZXJnZS1sZWFr LWRlcHRofG06NScgPT4gXCRtZXJnZURlcHRoLAorICAgICd0aW1lb3V0LXNlY29uZHM9aScgPT4g XCR0aW1lb3V0U2Vjb25kcywKICk7CiAKIGlmICghJGdldE9wdGlvbnNSZXN1bHQgfHwgJHNob3dI ZWxwKSB7CkBAIC0xODA5LDcgKzE4MTIsNyBAQCBzdWIgcmVhZEZyb21EdW1wVG9vbFdpdGhUaW1l cigqOyQpCiAKICAgICBzZXRGaWxlSGFuZGxlTm9uQmxvY2tpbmcoJGZoLCAxKTsKIAotICAgIG15 ICRtYXhpbXVtU2Vjb25kc1dpdGhvdXRPdXRwdXQgPSAxNTsKKyAgICBteSAkbWF4aW11bVNlY29u ZHNXaXRob3V0T3V0cHV0ID0gJHRpbWVvdXRTZWNvbmRzOwogICAgICRtYXhpbXVtU2Vjb25kc1dp dGhvdXRPdXRwdXQgKj0gMTAgaWYgJGd1YXJkTWFsbG9jOwogICAgIG15ICRtaWNyb3NlY29uZHNU b1dhaXRCZWZvcmVSZWFkaW5nQWdhaW4gPSAxMDAwOwogCg== 29125 2009-03-31 10:53:26 -0700 2009-03-31 12:29:32 -0700 Allows run-webkit-tests to specify timeout test_timeout.txt text/plain 2279 bweinstein SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQyMTE3KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDMtMzEgIEJyaWFuIFdlaW5zdGVpbiAg PGJ3ZWluc3RlaW5AZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y NDkwOAorCisgICAgICAgIEFsbG93cyB0aW1lb3V0IHRvIGJlIHNldCBpbiBydW4td2Via2l0LXRl c3RzIGFzIGEgY29tbWFuZCBsaW5lIGFyZ3VtZW50LgkKKworICAgICAgICAqIFNjcmlwdHMvcnVu LXdlYmtpdC10ZXN0czoKKwogMjAwOS0wMy0zMCAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5j b20+CiAKICAgICAgICAgV2luZG93cyBidWlsZCBmaXgKSW5kZXg6IFdlYktpdFRvb2xzL1Njcmlw dHMvcnVuLXdlYmtpdC10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3J1 bi13ZWJraXQtdGVzdHMJKHJldmlzaW9uIDQyMTE3KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy9y dW4td2Via2l0LXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0xMzMsNiArMTMzLDcgQEAgbXkgJHJv b3Q7CiBteSAkcmV2ZXJzZVRlc3RzID0gMDsKIG15ICRyYW5kb21pemVUZXN0cyA9IDA7CiBteSAk bWVyZ2VEZXB0aDsKK215ICR0aW1lb3V0U2Vjb25kcyA9IDE1OwogbXkgQGxlYWtzRmlsZW5hbWVz OwogCiAjIERlZmF1bHQgdG8gLS1uby1odHRwIGZvciBRdCwgR3RrIGFuZCB3eCBmb3Igbm93LgpA QCAtMjA3LDYgKzIwOCw3IEBAIFVzYWdlOiAkcHJvZ3JhbU5hbWUgW29wdGlvbnNdIFt0ZXN0ZGly fHQKICAgLS1zdHJpY3QgICAgICAgICAgICAgICAgICAgICAgICBEbyBhIGNvbXBhcmlzb24gd2l0 aCB0aGUgb3V0cHV0IG9uIE1hYyAoUXQgb25seSkKICAgLS1bbm8tXXN0cmlwLWVkaXRpbmctY2Fs bGJhY2tzICBSZW1vdmUgZWRpdGluZyBjYWxsYmFja3MgZnJvbSBleHBlY3RlZCByZXN1bHRzCiAg IC10fC0tdGhyZWFkZWQgICAgICAgICAgICAgICAgICAgUnVuIGEgY29uY3VycmVudCBKYXZhU2Ny aXB0IHRoZWFkIHdpdGggZWFjaCB0ZXN0CisgIC0tdGltZW91dCB0ICAgICAgICAgICAgICAgICAg ICAgU2V0cyB0aGUgbnVtYmVyIG9mIHNlY29uZHMgYmVmb3JlIGEgdGVzdCB0aW1lcyBvdXQgKGRl ZmF1bHQ6ICR0aW1lb3V0U2Vjb25kcykKICAgLS12YWxncmluZCAgICAgICAgICAgICAgICAgICAg ICBSdW4gRHVtcFJlbmRlclRyZWUgaW5zaWRlIHZhbGdyaW5kIChRdC9MaW51eCBvbmx5KQogICAt dnwtLXZlcmJvc2UgICAgICAgICAgICAgICAgICAgIE1vcmUgdmVyYm9zZSBvdXRwdXQgKG92ZXJy aWRlcyAtLXF1aWV0KQogICAtbXwtLW1lcmdlLWxlYWstZGVwdGggYXJnICAgICAgIE1lcmdlcyBs ZWFrIGNhbGxTdGFja3MgYW5kIHByaW50cyB0aGUgbnVtYmVyIG9mIHVuaXF1ZSBsZWFrcyBiZW5l YXRoIGEgY2FsbHN0YWNrIGRlcHRoIG9mIGFyZy4gIERlZmF1bHRzIHRvIDUuCkBAIC0yNDUsNiAr MjQ3LDcgQEAgbXkgJGdldE9wdGlvbnNSZXN1bHQgPSBHZXRPcHRpb25zKAogICAgICdyb290PXMn ID0+IFwkcm9vdCwKICAgICAnYWRkLXBsYXRmb3JtLWV4Y2VwdGlvbnMnID0+IFwkYWRkUGxhdGZv cm1FeGNlcHRpb25zLAogICAgICdtZXJnZS1sZWFrLWRlcHRofG06NScgPT4gXCRtZXJnZURlcHRo LAorICAgICd0aW1lb3V0PWknID0+IFwkdGltZW91dFNlY29uZHMsCiApOwogCiBpZiAoISRnZXRP cHRpb25zUmVzdWx0IHx8ICRzaG93SGVscCkgewpAQCAtMTgwOSw3ICsxODEyLDcgQEAgc3ViIHJl YWRGcm9tRHVtcFRvb2xXaXRoVGltZXIoKjskKQogCiAgICAgc2V0RmlsZUhhbmRsZU5vbkJsb2Nr aW5nKCRmaCwgMSk7CiAKLSAgICBteSAkbWF4aW11bVNlY29uZHNXaXRob3V0T3V0cHV0ID0gMTU7 CisgICAgbXkgJG1heGltdW1TZWNvbmRzV2l0aG91dE91dHB1dCA9ICR0aW1lb3V0U2Vjb25kczsK ICAgICAkbWF4aW11bVNlY29uZHNXaXRob3V0T3V0cHV0ICo9IDEwIGlmICRndWFyZE1hbGxvYzsK ICAgICBteSAkbWljcm9zZWNvbmRzVG9XYWl0QmVmb3JlUmVhZGluZ0FnYWluID0gMTAwMDsKIAo=