248879 2022-12-07 08:06:01 -0800 Properly resolve fullscreen API promises 2024-11-13 17:13:49 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=248900 https://bugs.webkit.org/show_bug.cgi?id=282998 InRadar P2 Normal --- 1 ntim ntim andrewhodel ddkilzer webkit-bug-importer oldest_to_newest 1917230 0 ntim 2022-12-07 08:06:01 -0800 exitFullscreen() promises should resolve in FullscreenManager::finishExitFullscreen(). requestFullscreen() promises should resolve in FullscreenManager::willEnterFullscreen(). These methods FullscreenManager are called asynchronously, so it might be tricky however. 1917234 1 ntim 2022-12-07 08:21:10 -0800 rdar://103074395 1918070 2 ntim 2022-12-09 15:16:40 -0800 Pull request: https://github.com/WebKit/WebKit/pull/7415 1918143 3 ews-feeder 2022-12-09 20:03:55 -0800 Committed 257668@main (9696329f7af6): <https://commits.webkit.org/257668@main> Reviewed commits have been landed. Closing PR #7415 and removing active labels. 1918195 4 ddkilzer 2022-12-10 10:12:52 -0800 I'm pretty sure this is causing 4-5 layout test crashes on EWS runs now. 1918527 5 ddkilzer 2022-12-12 10:30:41 -0800 (In reply to David Kilzer (:ddkilzer) from comment #4) > I'm pretty sure this is causing 4-5 layout test crashes on EWS runs now. Specific examples: PR: <https://github.com/WebKit/WebKit/pull/7430> Run: <https://ews-build.webkit.org/#/builders/73/builds/21968> Results: <https://ews-build.s3-us-west-2.amazonaws.com/macOS-BigSur-Release-WK1-Tests-EWS/c887a3c0-21968/results.html> Crashing tests: fullscreen/full-screen-request-removed.html media/modern-media-controls/layout-node/addChild.html media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html media/modern-media-controls/seek-forward-support/seek-forward-support.html PR: <https://github.com/WebKit/WebKit/pull/7428> Run: <https://ews-build.webkit.org/#/builders/73/builds/21964> Results: <https://ews-build.s3-us-west-2.amazonaws.com/macOS-BigSur-Release-WK1-Tests-EWS/37345d6b-21964/results.html> Crashing tests: fullscreen/full-screen-request-removed.html crash log sample history media/modern-media-controls/media-controls/media-controls-display-above-captions.html media/modern-media-controls/mute-button/mute-button.html media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html media/modern-media-controls/start-support/start-support-audio.html pageoverlay/overlay-large-document-scrolled.html These seem to be fixed as of Monday morning, though. 1918536 6 ntim 2022-12-12 10:57:08 -0800 Crashes were fixed by https://github.com/WebKit/WebKit/pull/7443 2074988 7 karlcow 2024-11-13 17:13:49 -0800 *** Bug 282998 has been marked as a duplicate of this bug. ***