24879 2009-03-27 02:06:54 -0700 Add frame accessors to Screen, Console, and BarInfo objects. 2009-03-30 07:55:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 ager webkit-unassigned dglazkov oldest_to_newest 115513 0 ager 2009-03-27 02:06:54 -0700 Add frame accessor to Screen, Console, and BarInfo objects. Add type accessor to BarInfo objects. In the V8 JavaScript bindings, we need access to the frame and type for already created Screen, Console and BarInfo objects in order to keep their wrappers alive across GCs. 115514 1 29006 ager 2009-03-27 02:07:47 -0700 Created attachment 29006 Patch to add accessors. 115541 2 29006 darin 2009-03-27 07:17:22 -0700 Comment on attachment 29006 Patch to add accessors. Unfortunate these need to be exposed, but harmless. 115817 3 dglazkov 2009-03-30 07:55:41 -0700 Landed as http://trac.webkit.org/changeset/42100. 29006 2009-03-27 02:07:47 -0700 2009-03-27 07:17:22 -0700 Patch to add accessors. patch.txt text/plain 3685 ager SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjAzMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjYgQEAKKzIwMDktMDMtMjcgIE1hZHMgQWdlciAgPGFnZXJAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBm cmFtZSBhY2Nlc3NvciB0byBTY3JlZW4sIENvbnNvbGUsIGFuZCBCYXJJbmZvIG9iamVjdHMuCisK KyAgICAgICAgQWRkIHR5cGUgYWNjZXNzb3IgdG8gQmFySW5mbyBvYmplY3RzLgorCisgICAgICAg IEluIHRoZSBWOCBKYXZhU2NyaXB0IGJpbmRpbmdzLCB3ZSBuZWVkIGFjY2VzcyB0byB0aGUgZnJh bWUgYW5kCisgICAgICAgIHR5cGUgZm9yIGFscmVhZHkgY3JlYXRlZCBTY3JlZW4sIENvbnNvbGUs IGFuZCBCYXJJbmZvIG9iamVjdHMgaW4KKyAgICAgICAgb3JkZXIgdG8ga2VlcCB0aGVpciB3cmFw cGVycyBhbGl2ZSBhY3Jvc3MgR0NzLgorCisgICAgICAgICogcGFnZS9CYXJJbmZvLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkJhckluZm86OmZyYW1lKToKKyAgICAgICAgKFdlYkNvcmU6OkJhcklu Zm86OnR5cGUpOgorICAgICAgICAqIHBhZ2UvQmFySW5mby5oOgorICAgICAgICAqIHBhZ2UvQ29u c29sZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb25zb2xlOjpmcmFtZSk6CisgICAgICAgICog cGFnZS9Db25zb2xlLmg6CisgICAgICAgICogcGFnZS9TY3JlZW4uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6U2NyZWVuOjpmcmFtZSk6CisgICAgICAgICogcGFnZS9TY3JlZW4uaDoKKwogMjAwOS0w My0yNiAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIFRyeSBhbmQgZml4 IHRoZSBRdCBidWlsZC4KSW5kZXg6IFdlYkNvcmUvcGFnZS9CYXJJbmZvLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3BhZ2UvQmFySW5mby5jcHAJKHJldmlzaW9uIDQyMDMxKQorKysgV2ViQ29y ZS9wYWdlL0JhckluZm8uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MSwxMSArNDEsMjEgQEAgQmFy SW5mbzo6QmFySW5mbyhGcmFtZSogZnJhbWUsIFR5cGUgdHlwZQogewogfQogCitGcmFtZSogQmFy SW5mbzo6ZnJhbWUoKSBjb25zdAoreworICAgIHJldHVybiBtX2ZyYW1lOworfQorCiB2b2lkIEJh ckluZm86OmRpc2Nvbm5lY3RGcmFtZSgpCiB7CiAgICAgbV9mcmFtZSA9IDA7CiB9CiAKK0Jhcklu Zm86OlR5cGUgQmFySW5mbzo6dHlwZSgpIGNvbnN0Cit7CisgICAgcmV0dXJuIG1fdHlwZTsKK30K KwogYm9vbCBCYXJJbmZvOjp2aXNpYmxlKCkgY29uc3QKIHsKICAgICBpZiAoIW1fZnJhbWUpCklu ZGV4OiBXZWJDb3JlL3BhZ2UvQmFySW5mby5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9C YXJJbmZvLmgJKHJldmlzaW9uIDQyMDMxKQorKysgV2ViQ29yZS9wYWdlL0JhckluZm8uaAkod29y a2luZyBjb3B5KQpAQCAtNDIsOCArNDIsMTEgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAg ICAgIHN0YXRpYyBQYXNzUmVmUHRyPEJhckluZm8+IGNyZWF0ZShGcmFtZSogZnJhbWUsIFR5cGUg dHlwZSkgeyByZXR1cm4gYWRvcHRSZWYobmV3IEJhckluZm8oZnJhbWUsIHR5cGUpKTsgfQogCisg ICAgICAgIEZyYW1lKiBmcmFtZSgpIGNvbnN0OwogICAgICAgICB2b2lkIGRpc2Nvbm5lY3RGcmFt ZSgpOwogCisgICAgICAgIFR5cGUgdHlwZSgpIGNvbnN0OworCiAgICAgICAgIGJvb2wgdmlzaWJs ZSgpIGNvbnN0OwogCiAgICAgcHJpdmF0ZToKSW5kZXg6IFdlYkNvcmUvcGFnZS9Db25zb2xlLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvQ29uc29sZS5jcHAJKHJldmlzaW9uIDQyMDMx KQorKysgV2ViQ29yZS9wYWdlL0NvbnNvbGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Myw2ICs1 MywxMSBAQCBDb25zb2xlOjpDb25zb2xlKEZyYW1lKiBmcmFtZSkKIHsKIH0KIAorRnJhbWUqIENv bnNvbGU6OmZyYW1lKCkgY29uc3QKK3sKKyAgICByZXR1cm4gbV9mcmFtZTsKK30KKwogdm9pZCBD b25zb2xlOjpkaXNjb25uZWN0RnJhbWUoKQogewogICAgIG1fZnJhbWUgPSAwOwpJbmRleDogV2Vi Q29yZS9wYWdlL0NvbnNvbGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvQ29uc29sZS5o CShyZXZpc2lvbiA0MjAzMSkKKysrIFdlYkNvcmUvcGFnZS9Db25zb2xlLmgJKHdvcmtpbmcgY29w eSkKQEAgLTc1LDYgKzc1LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIHB1YmxpYzoKICAg ICAgICAgc3RhdGljIFBhc3NSZWZQdHI8Q29uc29sZT4gY3JlYXRlKEZyYW1lKiBmcmFtZSkgeyBy ZXR1cm4gYWRvcHRSZWYobmV3IENvbnNvbGUoZnJhbWUpKTsgfQogCisgICAgICAgIEZyYW1lKiBm cmFtZSgpIGNvbnN0OwogICAgICAgICB2b2lkIGRpc2Nvbm5lY3RGcmFtZSgpOwogCiAgICAgICAg IHZvaWQgYWRkTWVzc2FnZShNZXNzYWdlU291cmNlLCBNZXNzYWdlTGV2ZWwsIGNvbnN0IFN0cmlu ZyYgbWVzc2FnZSwgdW5zaWduZWQgbGluZU51bWJlciwgY29uc3QgU3RyaW5nJiBzb3VyY2VVUkwp OwpJbmRleDogV2ViQ29yZS9wYWdlL1NjcmVlbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9w YWdlL1NjcmVlbi5jcHAJKHJldmlzaW9uIDQyMDMxKQorKysgV2ViQ29yZS9wYWdlL1NjcmVlbi5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTQzLDYgKzQzLDExIEBAIFNjcmVlbjo6U2NyZWVuKEZyYW1l KiBmcmFtZSkKIHsKIH0KIAorRnJhbWUqIFNjcmVlbjo6ZnJhbWUoKSBjb25zdAoreworICAgIHJl dHVybiBtX2ZyYW1lOworfQorCiB2b2lkIFNjcmVlbjo6ZGlzY29ubmVjdEZyYW1lKCkKIHsKICAg ICBtX2ZyYW1lID0gMDsKSW5kZXg6IFdlYkNvcmUvcGFnZS9TY3JlZW4uaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BhZ2UvU2NyZWVuLmgJKHJldmlzaW9uIDQyMDMxKQorKysgV2ViQ29yZS9wYWdl L1NjcmVlbi5oCSh3b3JraW5nIGNvcHkpCkBAIC00MCw2ICs0MCw4IEBAIG5hbWVzcGFjZSBXZWJD b3JlIHsKICAgICBjbGFzcyBTY3JlZW4gOiBwdWJsaWMgUmVmQ291bnRlZDxTY3JlZW4+IHsKICAg ICBwdWJsaWM6CiAgICAgICAgIHN0YXRpYyBQYXNzUmVmUHRyPFNjcmVlbj4gY3JlYXRlKEZyYW1l ICpmcmFtZSkgeyByZXR1cm4gYWRvcHRSZWYobmV3IFNjcmVlbihmcmFtZSkpOyB9CisKKyAgICAg ICAgRnJhbWUqIGZyYW1lKCkgY29uc3Q7CiAgICAgICAgIHZvaWQgZGlzY29ubmVjdEZyYW1lKCk7 CiAKICAgICAgICAgdW5zaWduZWQgaGVpZ2h0KCkgY29uc3Q7Cg==