24877 2009-03-26 22:43:05 -0700 REGRESSION: Leaks from ApplicationCache code running http/tests/appcache/non-html.xhtml 2009-08-21 17:01:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.5 RESOLVED WORKSFORME P1 Normal --- 1 eric webkit-unassigned ap darin ggaren oldest_to_newest 115496 0 eric 2009-03-26 22:43:05 -0700 http://build.webkit.org/results/trunk-mac-intel-debug/6379/DumpRenderTree-leaks.txt ApplicationCache, ApplicationCacheGroup, ApplicationCacheStorage Might be from the marking changes today, but I kinda doubt it. 115498 1 eric 2009-03-26 23:05:01 -0700 Might be related to this crash seen running the storage tests: ASSERTION FAILED: isMainThread() || m_emptyString->hasOneRef() (/Stuff/Projects/WebKit/WebCore/platform/ThreadGlobalData.cpp:97 WebCore::ThreadGlobalData::~ThreadGlobalData()) 115503 2 eric 2009-03-27 00:05:07 -0700 bdash notes that these occurred at least as early as last thursday: http://build.webkit.org/builders/trunk-mac-intel-debug/builds/6300 115504 3 eric 2009-03-27 00:08:16 -0700 http://build.webkit.org/builders/trunk-mac-intel-debug/builds/6296 Seems to be the first build to show the regression. 115505 4 eric 2009-03-27 00:20:09 -0700 It's possible these could have started appearing around a bot upgrade, since earlier leaks, like: http://build.webkit.org/results/trunk-mac-intel-debug/6285/DumpRenderTree-leaks.txt show at least a loader-related leak. A bot upgrade could have changed CFNetwork or the leaks tool. The changes in 6296 don't look very related: http://build.webkit.org/builders/trunk-mac-intel-debug/builds/6296 115506 5 eric 2009-03-27 00:31:00 -0700 Found a culprit: running http/tests/appcache/non-html.xhtml -> http/tests/appcache/non-html.xhtml -> succeeded ? checking for leaks in DumpRenderTree - no leaks found LEAK: 27 WebCoreNode LEAK: 1 CachedResource run-webkit-tests --leaks http/tests/appcache/non-html.xhtml will reproduce at least one of the sets of leaks. 115507 6 eric 2009-03-27 00:35:51 -0700 I've verified that http/tests/appcache/non-html.xhtml is the *only* leaking ApplicationCache test. 115508 7 eric 2009-03-27 00:39:59 -0700 Actually, I"m wrong. The case I reproduced with http/tests/appcache/non-html.xhtml only spits out LEAK message, not stacks from the leaks tool. 115509 8 eric 2009-03-27 00:43:02 -0700 http/tests/appcache/non-html.xhtml was added as part of: http://trac.webkit.org/changeset/40401 I've not yet tested that revision to see if it shows leaks then. 142036 9 ap 2009-08-21 16:08:14 -0700 The LEAK message is red herring - the CachedResource isn't deleted because DRT doesn't destroy its last document. Looking at leaks for current ToT, I only see a bunch coming from CFNetwork (under XMLHttpRequest). There are certainly leaks on appcache tests, but it's not clear whether they are WebKit or CFNetwork issue. I used to think that they were the latter, but bdash found some evidence to the contrary. I'm investigating that now, but it seems to be a separate issue. 142041 10 eric 2009-08-21 16:19:06 -0700 I don't wish to argue about the closing of the bug. Just with this statement: "The LEAK message is red herring - the CachedResource isn't deleted because DRT doesn't destroy its last document." Do we still see LEAK messages from this code? If so, we need to either fix the LEAK messages to not print, fix the leaks, or fix DRT to not trigger them. :) Leak counts are useless if not expected to be 0. 142052 11 ap 2009-08-21 17:01:10 -0700 Yes, improving DRT would be good - the LEAK messages are still there. In other news, I'm preparing a patch that fixes all leaks (not LEAKS) on appcache tests for me.