24876 2009-03-26 22:08:37 -0700 fast/forms/select-max-length.html times out in debug builds due to HTMLSelectElement::setLength being O(N^2) 2009-03-27 14:34:17 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mrowe webkit-unassigned andersca ap aroben mrowe pkasting simon.fraser oldest_to_newest 115493 0 mrowe 2009-03-26 22:08:37 -0700 After <http://trac.webkit.org/changeset/42012>, fast/forms/select-max-length.html is frequently timing out on my MacBook Pro in a debug build. Running the test manually shows it takes around 17 seconds to complete, which is above the new 15s threshold. 115494 1 simon.fraser 2009-03-26 22:09:57 -0700 It looks like HTMLSelectElement::setLength() is O(N^2) 115549 2 aroben 2009-03-27 09:02:11 -0700 Maybe we should back out r42012 115550 3 aroben 2009-03-27 09:02:37 -0700 (Obviously it would be good to improve the test's performance, too!) 115563 4 mrowe 2009-03-27 09:58:03 -0700 *** Bug 24889 has been marked as a duplicate of this bug. *** 115564 5 mrowe 2009-03-27 09:59:38 -0700 Fixing HTMLSelectElement::setLength would be a better idea, unless there are other tests also timing out. 115595 6 mrowe 2009-03-27 14:09:34 -0700 I have a patch that drops the time of this test from 17 seconds down to around 4.5 seconds by improving HTMLSelectElement::setLength. I need to verify that the change is safe in the face of fun things like mutation events, and then will put a patch up for review. 115601 7 mrowe 2009-03-27 14:34:17 -0700 Fixed in r42050.