24869 2009-03-26 19:19:55 -0700 [Qt] tst_qwebpage.cpp has an incorrect case 2009-03-27 05:59:55 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 elbunce webkit-unassigned hausmann oldest_to_newest 115471 0 elbunce 2009-03-26 19:19:55 -0700 When running tst_qwebpage I get the following failure: FAIL! : tst_QWebPage::cursorMovements() Compared values are not the same Actual (page->selectionStartOffset()): 0 Expected (2): 2 Loc: [/Users/erik/work/webkit-svn2/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(835)] After analyzing the code, it turns out that the Expected value in the test was incorrect and not the Actual. In this case the cursor is expected to be before the word "be", which occurs immediately after a <br/>, so the selectionStartOffset() should be 0, and not 2. 115472 1 28999 elbunce 2009-03-26 19:26:41 -0700 Created attachment 28999 Fix to make the expected value 0 and not 2 Fix split out of patch 28829 of bug #24746 per request of Simon Hausmann. 115525 2 28999 hausmann 2009-03-27 05:59:41 -0700 Comment on attachment 28999 Fix to make the expected value 0 and not 2 Good catch. 115527 3 hausmann 2009-03-27 05:59:55 -0700 Landed in r42035 28999 2009-03-26 19:26:41 -0700 2009-03-27 05:59:41 -0700 Fix to make the expected value 0 and not 2 tst_qwebpage_case.patch text/plain 1164 elbunce SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNDIwMjUpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDMtMjYgIEVyaWsgTC4gQnVuY2UgIDxlbGJ1bmNl QHhlbmRvbS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRml4ZXMgYW4gaW5jb3JyZWN0IGNhc2UgaW4gdHN0X3F3ZWJwYWdlLgorCisgICAgICAg ICogdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKHRzdF9RV2ViUGFn ZTo6Y3Vyc29yTW92ZW1lbnRzKToKKwogMjAwOS0wMy0yNiAgU2ltb24gSGF1c21hbm4gIDxzaW1v bi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgVG9yIEFy bmUgVmVzdGLDuC4KSW5kZXg6IFdlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2Uu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2Uu Y3BwCShyZXZpc2lvbiA0MjAwOCkKKysrIFdlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdl YnBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MzIsNyArODMyLDcgQEAgdm9pZCB0c3RfUVdl YlBhZ2U6OmN1cnNvck1vdmVtZW50cygpCiAgICAgLy8gY3Vyc29yIHdpbGwgYmUgYmVmb3JlIHRo ZSB3b3JkICJiZSIKICAgICBwYWdlLT50cmlnZ2VyQWN0aW9uKFFXZWJQYWdlOjpNb3ZlVG9TdGFy dE9mQmxvY2spOwogICAgIFFWRVJJRlkocGFnZS0+aXNTZWxlY3Rpb25Db2xsYXBzZWQoKSk7Ci0g ICAgUUNPTVBBUkUocGFnZS0+c2VsZWN0aW9uU3RhcnRPZmZzZXQoKSwgMik7CisgICAgUUNPTVBB UkUocGFnZS0+c2VsZWN0aW9uU3RhcnRPZmZzZXQoKSwgMCk7CiAKICAgICAvLyBjdXJzb3Igd2ls bCBiZSBhZnRlciB0aGUgd29yZCAieW91ISIKICAgICBwYWdlLT50cmlnZ2VyQWN0aW9uKFFXZWJQ YWdlOjpNb3ZlVG9FbmRPZkJsb2NrKTsK