248682 2022-12-02 13:27:47 -0800 Clean up some options initialization workflow. 2022-12-02 16:29:41 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam webkit-bug-importer oldest_to_newest 1916327 0 mark.lam 2022-12-02 13:27:47 -0800 We always call correctOptions() before recomputeDependentOptions(), and often call dumpOptionsIfNeeded() and ensureOptionsAreCoherent() after. This patch makes things more consistent by: 1. Rename recomputeDependentOptions() to notifyOptionsChanged(). 2. Rename ensureOptionsAreCoherent() to assertOptionsAreCoherent(), because "ensure" implies that the function will make them coherent. Instead, the function asserts that they are coherent. 3. Move the body of correctOptions() (which is a tiny function) into the top of notifyOptionsChanged(). 4. Call dumpOptionsIfNeeded() and assertOptionsAreCoherent() at the end of notifyOptionsChanged() instead of from clients. 5. Make sure clients call notifyOptionsChanged() after changing options. Additionally: 6. Rename ExecutableAllocator:: setJITEnabled() to ExecutableAllocator::disableJIT(). Disabling JIT in this function was always a one way street, and there's no going back. This rename makes it clear and explicit. 1916328 1 webkit-bug-importer 2022-12-02 13:28:13 -0800 <rdar://problem/102916238> 1916331 2 mark.lam 2022-12-02 13:41:21 -0800 <rdar://problem/102916238> 1916332 3 mark.lam 2022-12-02 13:43:08 -0800 <rdar://problem/102844335> 1916340 4 mark.lam 2022-12-02 14:33:47 -0800 Pull request: https://github.com/WebKit/WebKit/pull/7095 1916380 5 ews-feeder 2022-12-02 16:29:33 -0800 Committed 257311@main (6d72ef261e4a): <https://commits.webkit.org/257311@main> Reviewed commits have been landed. Closing PR #7095 and removing active labels.