24852 2009-03-26 13:37:39 -0700 Inconsistent flags might lead to link failure for ARM/RVCT release builds 2009-03-27 06:05:23 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 laszlo.gombos webkit-unassigned carol hausmann norbert.leser oldest_to_newest 115392 0 laszlo.gombos 2009-03-26 13:37:39 -0700 Fix regression introduced by http://trac.webkit.org/changeset/40404. During GNU mode RVCT compilation __GNUC__ is defined but COMPILER(GCC) is false. The output of gperf (HTMLEntityNames.c) generates code which will use the __GNUC__ flag; so PreloadScanner.cpp needs to use the __GNUC__ flag to stay consistent, otherwise GNU mode RVCT compilation will fail to link. The solution is to simply revert the change in PreloadScanner.cpp. Patch will follow. 115410 1 28985 laszlo.gombos 2009-03-26 14:04:23 -0700 Created attachment 28985 Revert change in PreloadScanner.cpp made by r40404 115528 2 28985 hausmann 2009-03-27 06:05:04 -0700 Comment on attachment 28985 Revert change in PreloadScanner.cpp made by r40404 Looks good to me 115529 3 hausmann 2009-03-27 06:05:23 -0700 Landed in r42036 28985 2009-03-26 14:04:23 -0700 2009-03-27 06:05:04 -0700 Revert change in PreloadScanner.cpp made by r40404 patch_24852.txt text/plain 1097 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjAxNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDMtMjYgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDg1MgorICAg ICAgICBCdWlsZCBmaXggZm9yIEdOVSBtb2RlIFJWQ1QgY29tcGlsYXRpb24KKworICAgICAgICAq IGh0bWwvUHJlbG9hZFNjYW5uZXIuY3BwOgorCiAyMDA5LTAzLTI2ICBEYW4gQmVybnN0ZWluICA8 bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpJ bmRleDogV2ViQ29yZS9odG1sL1ByZWxvYWRTY2FubmVyLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL2h0bWwvUHJlbG9hZFNjYW5uZXIuY3BwCShyZXZpc2lvbiA0MjAxNSkKKysrIFdlYkNvcmUv aHRtbC9QcmVsb2FkU2Nhbm5lci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ0LDcgKzQ0LDggQEAK ICNpbmNsdWRlIDx3dGYvQ3VycmVudFRpbWUuaD4KICNpbmNsdWRlIDx3dGYvdW5pY29kZS9Vbmlj b2RlLmg+CiAKLSNpZiBDT01QSUxFUihHQ0MpCisvLyBVc2UgX19HTlVDX18gaW5zdGVhZCBvZiBQ TEFURk9STShHQ0MpIHRvIHN0YXkgY29uc2lzdGVudCB3aXRoIHRoZSBncGVyZiBnZW5lcmF0ZWQg YyBmaWxlCisjaWZkZWYgX19HTlVDX18KIC8vIFRoZSBtYWluIHRva2VuaXplciBpbmNsdWRlcyB0 aGlzIHRvbyBzbyB3ZSBhcmUgZ2V0dGluZyB0d28gY29waWVzIG9mIHRoZSBkYXRhLiBIb3dldmVy LCB0aGlzIHdheSB0aGUgY29kZSBnZXRzIGlubGluZWQuCiAjaW5jbHVkZSAiSFRNTEVudGl0eU5h bWVzLmMiCiAjZWxzZQo=