248466 2022-11-29 06:44:48 -0800 [ews] re-run-layout-tests should use results database instead of doing clean-tree runs 2022-12-08 13:04:01 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=204368 InRadar P2 Normal --- 1 aakash_jain aakash_jain ap ryanhaddad webkit-bug-importer oldest_to_newest 1915285 0 aakash_jain 2022-11-29 06:44:48 -0800 [ews] re-run-layout-tests should use results database instead of doing clean-tree runs. For example in https://ews-build.webkit.org/#/builders/10/builds/167694 layout-tests step had 4 failures and 3 of them were pre-existing as per results db (see https://ews-build.webkit.org/#/builders/10/builds/167694/steps/16/logs/stdio), but even though the fourth one (streams/readable-stream-default-controller-error.html) wasn't failing in results db, it was actually flaky, and it did not fail in re-run-layout-tests step (https://ews-build.webkit.org/#/builders/10/builds/167694/steps/22/logs/test-failures doesn't have that test failure). EWS did run-layout-tests-without-change (after compiling webkit) and reached this conclusion, but all that extra compilation and run-layout-tests-without-change could have been avoided, if re-run-layout-tests consulted results database. 1915290 1 webkit-bug-importer 2022-11-29 07:16:03 -0800 <rdar://problem/102764839> 1915291 2 aakash_jain 2022-11-29 07:16:50 -0800 Pull request: https://github.com/WebKit/WebKit/pull/6917 1915292 3 aakash_jain 2022-11-29 07:19:28 -0800 This is also needed in cases like https://ews-build.webkit.org/#/builders/10/builds/167706 where the first layout-test run failed to run because of some reason (e.g.: infra issue). 1915296 4 ews-feeder 2022-11-29 08:00:05 -0800 Committed 257117@main (a6df5e4d036f): <https://commits.webkit.org/257117@main> Reviewed commits have been landed. Closing PR #6917 and removing active labels. 1915302 5 aakash_jain 2022-11-29 08:27:21 -0800 More examples where this change would have helped: https://ews-build.webkit.org/#/builders/60/builds/44663 (flaky failure in first run) https://ews-build.webkit.org/#/builders/10/builds/167706 (first run failed due to infra issue) 1915314 6 aakash_jain 2022-11-29 09:09:22 -0800 Restarted EWS to pick up this change.