248449 2022-11-28 17:35:52 -0800 REGRESSION(257041@main): [ macOS ] 2X transitions/ (Layout-Tests are constant timeouts 2022-11-30 17:38:05 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jenner obrufau obrufau simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1915179 0 jenner 2022-11-28 17:35:52 -0800 The following two transitions/ (Layout-tests) are constant timeouts on macOS starting at 257041@main: transitions/shorthand-transitions.html transitions/border-radius-transition.html HISTORY: https://results.webkit.org/?platform=mac&suite=layout-tests&suite=layout-tests&test=transitions%2Fborder-radius-transition.html&test=transitions%2Fshorthand-transitions.html 1915181 1 webkit-bug-importer 2022-11-28 17:36:25 -0800 <rdar://problem/102742539> 1915184 2 jenner 2022-11-28 17:40:19 -0800 I was able to reproduce the timeouts at Ventura Debug ToT running the test as follows: run-webkit-tests <insert_test_here> 1915186 3 ews-feeder 2022-11-28 17:55:18 -0800 Test gardening commit 257098@main (e9b769950822): <https://commits.webkit.org/257098@main> Reviewed commits have been landed. Closing PR #6902 and removing active labels. 1915187 4 jenner 2022-11-28 17:56:38 -0800 I tried running the tests with the --no-timeout flag as well. After 10 minutes each the tests never ran. So these do appear to be legit timeouts, and not just slow tests. So I've added [ Timeout ] to the test's expectations at the commit above. It should also be noted that both of these tests were failing before 257041@main. There is just an expectation marked as [ Pass Failure ] 1915188 5 jenner 2022-11-28 17:57:38 -0800 Starting on Oriol who committed the change that caused these two tests to constantly timeout. 1915189 6 obrufau 2022-11-28 17:59:09 -0800 Ah, that's because I made getComputedStyle().getPropertyCSSValue() consistently return a CSSValuePair, which throws when transition-test-helpers.js attempts to use getFloatValue(). The solution seems to use getPropertyValue() instead. Also adding a try..catch seems a good idea. 1915305 7 obrufau 2022-11-29 08:28:47 -0800 Pull request: https://github.com/WebKit/WebKit/pull/6915 1915786 8 ews-feeder 2022-11-30 17:25:39 -0800 Committed 257208@main (4ee897dd423c): <https://commits.webkit.org/257208@main> Reviewed commits have been landed. Closing PR #6915 and removing active labels. 1915793 9 simon.fraser 2022-11-30 17:38:05 -0800 There's equivalent code in LayoutTests/animations/animation-test-helpers.js (sadly)