248424 2022-11-28 14:20:56 -0800 imported/w3c/web-platform-tests/fetch/stale-while-revalidate/revalidate-not-blocked-by-csp.html times out 2022-11-29 18:21:14 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://github.com/web-platform-tests/wpt/pull/37213 InRadar P2 Normal --- 1 rreno rreno webkit-bug-importer oldest_to_newest 1915107 0 rreno 2022-11-28 14:20:56 -0800 This test times out waiting for the server to return a Count header with a value of 2. It's stuck sending back 1. Could be a bug in the python that acts as a server and not necessarily in WebKit itself. All browsers fail this test (and all stale-while-revalidate tests) on WPT. 1915108 1 webkit-bug-importer 2022-11-28 14:21:21 -0800 <rdar://problem/102734100> 1915127 2 rreno 2022-11-28 15:04:31 -0800 Fix for this is pretty simple. The Python server only increments the count when there isn't a `query` parameter in the request. The initial fetch to get the image incremented the counter to 1 but in the test's "wait for revalidate" loop we always called fetch with the `query` URL parameter. This caused the server to never increment count. I added a boolean which we flip every other loop. This boolean determines whether or not we add `query` to the URL and in turn whether or not the server will increment the count. 1915140 3 rreno 2022-11-28 15:47:01 -0800 Pull request: https://github.com/WebKit/WebKit/pull/6893 1915141 4 rreno 2022-11-28 15:48:00 -0800 Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/37213 1915494 5 ews-feeder 2022-11-29 18:21:13 -0800 Committed 257154@main (ee768c0b2c58): <https://commits.webkit.org/257154@main> Reviewed commits have been landed. Closing PR #6893 and removing active labels.