24836 2009-03-25 17:24:33 -0700 Chromium's navigator.plugins.refresh(false) does nothing 2009-03-27 15:35:36 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 jam dimich oldest_to_newest 115270 0 jam 2009-03-25 17:24:33 -0700 It's supposed to reload the plugin list, but not the page. Chromium's implementation didn't reload the plugin list until it was first accessed. 115272 1 28955 jam 2009-03-25 17:27:41 -0700 Created attachment 28955 Fix 115352 2 28955 eric 2009-03-26 10:56:14 -0700 Comment on attachment 28955 Fix OK. Looks sane. You should document what that line is actually for with a comment. I assume this has no layout test because the layout tests are in chromium's tree (and this doesn't affect any other platform?) 115376 3 28977 jam 2009-03-26 12:30:39 -0700 Created attachment 28977 added comment 115377 4 jam 2009-03-26 12:33:26 -0700 Added comment. Can you commit for me (I'm not a committer)? This doesn't affect other ports. The place to add a test would be in Chromium's ui tests. I didn't add one yet because I would need to create a new NPAPI plugin just to test this scenario. I'll look into doing it now. 115379 5 fishd 2009-03-26 12:47:57 -0700 john, can't you utilize the layout tests for this? it is best if webkit specific patches are tested with layout tests. if that can't be done, then in the chromium world test_shell tests could be used. if we have to resort to chromium ui tests, then we are far removed from the webkit code, which could mean that we only discover a regression once we update the webkit code used by chromium. 115387 6 jam 2009-03-26 13:15:03 -0700 To test this change, one would need two NPAPI plugins. The first would have to move the second, get the list of plugins, then move it back and check that refresh(false) caused the list to be updated. Chromium's two test NPAPI plugins are not in the WebKit tree so a layout test won't work. I'll look into putting it into testshell_tests instead. 115484 7 jam 2009-03-26 20:22:51 -0700 I've added a test_shell_tests test for this. Can someone commit this, because I can't check in the other change until this one lands or else the test will fail. 115485 8 jam 2009-03-26 20:23:08 -0700 Here's the test: http://codereview.chromium.org/42687 115630 9 dimich 2009-03-27 15:35:36 -0700 Landed: http://trac.webkit.org/changeset/42052 28955 2009-03-25 17:27:41 -0700 2009-03-26 12:30:39 -0700 Fix refresh.txt text/plain 1042 jam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTk5NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDMtMjUgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGdvb2ds ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0ODM2CisKKyAgICAgICAg Rml4IG5hdmlnYXRvci5wbHVnaW5zLnJlZnJlc2goZmFsc2UpIGluIENocm9taXVtLgorCisgICAg ICAgICogcGx1Z2lucy9jaHJvbWl1bS9QbHVnaW5EYXRhQ2hyb21pdW0uY3BwOgorICAgICAgICAo V2ViQ29yZTo6UGx1Z2luRGF0YTo6cmVmcmVzaCk6CisKIDIwMDktMDMtMjUgIERhdmlkIExldmlu ICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xh emtvdi4KSW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9jaHJvbWl1bS9QbHVnaW5EYXRhQ2hyb21pdW0u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGx1Z2lucy9jaHJvbWl1bS9QbHVnaW5EYXRhQ2hy b21pdW0uY3BwCShyZXZpc2lvbiA0MTk5NSkKKysrIFdlYkNvcmUvcGx1Z2lucy9jaHJvbWl1bS9Q bHVnaW5EYXRhQ2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05NSw2ICs5NSw3IEBAIHZv aWQgUGx1Z2luRGF0YTo6aW5pdFBsdWdpbnMoKQogdm9pZCBQbHVnaW5EYXRhOjpyZWZyZXNoKCkK IHsKICAgICBwbHVnaW5DYWNoZS5yZXNldCh0cnVlKTsKKyAgICBwbHVnaW5DYWNoZS5wbHVnaW5z KCk7CiB9CiAKIFN0cmluZyBnZXRQbHVnaW5NaW1lVHlwZUZyb21FeHRlbnNpb24oY29uc3QgU3Ry aW5nJiBleHRlbnNpb24pCg== 28977 2009-03-26 12:30:39 -0700 2009-03-26 12:30:39 -0700 added comment refresh.txt text/plain 1084 jam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTk5NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDMtMjUgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGdvb2ds ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0ODM2CisKKyAgICAgICAg Rml4IG5hdmlnYXRvci5wbHVnaW5zLnJlZnJlc2goZmFsc2UpIGluIENocm9taXVtLgorCisgICAg ICAgICogcGx1Z2lucy9jaHJvbWl1bS9QbHVnaW5EYXRhQ2hyb21pdW0uY3BwOgorICAgICAgICAo V2ViQ29yZTo6UGx1Z2luRGF0YTo6cmVmcmVzaCk6CisKIDIwMDktMDMtMjUgIERhdmlkIExldmlu ICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xh emtvdi4KSW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9jaHJvbWl1bS9QbHVnaW5EYXRhQ2hyb21pdW0u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGx1Z2lucy9jaHJvbWl1bS9QbHVnaW5EYXRhQ2hy b21pdW0uY3BwCShyZXZpc2lvbiA0MTk5NSkKKysrIFdlYkNvcmUvcGx1Z2lucy9jaHJvbWl1bS9Q bHVnaW5EYXRhQ2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05NSw2ICs5NSw3IEBAIHZv aWQgUGx1Z2luRGF0YTo6aW5pdFBsdWdpbnMoKQogdm9pZCBQbHVnaW5EYXRhOjpyZWZyZXNoKCkK IHsKICAgICBwbHVnaW5DYWNoZS5yZXNldCh0cnVlKTsKKyAgICBwbHVnaW5DYWNoZS5wbHVnaW5z KCk7ICAvLyBGb3JjZSB0aGUgcGx1Z2lucyB0byBiZSByZWxvYWRlZCBub3cuCiB9CiAKIFN0cmlu ZyBnZXRQbHVnaW5NaW1lVHlwZUZyb21FeHRlbnNpb24oY29uc3QgU3RyaW5nJiBleHRlbnNpb24p Cg==