248343 2022-11-25 07:58:02 -0800 REGRESSION(256830@main): Fix WebRTC cmake build after usrsctp removal 2022-12-09 10:46:19 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=246136 InRadar P2 Normal --- 1 olivier.blin webkit-unassigned eric.carlson philn webkit-bug-importer youennf oldest_to_newest 1914687 0 olivier.blin 2022-11-25 07:58:02 -0800 In 256830@main, the usrsctp third party has been removed from WebRTC, but the cmake files have not been updated. This was ok in the first pull request: https://github.com/WebKit/WebKit/pull/5070 But it has been missed in the second one: https://github.com/WebKit/WebKit/pull/6584 1914688 1 olivier.blin 2022-11-25 07:59:33 -0800 Pull request: https://github.com/WebKit/WebKit/pull/6816 1914828 2 philn 2022-11-27 02:33:11 -0800 *** This bug has been marked as a duplicate of bug 248336 *** 1914948 3 463754 olivier.blin 2022-11-28 05:52:50 -0800 Created attachment 463754 Mac platform changes I guess the Mac platform still needs the PlatformMac.cmake change. Should I reopen the bug just to fix this one and remove the WEBRTC_HAVE_USRSCTP define? Attached is what remains from my patch. 1914950 4 philn 2022-11-28 05:56:25 -0800 Ah yes, please submit a new PR, I'm reopening this bug :) 1915715 5 olivier.blin 2022-11-30 14:14:27 -0800 Pull request: https://github.com/WebKit/WebKit/pull/6988 1917986 6 ews-feeder 2022-12-09 10:45:35 -0800 Committed 257637@main (a0968d750159): <https://commits.webkit.org/257637@main> Reviewed commits have been landed. Closing PR #6988 and removing active labels. 1917987 7 webkit-bug-importer 2022-12-09 10:46:19 -0800 <rdar://problem/103186359> 463754 2022-11-28 05:52:50 -0800 2022-11-28 05:52:50 -0800 Mac platform changes b248343.patch text/plain 4257 olivier.blin Y29tbWl0IDBiNWE1NGYxMjc2MjQ0MDZiNTQ0NTcxYjA0ODM5MWYwODc4NjQ5ZjEKQXV0aG9yOiBP bGl2aWVyIEJsaW4gPG9saXZpZXIuYmxpbkBzb2Z0YXRob21lLmNvbT4KRGF0ZTogICBGcmkgTm92 IDI1IDE2OjU4OjE4IDIwMjIgKzAxMDAKCiAgICBSRUdSRVNTSU9OKDI1NjgzMEBtYWluKTogRml4 IFdlYlJUQyBjbWFrZSBidWlsZCBhZnRlciB1c3JzY3RwIHJlbW92YWwKICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDgzNDMKICAgIAogICAgSW4gMjU2ODMwQG1h aW4sIHRoZSB1c3JzY3RwIHRoaXJkIHBhcnR5IGhhcyBiZWVuIHJlbW92ZWQgZnJvbSBXZWJSVEMs CiAgICBidXQgdGhlIGNtYWtlIGZpbGVzIGhhdmUgbm90IGJlZW4gdXBkYXRlZC4KICAgIAogICAg QWxzbyByZW1vdmUgV0VCUlRDX0hBVkVfVVNSU0NUUCBkZWZpbmUgZnJvbSBYY29kZSBwcm9qZWN0 LgogICAgCiAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KICAgIAogICAgKiBTb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ01ha2VMaXN0cy50eHQ6CiAgICAqIFNvdXJjZS9UaGlyZFBh cnR5L2xpYndlYnJ0Yy9Db25maWd1cmF0aW9ucy9saWJ3ZWJydGMueGNjb25maWc6CiAgICAqIFNv dXJjZS9XZWJDb3JlL1BsYXRmb3JtTWFjLmNtYWtlOgoKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGly ZFBhcnR5L2xpYndlYnJ0Yy9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndl YnJ0Yy9DTWFrZUxpc3RzLnR4dAppbmRleCA5ZDJjNzRkMDhjZTYuLjAyNmE4MDRhNzQ1NSAxMDA2 NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NNYWtlTGlzdHMudHh0CisrKyBi L1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9DTWFrZUxpc3RzLnR4dApAQCAtMjEzNCw3ICsy MTM0LDYgQEAgdGFyZ2V0X2NvbXBpbGVfZGVmaW5pdGlvbnMod2VicnRjIFBSSVZBVEUKICAgV0VC UlRDX0NPREVDX09QVVMKICAgV0VCUlRDX0NPREVDX1JFRAogICBXRUJSVENfSEFWRV9TQ1RQCi0g IFdFQlJUQ19IQVZFX1VTUlNDVFAKICAgV0VCUlRDX0lOQ0xVREVfSU5URVJOQUxfQVVESU9fREVW SUNFCiAgIFdFQlJUQ19JTlRFTExJR0lCSUxJVFlfRU5IQU5DRVI9MAogICBXRUJSVENfTlNfRkxP QVQKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Db25maWd1cmF0aW9u cy9saWJ3ZWJydGMueGNjb25maWcgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ29uZmln dXJhdGlvbnMvbGlid2VicnRjLnhjY29uZmlnCmluZGV4IGNlOGQwZTc3OTJmNS4uOTdiY2I0Yzhm YTY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ29uZmlndXJhdGlv bnMvbGlid2VicnRjLnhjY29uZmlnCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9D b25maWd1cmF0aW9ucy9saWJ3ZWJydGMueGNjb25maWcKQEAgLTc2LDcgKzc2LDcgQEAgSU5TVEFM TEhEUlNfU0NSSVBUX1BIQVNFID0gWUVTOwogV0FSTklOR19DRkxBR1MgPSAtV25vLWRlcHJlY2F0 ZWQtZGVjbGFyYXRpb25zICQoaW5oZXJpdGVkKTsKIAogLy8gRklYTUU6IFNldCBXRUJSVENfVVNF X0JVSUxUSU5fSVNBQ19GSVggYW5kIFdFQlJUQ19VU0VfQlVJTFRJTl9JU0FDX0ZMT0FUIGZvciBp T1MgYW5kIE1hYwotR0NDX1BSRVBST0NFU1NPUl9ERUZJTklUSU9OUyA9IEdURVNUX1JFTEFUSVZF X1BBVEggV0VCUlRDX09QVVNfU1VQUE9SVF8xMjBNU19QVElNRT0wIFdFQlJUQ19QT1NJWCBXRUJS VENfTUFDIFNTTF9VU0VfT1BFTlNTTCBGRUFUVVJFX0VOQUJMRV9TU0wgSEFWRV9TUlRQIEhBVkVf TkVUSU5FVF9JTl9IIEhBVkVfT1BFTlNTTF9TU0xfSCBTQ1RQX1BST0NFU1NfTEVWRUxfTE9DS1Mg U0NUUF9TSU1QTEVfQUxMT0NBVE9SIFNDVFBfVVNFX09QRU5TU0xfU0hBMSBfX1VzZXJzcGFjZV9f IEhBVkVfU0FfTEVOIEhBVkVfU0NPTk5fTEVOIF9fQVBQTEVfVVNFX1JGQ18yMjkyIF9fVXNlcnNw YWNlX29zX0RhcndpbiBOT05fV0lORE9XU19ERUZJTkUgSEFWRV9XRUJSVENfVklERU8gSEFWRV9X RUJSVENfVk9JQ0UgV0VCUlRDX0lOVEVMTElHSUJJTElUWV9FTkhBTkNFUj0wIFdFQlJUQ19BUE1f REVCVUdfRFVNUD0wIFdFQlJUQ19OU19GTE9BVCBXRUJSVENfVVNFX0JVSUxUSU5fT1BVUyBXRUJS VENfQ09ERUNfT1BVUyBXRUJSVENfQ09ERUNfSVNBQyBXRUJSVENfQ09ERUNfUkVEIEhBVkVfU1RE SU5UX0ggSEFWRV9TVERMSUJfSCBIQVZFX1VJTlQ2NF9UIE9QRU5TU0wgSEFWRV9DT05GSUdfSCBX RUJSVENfV0VCS0lUX0JVSUxEIEhBVkVfUFRIUkVBRF9DT05EX1RJTUVEV0FJVF9SRUxBVElWRSAg SEFWRV9TQ1RQIFdFQlJUQ19DT0RFQ19HNzExIFdFQlJUQ19DT0RFQ19HNzIyIFdFQlJUQ19PUFVT X1ZBUklBQkxFX0NPTVBMRVhJVFk9MCBXRUJSVENfVVNFX0JVSUxUSU5fSVNBQ19GSVg9MSBXRUJS VENfVVNFX0JVSUxUSU5fSVNBQ19GTE9BVD0wIFVTRV9CVUlMVElOX1NXX0NPREVDUyBXRUJSVENf V0VCS0lUX0JVSUxEIFJUQ19FTkFCTEVfVlA5IE5PX01BSU5fVEhSRUFEX1dSQVBQSU5HIFJUQ19E SVNBQkxFX1RSQUNFX0VWRU5UUyBXRUJSVENfSEFWRV9TQ1RQIFdFQlJUQ19IQVZFX1VTUlNDVFAg V0VCUlRDX0VYQ0xVREVfVFJBTlNJRU5UX1NVUFBSRVNTT1IgV0VCUlRDX0hBVkVfRENTQ1RQICQo aW5oZXJpdGVkKTsKK0dDQ19QUkVQUk9DRVNTT1JfREVGSU5JVElPTlMgPSBHVEVTVF9SRUxBVElW RV9QQVRIIFdFQlJUQ19PUFVTX1NVUFBPUlRfMTIwTVNfUFRJTUU9MCBXRUJSVENfUE9TSVggV0VC UlRDX01BQyBTU0xfVVNFX09QRU5TU0wgRkVBVFVSRV9FTkFCTEVfU1NMIEhBVkVfU1JUUCBIQVZF X05FVElORVRfSU5fSCBIQVZFX09QRU5TU0xfU1NMX0ggU0NUUF9QUk9DRVNTX0xFVkVMX0xPQ0tT IFNDVFBfU0lNUExFX0FMTE9DQVRPUiBTQ1RQX1VTRV9PUEVOU1NMX1NIQTEgX19Vc2Vyc3BhY2Vf XyBIQVZFX1NBX0xFTiBIQVZFX1NDT05OX0xFTiBfX0FQUExFX1VTRV9SRkNfMjI5MiBfX1VzZXJz cGFjZV9vc19EYXJ3aW4gTk9OX1dJTkRPV1NfREVGSU5FIEhBVkVfV0VCUlRDX1ZJREVPIEhBVkVf V0VCUlRDX1ZPSUNFIFdFQlJUQ19JTlRFTExJR0lCSUxJVFlfRU5IQU5DRVI9MCBXRUJSVENfQVBN X0RFQlVHX0RVTVA9MCBXRUJSVENfTlNfRkxPQVQgV0VCUlRDX1VTRV9CVUlMVElOX09QVVMgV0VC UlRDX0NPREVDX09QVVMgV0VCUlRDX0NPREVDX0lTQUMgV0VCUlRDX0NPREVDX1JFRCBIQVZFX1NU RElOVF9IIEhBVkVfU1RETElCX0ggSEFWRV9VSU5UNjRfVCBPUEVOU1NMIEhBVkVfQ09ORklHX0gg V0VCUlRDX1dFQktJVF9CVUlMRCBIQVZFX1BUSFJFQURfQ09ORF9USU1FRFdBSVRfUkVMQVRJVkUg IEhBVkVfU0NUUCBXRUJSVENfQ09ERUNfRzcxMSBXRUJSVENfQ09ERUNfRzcyMiBXRUJSVENfT1BV U19WQVJJQUJMRV9DT01QTEVYSVRZPTAgV0VCUlRDX1VTRV9CVUlMVElOX0lTQUNfRklYPTEgV0VC UlRDX1VTRV9CVUlMVElOX0lTQUNfRkxPQVQ9MCBVU0VfQlVJTFRJTl9TV19DT0RFQ1MgV0VCUlRD X1dFQktJVF9CVUlMRCBSVENfRU5BQkxFX1ZQOSBOT19NQUlOX1RIUkVBRF9XUkFQUElORyBSVENf RElTQUJMRV9UUkFDRV9FVkVOVFMgV0VCUlRDX0hBVkVfU0NUUCBXRUJSVENfRVhDTFVERV9UUkFO U0lFTlRfU1VQUFJFU1NPUiBXRUJSVENfSEFWRV9EQ1NDVFAgJChpbmhlcml0ZWQpOwogCiBHQ0Nf UFJFUFJPQ0VTU09SX0RFRklOSVRJT05TW3Nkaz1tYWNvc3gqXSA9ICQoaW5oZXJpdGVkKSBXRUJS VENfVVNFX1ZUQl9IQVJEV0FSRV9FTkNPREVSICQoR0NDX1BSRVBST0NFU1NPUl9ERUZJTklUSU9O U18kKFdLX0lTX0NBVEFMWVNUKSk7CiBHQ0NfUFJFUFJPQ0VTU09SX0RFRklOSVRJT05TX1lFUyA9 IFdFQlJUQ19NQUNfQ0FUQUxZU1QgV0VCUlRDX0lPUzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL1BsYXRmb3JtTWFjLmNtYWtlIGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1NYWMuY21ha2UK aW5kZXggNWM5MDMwZGVhMTIwLi5lNDNjMDdkOWExMTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL1BsYXRmb3JtTWFjLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtTWFjLmNt YWtlCkBAIC01OCw3ICs1OCw2IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfTElCUkFSSUVTCiAgICAg JHtWSURFT1RPT0xCT1hfTElCUkFSWX0KICAgICAke1hNTDJfTElCUkFSWX0KICAgICBvcHVzCi0g ICAgdXNyc2N0cAogICAgIHZweAogICAgIHdlYm0KICAgICB5dXYK