248246 2022-11-22 12:57:04 -0800 [CMake] Bump cmake_minimum_required version to 3.16 2022-11-27 12:21:49 -0800 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 248289 https://bugs.webkit.org/show_bug.cgi?id=221727 P2 Normal --- 248289 248202 1 fujii fujii aperez don.olmstead mcatanzaro oldest_to_newest 1914155 0 fujii 2022-11-22 12:57:04 -0800 [CMake] Bump cmake_minimum_required version to 3.16.3 https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy https://packages.ubuntu.com/focal/cmake See also: Bug 221727 – [CMake] Bump cmake_minimum_required version to 3.12 or later 1914158 1 463677 fujii 2022-11-22 13:12:51 -0800 Created attachment 463677 Patch 1914163 2 463677 don.olmstead 2022-11-22 13:28:19 -0800 Comment on attachment 463677 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463677&action=review > Source/JavaScriptCore/CMakeLists.txt:1 > +cmake_minimum_required(VERSION 3.16.3) The feature you want to use is in 3.16 so I think you should use that as the minimum version not what the CMake version of the GTK policy is. 1914370 3 fujii 2022-11-23 13:56:39 -0800 AppleWin EWS failed. I'm going to fix it in another bug. Bug 248289 – [CMake][MSVC] Use CMAKE_MSVC_RUNTIME_LIBRARY to select a CRT type instead of regexp replacing 1914856 4 fujii 2022-11-27 12:21:36 -0800 I wanted to split patches, but it turned out that I should land both changes as a single commit. Merged this into bug#248289. *** This bug has been marked as a duplicate of bug 248289 *** 463677 2022-11-22 13:12:51 -0800 2022-11-27 12:21:49 -0800 Patch bug-248246-20221123061249.patch text/plain 2765 fujii RnJvbSBjNWY2NDE0N2M4ZTU3N2IyZDcxMmNlZjE0NWMyNGU1YjQ5ZjEwNWE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBIaXJvbm9yaSA8SGlyb25vcmkuRnVqaWlAc29ueS5j b20+CkRhdGU6IFdlZCwgMjMgTm92IDIwMjIgMDY6MDY6MTkgKzA5MDAKU3ViamVjdDogW1BBVENI XSBbQ01ha2VdIEJ1bXAgY21ha2VfbWluaW11bV9yZXF1aXJlZCB2ZXJzaW9uIHRvIDMuMTYuMwog aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0ODI0NgoKUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCgpBcyBwZXIgV2ViS2l0J3MgZGVwZW5kZW5jaWVzIHBvbGljeSwg dGhlIG1pbmltdW0gQ01ha2UgdmVyc2lvbiBpcyBvbmUKb2YgVWJ1bnR1IDIwLjA0IChGb2NhbCBG b3NzYSkuCjxodHRwczovL3RyYWMud2Via2l0Lm9yZy93aWtpL1dlYktpdEdUSy9EZXBlbmRlbmNp ZXNQb2xpY3k+CjxodHRwczovL3BhY2thZ2VzLnVidW50dS5jb20vZm9jYWwvY21ha2U+CgoqIENN YWtlTGlzdHMudHh0OgoqIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dDoKKiBT b3VyY2UvV1RGL0NNYWtlTGlzdHMudHh0OgoqIFNvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0 OgoqIFNvdXJjZS9XZWJLaXRMZWdhY3kvQ01ha2VMaXN0cy50eHQ6Ci0tLQogU291cmNlL0phdmFT Y3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0IHwgMiArLQogU291cmNlL1dURi9DTWFrZUxpc3RzLnR4 dCAgICAgICAgICAgIHwgMiArLQogU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgICAgICAg IHwgMiArLQogU291cmNlL1dlYktpdExlZ2FjeS9DTWFrZUxpc3RzLnR4dCAgIHwgMiArLQogQ01h a2VMaXN0cy50eHQgICAgICAgICAgICAgICAgICAgICAgIHwgMiArLQogNSBmaWxlcyBjaGFuZ2Vk LCA1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtl TGlzdHMudHh0CmluZGV4IDdkYmI0OTI2NGY0OS4uZDVkNTBiODMwNzBmIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC0xLDQgKzEsNCBAQAotY21ha2VfbWluaW11bV9yZXF1 aXJlZChWRVJTSU9OIDMuMTIpCitjbWFrZV9taW5pbXVtX3JlcXVpcmVkKFZFUlNJT04gMy4xNi4z KQogCiBpbmNsdWRlKFdlYktpdENvbW1vbikKIGluY2x1ZGUodGFyZ2V0L1RhcmdldFdURikKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV1RGL0NNYWtlTGlz dHMudHh0CmluZGV4IGU4ZDFlMTEyNzY1Mi4uOTVjODAzMDY1YmJjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV1RGL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XVEYvQ01ha2VMaXN0cy50eHQKQEAg LTEsNCArMSw0IEBACi1jbWFrZV9taW5pbXVtX3JlcXVpcmVkKFZFUlNJT04gMy4xMikKK2NtYWtl X21pbmltdW1fcmVxdWlyZWQoVkVSU0lPTiAzLjE2LjMpCiBpbmNsdWRlKFdlYktpdENvbW1vbikK IHNldF9wcm9wZXJ0eShESVJFQ1RPUlkgLiBQUk9QRVJUWSBGT0xERVIgIldURiIpCiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUvQ01h a2VMaXN0cy50eHQKaW5kZXggMDJlM2I4MjdmZWRhLi42MzNkMWVmMjk1NzMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NNYWtl TGlzdHMudHh0CkBAIC0xLDQgKzEsNCBAQAotY21ha2VfbWluaW11bV9yZXF1aXJlZChWRVJTSU9O IDMuMTIpCitjbWFrZV9taW5pbXVtX3JlcXVpcmVkKFZFUlNJT04gMy4xNi4zKQogCiBpbmNsdWRl KFdlYktpdENvbW1vbikKIGluY2x1ZGUodGFyZ2V0L1RhcmdldFdURikKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXRMZWdhY3kvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L0NN YWtlTGlzdHMudHh0CmluZGV4IDJiMjM1Y2Q4YWZhNi4uNmIyYzE3N2E4MzU2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0TGVnYWN5L0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJLaXRM ZWdhY3kvQ01ha2VMaXN0cy50eHQKQEAgLTEsNCArMSw0IEBACi1jbWFrZV9taW5pbXVtX3JlcXVp cmVkKFZFUlNJT04gMy4xMikKK2NtYWtlX21pbmltdW1fcmVxdWlyZWQoVkVSU0lPTiAzLjE2LjMp CiAKIGluY2x1ZGUoV2ViS2l0Q29tbW9uKQogaW5jbHVkZSh0YXJnZXQvVGFyZ2V0V1RGKQpkaWZm IC0tZ2l0IGEvQ01ha2VMaXN0cy50eHQgYi9DTWFrZUxpc3RzLnR4dAppbmRleCA4YmI3ZDY1ZmI4 N2YuLmEwNDllMzEwOTJlMSAxMDA2NDQKLS0tIGEvQ01ha2VMaXN0cy50eHQKKysrIGIvQ01ha2VM aXN0cy50eHQKQEAgLTEwLDcgKzEwLDcgQEAKICMgaW4gc3VwcG9ydCBvZiB0aGUgQXBwbGVXaW4g aW50ZXJuYWwgYnVpbGQgc28gdGhpcyB2ZXJzaW9uIHNob3VsZCBiZSBrZXB0IGluCiAjIHN5bmMg YWNyb3NzIHRob3NlIGZpbGVzLgogIwotY21ha2VfbWluaW11bV9yZXF1aXJlZChWRVJTSU9OIDMu MTIpCitjbWFrZV9taW5pbXVtX3JlcXVpcmVkKFZFUlNJT04gMy4xNi4zKQogcHJvamVjdChXZWJL aXQpCiAKICMgUmVtb3ZlIHRoaXMgY21ha2VfcG9saWN5KCkgYWZ0ZXIgdXBncmFkaW5nIGNtYWtl X21pbmltdW1fcmVxdWlyZWQoKSB0byAzLjIwLgo=