24818 2009-03-25 15:44:10 -0700 [GTK] http auth dialog pops up twice after a cancelled atempt 2009-07-21 03:52:04 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk, Soup P2 Normal --- 1 gustavo webkit-unassigned danw plaes xan.lopez oldest_to_newest 115238 0 gustavo 2009-03-25 15:44:10 -0700 How to reproduce: I go to a site where http basic auth is required, and click cancel when the dialog appears. Then I click the location bar entry and press enter. Now two authentication dialogs appear, and I get this in the terminal: (lt-GtkLauncher:2577): libsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL' failed If I cancel both dialogs, I get this: (lt-GtkLauncher:3399): libsoup-CRITICAL **: soup_message_io_unpause: assertion `io != NULL' failed If I press OK on both dialogs, the site loads correctly. 115697 1 xan.lopez 2009-03-28 14:01:12 -0700 I guess we should we doing something in Cancel, but not sure what. CCing Dan. 115701 2 danw 2009-03-28 15:27:44 -0700 webkitsoupauthdialog.c looks like it's doing the right thing; if the user cancels, you should just unpause the message without calling soup_auth_authenticate() on it. So this might be a libsoup bug. 115702 3 danw 2009-03-28 15:39:32 -0700 or maybe not; i went to try to add a test for this case to libsoup/tests/auth-test.c, but there's already one there. so this should work. things to figure out: is something else requeueing the first message? when the two auth dialogs pop up, are they for the same SoupMessage or for different ones? If the former: what is the state of the message queue after the first message fails? If the latter: is the feature getting attached to the session twice maybe? 121638 4 30412 gustavo 2009-05-16 05:26:02 -0700 Created attachment 30412 log of soup messages up to when I click 'OK' on the first dialog It's interesting to note that sometimes two dialogs pop, sometimes three. I'll investigate your other queries, Dan. 121639 5 gustavo 2009-05-16 05:39:13 -0700 (In reply to comment #4) > Created an attachment (id=30412) [review] > log of soup messages up to when I click 'OK' on the first dialog Just to make it clear. This log contains: what happens 'till I click 'cancel', then I try loading the same uri again, and click 'OK' in one of the 2/3 dialogs. 121684 6 danw 2009-05-17 07:37:56 -0700 Did you edit that at all besides adding "first try", "second try"? The Soup-Debug lines don't seem to match up right. Eg, the response for SoupMessage 0x83eede0 shows up in the log before the request. (This *might* be a SoupLogger bug?) Another oddity is that there are two SoupSessions in the log (0x95ec970 for the first few requests, then 0x8108970 for the last one). Last I knew WebKit didn't (intentionally) create more than one SoupSession. Are multiple threads being used here? SoupSessionAsync doesn't go to any effort to be threadsafe, so it's possible that that would mess things up. (In particular, if you called certain methods from a thread other than the thread whose GMainContext the session uses, then they might do bad things because they might queue an asynchronous operation, which could end up completing in the other thread even before the calling function returns.) 122356 7 gustavo 2009-05-21 08:37:59 -0700 (In reply to comment #6) > Did you edit that at all besides adding "first try", "second try"? The > Soup-Debug lines don't seem to match up right. Eg, the response for SoupMessage > 0x83eede0 shows up in the log before the request. (This *might* be a SoupLogger > bug?) > > Another oddity is that there are two SoupSessions in the log (0x95ec970 for the > first few requests, then 0x8108970 for the last one). Last I knew WebKit didn't > (intentionally) create more than one SoupSession. I didn't edit it knowingly, but I may have failed in copying/pasting from my terminal. I'll get better logging going, but maybe I'll just write a test. > Are multiple threads being used here? SoupSessionAsync doesn't go to any effort > to be threadsafe, so it's possible that that would mess things up. (In > particular, if you called certain methods from a thread other than the thread > whose GMainContext the session uses, then they might do bad things because they > might queue an asynchronous operation, which could end up completing in the > other thread even before the calling function returns.) This may be. Have to investigate. For the time being, I have continued investigating and opened this bug report with some information I was able to gather: http://bugzilla.gnome.org/show_bug.cgi?id=583462 Let's see if I can come up with a working (as in, failing =D) test case. 122561 8 30572 xan.lopez 2009-05-21 23:53:16 -0700 Created attachment 30572 cancelauth.patch Apply fix suggested in GNOME's bugzilla bug, seems to work great! 122633 9 30572 mjs 2009-05-22 04:19:17 -0700 Comment on attachment 30572 cancelauth.patch Looks fine. I'm not sure if a regression test is possible, but if so please add one. 122715 10 xan.lopez 2009-05-22 12:07:22 -0700 (In reply to comment #9) > (From update of attachment 30572 [review]) > Looks fine. I'm not sure if a regression test is possible, but if so please add > one. > Thanks, landed in r44052. Writing a test for this using the webkit APIs is a bit of a pain actually, but since this is a temporary workaround until we use the fix in libsoup, and libsoup actually has a test for this, I think we should be fine. 133275 11 33117 plaes 2009-07-20 15:49:10 -0700 Created attachment 33117 drop-workaround.patch We can remove the workaround now, as we depend on libsoup-2.27.4 133442 12 33117 gustavo 2009-07-21 03:52:04 -0700 Comment on attachment 33117 drop-workaround.patch Landed as r46168. 30412 2009-05-16 05:26:02 -0700 2009-05-16 05:26:02 -0700 log of soup messages up to when I click 'OK' on the first dialog debug.txt text/plain 4095 gustavo Rmlyc3QgdHJ5LCBhbmQgY2FuY2VsOgoKPiBHRVQgLyBIVFRQLzEuMQo+IFNvdXAtRGVidWctVGlt ZXN0YW1wOiAxMjQyNDc2MjQ2Cj4gU291cC1EZWJ1ZzogU291cFNlc3Npb25Bc3luYyAxICgweDk1 ZWM5NzApLCBTb3VwTWVzc2FnZSAxICgweDk1YzU1OTApLCBTb3VwU29ja2V0IDEgKDB4OTVjNGY5 MCkKPiBIb3N0OiB3aWtpLmNvbGxhYm9yYS5jby51awo+IFVzZXItQWdlbnQ6IE1vemlsbGEvNS4w IChYMTE7IFU7IExpbnV4IGk2ODY7IGVuLXVzKSBBcHBsZVdlYktpdC81MjguNSsgKEtIVE1MLCBs aWtlIEdlY2tvLCBTYWZhcmkvNTI4LjUrKSBsdC1HdGtMYXVuY2hlcgo+IEFjY2VwdDogYXBwbGlj YXRpb24veG1sLGFwcGxpY2F0aW9uL3hodG1sK3htbCx0ZXh0L2h0bWw7cT0wLjksdGV4dC9wbGFp bjtxPTAuOCxpbWFnZS9wbmcsKi8qO3E9MC41CiAgCjwgSFRUUC8xLjEgNDAxIEF1dGhvcml6YXRp b24gUmVxdWlyZWQKPCBTb3VwLURlYnVnLVRpbWVzdGFtcDogMTI0MjQ3NjI0OQo8IFNvdXAtRGVi dWc6IFNvdXBNZXNzYWdlIDEgKDB4OTVjNTU5MCkKPCBEYXRlOiBTYXQsIDE2IE1heSAyMDA5IDEy OjE4OjAxIEdNVAo8IFNlcnZlcjogQXBhY2hlLzIuMi45IChEZWJpYW4pIFBIUC81LjIuNi0xK2xl bm55MyB3aXRoIFN1aG9zaW4tUGF0Y2ggbW9kX3B5dGhvbi8zLjMuMSBQeXRob24vMi41LjIgbW9k X3NzbC8yLjIuOSBPcGVuU1NMLzAuOS44ZyBtb2RfcGVybC8yLjAuNCBQZXJsL3Y1LjEwLjAKPCBX V1ctQXV0aGVudGljYXRlOiBCYXNpYyByZWFsbT0iQ29sbGFib3JhIFdpa2kiCjwgVmFyeTogQWNj ZXB0LUVuY29kaW5nCjwgQ29udGVudC1MZW5ndGg6IDYxMgo8IENvbnRlbnQtVHlwZTogdGV4dC9o dG1sOyBjaGFyc2V0PWlzby04ODU5LTEKPCAKPCA8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lF VEYvL0RURCBIVE1MIDIuMC8vRU4iPgo8IDxodG1sPjxoZWFkPgo8IDx0aXRsZT40MDEgQXV0aG9y aXphdGlvbiBSZXF1aXJlZDwvdGl0bGU+CjwgPC9oZWFkPjxib2R5Pgo8IDxoMT5BdXRob3JpemF0 aW9uIFJlcXVpcmVkPC9oMT4KPCA8cD5UaGlzIHNlcnZlciBjb3VsZCBub3QgdmVyaWZ5IHRoYXQg eW91CjwgYXJlIGF1dGhvcml6ZWQgdG8gYWNjZXNzIHRoZSBkb2N1bWVudAo8IHJlcXVlc3RlZC4g IEVpdGhlciB5b3Ugc3VwcGxpZWQgdGhlIHdyb25nCjwgY3JlZGVudGlhbHMgKGUuZy4sIGJhZCBw YXNzd29yZCksIG9yIHlvdXIKPCBicm93c2VyIGRvZXNuJ3QgdW5kZXJzdGFuZCBob3cgdG8gc3Vw cGx5CjwgdGhlIGNyZWRlbnRpYWxzIHJlcXVpcmVkLjwvcD4KPCA8aHI+CjwgPGFkZHJlc3M+QXBh Y2hlLzIuMi45IChEZWJpYW4pIFBIUC81LjIuNi0xK2xlbm55MyB3aXRoIFN1aG9zaW4tUGF0Y2gg bW9kX3B5dGhvbi8zLjMuMSBQeXRob24vMi41LjIgbW9kX3NzbC8yLjIuOSBPcGVuU1NMLzAuOS44 ZyBtb2RfcGVybC8yLjAuNCBQZXJsL3Y1LjEwLjAgU2VydmVyIGF0IHdpa2kuY29sbGFib3JhLmNv LnVrIFBvcnQgNDQzPC9hZGRyZXNzPgo8IDwvYm9keT48L2h0bWw+CgoKU2Vjb25kIHRyeToKCihs dC1HdGtMYXVuY2hlcjozNTcyKTogbGlic291cC1DUklUSUNBTCAqKjogc291cF9tZXNzYWdlX2lv X3BhdXNlOiBhc3NlcnRpb24gYGlvICE9IE5VTEwnIGZhaWxlZAo+IEdFVCAvIEhUVFAvMS4xCj4g U291cC1EZWJ1Zy1UaW1lc3RhbXA6IDEyNDI0NzYyNjUKPiBTb3VwLURlYnVnOiBTb3VwU2Vzc2lv bkFzeW5jIDEgKDB4OTVlYzk3MCksIFNvdXBNZXNzYWdlIDIgKDB4OThkMjllMCksIFNvdXBTb2Nr ZXQgMSAoMHg5NWM0ZjkwKQo+IEhvc3Q6IHdpa2kuY29sbGFib3JhLmNvLnVrCj4gVXNlci1BZ2Vu dDogTW96aWxsYS81LjAgKFgxMTsgVTsgTGludXggaTY4NjsgZW4tdXMpIEFwcGxlV2ViS2l0LzUy OC41KyAoS0hUTUwsIGxpa2UgR2Vja28sIFNhZmFyaS81MjguNSspIGx0LUd0a0xhdW5jaGVyCj4g QWNjZXB0OiBhcHBsaWNhdGlvbi94bWwsYXBwbGljYXRpb24veGh0bWwreG1sLHRleHQvaHRtbDtx PTAuOSx0ZXh0L3BsYWluO3E9MC44LGltYWdlL3BuZywqLyo7cT0wLjUKIAoobHQtR3RrTGF1bmNo ZXI6MzU3Mik6IGxpYnNvdXAtQ1JJVElDQUwgKio6IHNvdXBfbWVzc2FnZV9pb19wYXVzZTogYXNz ZXJ0aW9uIGBpbyAhPSBOVUxMJyBmYWlsZWQKPiBHRVQgLyBIVFRQLzEuMQo+IFNvdXAtRGVidWct VGltZXN0YW1wOiAxMjQyNDc2MjY1Cj4gU291cC1EZWJ1ZzogU291cFNlc3Npb25Bc3luYyAxICgw eDk1ZWM5NzApLCBTb3VwTWVzc2FnZSAyICgweDk4ZDI5ZTApLCBTb3VwU29ja2V0IDIgKDB4OTY0 NWUzMCksIHJlc3RhcnRlZAo+IEhvc3Q6IHdpa2kuY29sbGFib3JhLmNvLnVrCj4gVXNlci1BZ2Vu dDogTW96aWxsYS81LjAgKFgxMTsgVTsgTGludXggaTY4NjsgZW4tdXMpIEFwcGxlV2ViS2l0LzUy OC41KyAoS0hUTUwsIGxpa2UgR2Vja28sIFNhZmFyaS81MjguNSspIGx0LUd0a0xhdW5jaGVyCj4g QWNjZXB0OiBhcHBsaWNhdGlvbi94bWwsYXBwbGljYXRpb24veGh0bWwreG1sLHRleHQvaHRtbDtx PTAuOSx0ZXh0L3BsYWluO3E9MC44LGltYWdlL3BuZywqLyo7cT0wLjUKCjwgSFRUUC8xLjEgNDAx IEF1dGhvcml6YXRpb24gUmVxdWlyZWQKPCBTb3VwLURlYnVnLVRpbWVzdGFtcDogMTI0MjQ3NjM5 Ngo8IFNvdXAtRGVidWc6IFNvdXBNZXNzYWdlIDIgKDB4ODNlZWRlMCkKPCBEYXRlOiBTYXQsIDE2 IE1heSAyMDA5IDEyOjIwOjI1IEdNVAo8IFNlcnZlcjogQXBhY2hlLzIuMi45IChEZWJpYW4pIFBI UC81LjIuNi0xK2xlbm55MyB3aXRoIFN1aG9zaW4tUGF0Y2ggbW9kX3B5dGhvbi8zLjMuMSBQeXRo b24vMi41LjIgbW9kX3NzbC8yLjIuOSBPcGVuU1NMLzAuOS44ZyBtb2RfcGVybC8yLjAuNCBQZXJs L3Y1LjEwLjAKPCBXV1ctQXV0aGVudGljYXRlOiBCYXNpYyByZWFsbT0iQ29sbGFib3JhIFdpa2ki CjwgVmFyeTogQWNjZXB0LUVuY29kaW5nCjwgQ29udGVudC1MZW5ndGg6IDYxMgo8IENvbnRlbnQt VHlwZTogdGV4dC9odG1sOyBjaGFyc2V0PWlzby04ODU5LTEKPAo8IDwhRE9DVFlQRSBIVE1MIFBV QkxJQyAiLS8vSUVURi8vRFREIEhUTUwgMi4wLy9FTiI+CjwgPGh0bWw+PGhlYWQ+CjwgPHRpdGxl PjQwMSBBdXRob3JpemF0aW9uIFJlcXVpcmVkPC90aXRsZT4KPCA8L2hlYWQ+PGJvZHk+CjwgPGgx PkF1dGhvcml6YXRpb24gUmVxdWlyZWQ8L2gxPgo8IDxwPlRoaXMgc2VydmVyIGNvdWxkIG5vdCB2 ZXJpZnkgdGhhdCB5b3UKPCBhcmUgYXV0aG9yaXplZCB0byBhY2Nlc3MgdGhlIGRvY3VtZW50Cjwg cmVxdWVzdGVkLiAgRWl0aGVyIHlvdSBzdXBwbGllZCB0aGUgd3JvbmcKPCBjcmVkZW50aWFscyAo ZS5nLiwgYmFkIHBhc3N3b3JkKSwgb3IgeW91cgo8IGJyb3dzZXIgZG9lc24ndCB1bmRlcnN0YW5k IGhvdyB0byBzdXBwbHkKPCB0aGUgY3JlZGVudGlhbHMgcmVxdWlyZWQuPC9wPgo8IDxocj4KPCA8 YWRkcmVzcz5BcGFjaGUvMi4yLjkgKERlYmlhbikgUEhQLzUuMi42LTErbGVubnkzIHdpdGggU3Vo b3Npbi1QYXRjaCBtb2RfcHl0aG9uLzMuMy4xIFB5dGhvbi8yLjUuMiBtb2Rfc3NsLzIuMi45IE9w ZW5TU0wvMC45LjhnIG1vZF9wZXJsLzIuMC40IFBlcmwvdjUuMTAuMCBTZXJ2ZXIgYXQgd2lraS5j b2xsYWJvcmEuY28udWsgUG9ydCA0NDM8L2FkZHJlc3M+CjwgPC9ib2R5PjwvaHRtbD4KCj4gR0VU IC8gSFRUUC8xLjEKPiBTb3VwLURlYnVnLVRpbWVzdGFtcDogMTI0MjQ3NjM5Ngo+IFNvdXAtRGVi dWc6IFNvdXBTZXNzaW9uQXN5bmMgMSAoMHg4MTA4OTcwKSwgU291cE1lc3NhZ2UgMiAoMHg4M2Vl ZGUwKSwgU291cFNvY2tldCAxICgweDgwZTBmOTApLCByZXN0YXJ0ZWQKPiBIb3N0OiB3aWtpLmNv bGxhYm9yYS5jby51awo+IFVzZXItQWdlbnQ6IE1vemlsbGEvNS4wIChYMTE7IFU7IExpbnV4IGk2 ODY7IGVuLXVzKSBBcHBsZVdlYktpdC81MjguNSsgKEtIVE1MLCBsaWtlIEdlY2tvLCBTYWZhcmkv NTI4LjUrKSBsdC1HdGtMYXVuY2hlcgo+IEFjY2VwdDogYXBwbGljYXRpb24veG1sLGFwcGxpY2F0 aW9uL3hodG1sK3htbCx0ZXh0L2h0bWw7cT0wLjksdGV4dC9wbGFpbjtxPTAuOCxpbWFnZS9wbmcs Ki8qO3E9MC41Cj4gQXV0aG9yaXphdGlvbjogQmFzaWMgW2xhbGE6KioqKioqXQoK 30572 2009-05-21 23:53:16 -0700 2009-05-22 04:19:17 -0700 cancelauth.patch cancelauth.patch text/plain 2482 xan.lopez RnJvbSBiNTAwYjJiMzk3ZWFhNTNmYzRjNDEzZTA0NWJkOThiNjI1YjQyZWE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBG cmksIDIyIE1heSAyMDA5IDA5OjUxOjQ5ICswMzAwClN1YmplY3Q6IFtQQVRDSF0gMjAwOS0wNS0y MSAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjQ4MTgKICAgICAgICBbR1RLXSBodHRwIGF1dGggZGlhbG9nIHBvcHMgdXAgdHdpY2Ug YWZ0ZXIgYSBjYW5jZWxsZWQgYXRlbXB0CgogICAgICAgIFdvcmthcm91bmQgbGlic291cCBidWcK ICAgICAgICBodHRwOi8vYnVnemlsbGEuZ25vbWUub3JnL3Nob3dfYnVnLmNnaT9pZD01ODM0NjIs IHdoaWNoIG1hZGUKICAgICAgICBsaWJzb3VwIGVtaXQgdGhlICdhdXRoZW50aWNhdGUnIHNpZ25h bCBtb3JlIG9mdGVuIHRoYW4gaXQgd2FzCiAgICAgICAgZXhwZWN0ZWQuCgogICAgICAgIFdlJ2xs IGJlIGFibGUgdG8gcmVtb3ZlIHRoaXMgd2hlbiB3ZSBkZXBlbmQgb24gbGlic291cCA+IDIuMjYu Mi4KCiAgICAgICAgKiB3ZWJraXQvd2Via2l0c291cGF1dGhkaWFsb2cuYzoKICAgICAgICAoc2Vz c2lvbl9hdXRoZW50aWNhdGUpOgotLS0KIFdlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgfCAgIDE3ICsrKysrKysrKysrKysrKysrCiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJr aXRzb3VwYXV0aGRpYWxvZy5jIHwgICAgNyArKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDI0IGlu c2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9DaGFu Z2VMb2cgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCBjOWViZTg1Li4xMzYwZDEwIDEwMDY0 NAotLS0gYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpA QCAtMSwzICsxLDIwIEBACisyMDA5LTA1LTIxICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ4MTgKKyAgICAgICAgW0dUS10g aHR0cCBhdXRoIGRpYWxvZyBwb3BzIHVwIHR3aWNlIGFmdGVyIGEgY2FuY2VsbGVkIGF0ZW1wdAor CisgICAgICAgIFdvcmthcm91bmQgbGlic291cCBidWcKKyAgICAgICAgaHR0cDovL2J1Z3ppbGxh Lmdub21lLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTgzNDYyLCB3aGljaCBtYWRlCisgICAgICAgIGxp YnNvdXAgZW1pdCB0aGUgJ2F1dGhlbnRpY2F0ZScgc2lnbmFsIG1vcmUgb2Z0ZW4gdGhhbiBpdCB3 YXMKKyAgICAgICAgZXhwZWN0ZWQuCisKKyAgICAgICAgV2UnbGwgYmUgYWJsZSB0byByZW1vdmUg dGhpcyB3aGVuIHdlIGRlcGVuZCBvbiBsaWJzb3VwID4gMi4yNi4yLgorCisgICAgICAgICogd2Vi a2l0L3dlYmtpdHNvdXBhdXRoZGlhbG9nLmM6CisgICAgICAgIChzZXNzaW9uX2F1dGhlbnRpY2F0 ZSk6CisKIDIwMDktMDUtMjEgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBGaXggYnVpbGQgYnVzdGFnZS4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0 L3dlYmtpdHNvdXBhdXRoZGlhbG9nLmMgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRzb3VwYXV0 aGRpYWxvZy5jCmluZGV4IDMzNWY1MzYuLmQ3MDQzYjggMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdHNvdXBhdXRoZGlhbG9nLmMKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Vi a2l0c291cGF1dGhkaWFsb2cuYwpAQCAtMzE1LDYgKzMxNSwxMyBAQCBzdGF0aWMgdm9pZCBzZXNz aW9uX2F1dGhlbnRpY2F0ZShTb3VwU2Vzc2lvbiogc2Vzc2lvbiwgU291cE1lc3NhZ2UqIG1zZywg U291cEF1dAogICAgIFdlYktpdEF1dGhEYXRhKiBhdXRoRGF0YTsKICAgICBTb3VwU2Vzc2lvbkZl YXR1cmUqIG1hbmFnZXIgPSAoU291cFNlc3Npb25GZWF0dXJlKil1c2VyX2RhdGE7CiAKKyAgICAv KiAKKyAgICAgKiBXb3JrYXJvdW5kIGZvciBodHRwOi8vYnVnemlsbGEuZ25vbWUub3JnL3Nob3df YnVnLmNnaT9pZD01ODM0NjIKKyAgICAgKiBGSVhNRTogd2UgY2FuIHJlbW92ZSB0aGlzIG9uY2Ug d2UgZGVwZW5kIG9uIGEgbGlic291cCBuZXdlciB0aGFuIDIuMjYuMgorICAgICAqLworICAgIGlm IChtc2ctPnN0YXR1c19jb2RlID09IDApCisgICAgICAgIHJldHVybjsKKwogICAgIHNvdXBfc2Vz c2lvbl9wYXVzZV9tZXNzYWdlKHNlc3Npb24sIG1zZyk7CiAgICAgLyogV2UgbmVlZCB0byBtYWtl IHN1cmUgdGhlIG1lc3NhZ2Ugc3RpY2tzIGFyb3VuZCB3aGVuIHBhdXNpbmcgaXQgKi8KICAgICBn X29iamVjdF9yZWYobXNnKTsKLS0gCjEuNi4yLjIKCg== 33117 2009-07-20 15:49:10 -0700 2009-07-21 03:52:04 -0700 drop-workaround.patch webkit-bug-24818-drop-workaround.patch text/plain 2128 plaes RnJvbSBkN2NiOWFlZTlhYjdhY2QyNzkxMTg1NTE5ZTNjYzhiOTZhMjE4YWRlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmlpdCBMYWVzIDxwbGFlc0BwbGFlcy5vcmc+CkRhdGU6IFR1 ZSwgMjEgSnVsIDIwMDkgMDE6Mzk6MzMgKzAzMDAKU3ViamVjdDogW1BBVENIXSAyMDA5LTA3LTIx ICBQcmlpdCBMYWVzICA8cGxhZXNAcGxhZXMub3JnPgoKCVJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgoKCVtHVEtdIGh0dHAgYXV0aCBkaWFsb2cgcG9wcyB1cCB0d2ljZSBhZnRlciBhIGNhbmNl bGxlZCBhdGVtcHQKCWh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDgx OAoKCVJlbW92ZSB3b3JrYXJvdW5kIHJlcXVpcmVkIGZvciBsaWJzb3VwIHZlcnNpb25zIDw9Mi4y Ni4yIGFzIHdlIGRlcGVuZAoJb24gMi4yNy40IG5vdy4KCgkqIHdlYmtpdC93ZWJraXRzb3VwYXV0 aGRpYWxvZy5jOgoJKHNlc3Npb25fYXV0aGVudGljYXRlKToKClNpZ25lZC1vZmYtYnk6IFByaWl0 IExhZXMgPHBsYWVzQHBsYWVzLm9yZz4KLS0tCiBXZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAg ICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJr aXRzb3VwYXV0aGRpYWxvZy5jIHwgICAgNyAtLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGlu c2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9DaGFu Z2VMb2cgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCA2MjI1ODVmLi5kM2EyZGFkIDEwMDY0 NAotLS0gYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDA5LTA3LTIxICBQcmlpdCBMYWVzICA8cGxhZXNAcGxhZXMub3Jn PgorCisJUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKwlbR1RLXSBodHRwIGF1dGggZGlh bG9nIHBvcHMgdXAgdHdpY2UgYWZ0ZXIgYSBjYW5jZWxsZWQgYXRlbXB0CisJaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0ODE4CisKKwlSZW1vdmUgd29ya2Fyb3VuZCBy ZXF1aXJlZCBmb3IgbGlic291cCB2ZXJzaW9ucyA8PTIuMjYuMiBhcyB3ZSBkZXBlbmQKKwlvbiAy LjI3LjQgbm93LgorCisJKiB3ZWJraXQvd2Via2l0c291cGF1dGhkaWFsb2cuYzoKKwkoc2Vzc2lv bl9hdXRoZW50aWNhdGUpOgorCiAyMDA5LTA3LTIwICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxn dXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEhv bGdlciBGcmV5dGhlci4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHNvdXBh dXRoZGlhbG9nLmMgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRzb3VwYXV0aGRpYWxvZy5jCmlu ZGV4IGQ3MDQzYjguLjMzNWY1MzYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtp dHNvdXBhdXRoZGlhbG9nLmMKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0c291cGF1dGhk aWFsb2cuYwpAQCAtMzE1LDEzICszMTUsNiBAQCBzdGF0aWMgdm9pZCBzZXNzaW9uX2F1dGhlbnRp Y2F0ZShTb3VwU2Vzc2lvbiogc2Vzc2lvbiwgU291cE1lc3NhZ2UqIG1zZywgU291cEF1dAogICAg IFdlYktpdEF1dGhEYXRhKiBhdXRoRGF0YTsKICAgICBTb3VwU2Vzc2lvbkZlYXR1cmUqIG1hbmFn ZXIgPSAoU291cFNlc3Npb25GZWF0dXJlKil1c2VyX2RhdGE7CiAKLSAgICAvKiAKLSAgICAgKiBX b3JrYXJvdW5kIGZvciBodHRwOi8vYnVnemlsbGEuZ25vbWUub3JnL3Nob3dfYnVnLmNnaT9pZD01 ODM0NjIKLSAgICAgKiBGSVhNRTogd2UgY2FuIHJlbW92ZSB0aGlzIG9uY2Ugd2UgZGVwZW5kIG9u IGEgbGlic291cCBuZXdlciB0aGFuIDIuMjYuMgotICAgICAqLwotICAgIGlmIChtc2ctPnN0YXR1 c19jb2RlID09IDApCi0gICAgICAgIHJldHVybjsKLQogICAgIHNvdXBfc2Vzc2lvbl9wYXVzZV9t ZXNzYWdlKHNlc3Npb24sIG1zZyk7CiAgICAgLyogV2UgbmVlZCB0byBtYWtlIHN1cmUgdGhlIG1l c3NhZ2Ugc3RpY2tzIGFyb3VuZCB3aGVuIHBhdXNpbmcgaXQgKi8KICAgICBnX29iamVjdF9yZWYo bXNnKTsKLS0gCjEuNi4zLjMKCg==