24816 2009-03-25 14:32:02 -0700 Wean KURLGoogle off the deprecated GoogleURL UTF16Char type 2013-09-12 22:40:56 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 37641 1 mark mark abarth andersca brettw dglazkov oldest_to_newest 115224 0 mark 2009-03-25 14:32:02 -0700 UTF16Char is going away. http://code.google.com/p/google-url/source/detail?r=100 115225 1 28947 mark 2009-03-25 14:34:19 -0700 Created attachment 28947 Do it Brett's really the one who should look at this, but Dimitri's a real reviewer, so you two can duke it out. 115288 2 brettw 2009-03-25 20:31:16 -0700 looks good to me 115289 3 28947 eric 2009-03-25 21:00:24 -0700 Comment on attachment 28947 Do it Me too. Although why char16 over UChar or unsigned short or whatever other char types we use in WebCore? I've never seen char16 used in WebCore before... Maybe I've just not paid attention. 115290 4 mark 2009-03-25 21:19:02 -0700 char16 is because we need to access these templates in GoogleURL, and that's how it (now) refers to them. GoogleURL gets its char16/string16 support from its restricted version of the Chromium base. KURLGoogle is the "glue" between WebKit and GoogleURL, it shouldn't leak/expose char16 or string16 to the rest of WebKit, and it doesn't. From WebKit's perspective, it's just platform-specific stuff. 115296 5 fishd 2009-03-25 22:33:43 -0700 Mark: but the appearance of char16 in WebCore/platform/KURLGooglePrivate.h suggests that there is some considerable leakage. it seems unfortunate to require the presence of a base/string16.h header when building WebKit when we don't actually need string16... we just need something exactly equivalent to UChar. 115297 6 fishd 2009-03-25 22:36:47 -0700 Mark: instead of trying to teach GoogleURL to know about a global char16 type, I think it would be better to let it keep its own UTF16Char type, but then define it in a compatible with char16 and UChar fashion, like what is done at the bottom of this file: http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebKit/chromium/public/WebCommon.h?view=markup 115301 7 28947 eric 2009-03-25 23:00:06 -0700 Comment on attachment 28947 Do it Based on Darin's comments, I'll remove my review, and let you and Darin sort this one out. :) 928656 8 andersca 2013-09-12 22:40:56 -0700 KURLGoogle is gone. 28947 2009-03-25 14:34:19 -0700 2010-06-11 10:52:32 -0700 Do it webkit.24816.1.patch text/plain 3496 mark SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTk4MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDMtMjUgIE1hcmsgTWVudG92YWkgIDxtYXJrQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX ZWFuIEtVUkxHb29nbGUgb2ZmIHRoZSBkZXByZWNhdGVkIEdvb2dsZVVSTCBVVEYxNkNoYXIgdHlw ZS4KKworICAgICAgICAqIHBsYXRmb3JtL0tVUkxHb29nbGUuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6S1VSTENoYXJzZXRDb252ZXJ0ZXI6OkNvbnZlcnRGcm9tVVRGMTYpOgorICAgICAgICAoV2Vi Q29yZTo6Q2hhcmFjdGVyc09yRW1wdHkpOgorICAgICAgICAoV2ViQ29yZTo6S1VSTDo6c2V0UG9y dCk6CisgICAgICAgIChXZWJDb3JlOjpkZWNvZGVVUkxFc2NhcGVTZXF1ZW5jZXMpOgorICAgICAg ICAqIHBsYXRmb3JtL0tVUkxHb29nbGVQcml2YXRlLmg6CisKIDIwMDktMDMtMjQgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2 ZSBIeWF0dApJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9LVVJMR29vZ2xlLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL0tVUkxHb29nbGUuY3BwCShyZXZpc2lvbiA0MTk4MCkKKysr IFdlYkNvcmUvcGxhdGZvcm0vS1VSTEdvb2dsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYxLDcg KzYxLDcgQEAgcHVibGljOgogICAgIHsKICAgICB9CiAKLSAgICB2aXJ0dWFsIHZvaWQgQ29udmVy dEZyb21VVEYxNihjb25zdCB1cmxfcGFyc2U6OlVURjE2Q2hhciogaW5wdXQsIGludCBpbnB1dExl bmd0aCwKKyAgICB2aXJ0dWFsIHZvaWQgQ29udmVydEZyb21VVEYxNihjb25zdCBjaGFyMTYqIGlu cHV0LCBpbnQgaW5wdXRMZW5ndGgsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dXJsX2Nhbm9uOjpDYW5vbk91dHB1dCogb3V0cHV0KQogICAgIHsKICAgICAgICAgQ1N0cmluZyBl bmNvZGVkID0gbV9lbmNvZGluZy0+ZW5jb2RlKGlucHV0LCBpbnB1dExlbmd0aCwgVVJMRW5jb2Rl ZEVudGl0aWVzRm9yVW5lbmNvZGFibGVzKTsKQEAgLTg5LDExICs4OSwxMSBAQCBzdGF0aWMgaW5s aW5lIHZvaWQgYXNzZXJ0UHJvdG9jb2xJc0dvb2QoCiAvLyBSZXR1cm5zIHRoZSBjaGFyYWN0ZXJz IGZvciB0aGUgZ2l2ZW4gc3RyaW5nLCBvciBhIHBvaW50ZXIgdG8gYSBzdGF0aWMgZW1wdHkKIC8v IHN0cmluZyBpZiB0aGUgaW5wdXQgc3RyaW5nIGlzIE5VTEwuIFRoaXMgd2lsbCBhbHdheXMgZW5z dXJlIHdlIGhhdmUgYSBub24tCiAvLyBOVUxMIGNoYXJhY3RlciBwb2ludGVyIHNpbmNlIFJlcGxh Y2VDb21wb25lbnRzIGhhcyBzcGVjaWFsIG1lYW5pbmcgZm9yIE5VTEwuCi1zdGF0aWMgaW5saW5l IGNvbnN0IHVybF9wYXJzZTo6VVRGMTZDaGFyKiBDaGFyYWN0ZXJzT3JFbXB0eShjb25zdCBTdHJp bmcmIHN0cikKK3N0YXRpYyBpbmxpbmUgY29uc3QgY2hhcjE2KiBDaGFyYWN0ZXJzT3JFbXB0eShj b25zdCBTdHJpbmcmIHN0cikKIHsKLSAgICBzdGF0aWMgY29uc3QgdXJsX3BhcnNlOjpVVEYxNkNo YXIgemVybyA9IDA7CisgICAgc3RhdGljIGNvbnN0IGNoYXIxNiB6ZXJvID0gMDsKICAgICByZXR1 cm4gc3RyLmNoYXJhY3RlcnMoKSA/Ci0gICAgICAgICAgIHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3Qg dXJsX3BhcnNlOjpVVEYxNkNoYXIqPihzdHIuY2hhcmFjdGVycygpKSA6CisgICAgICAgICAgIHJl aW50ZXJwcmV0X2Nhc3Q8Y29uc3QgY2hhcjE2Kj4oc3RyLmNoYXJhY3RlcnMoKSkgOgogICAgICAg ICAgICAmemVybzsKIH0KIApAQCAtNTc5LDcgKzU3OSw3IEBAIHZvaWQgS1VSTDo6c2V0UG9ydCh1 bnNpZ25lZCBzaG9ydCBpKQogICAgIGlmIChpKSB7CiAgICAgICAgIHBvcnRTdHIgPSBTdHJpbmc6 Om51bWJlcihzdGF0aWNfY2FzdDxpbnQ+KGkpKTsKICAgICAgICAgcmVwbGFjZW1lbnRzLlNldFBv cnQoCi0gICAgICAgICAgICByZWludGVycHJldF9jYXN0PGNvbnN0IHVybF9wYXJzZTo6VVRGMTZD aGFyKj4ocG9ydFN0ci5jaGFyYWN0ZXJzKCkpLAorICAgICAgICAgICAgcmVpbnRlcnByZXRfY2Fz dDxjb25zdCBjaGFyMTYqPihwb3J0U3RyLmNoYXJhY3RlcnMoKSksCiAgICAgICAgICAgICB1cmxf cGFyc2U6OkNvbXBvbmVudCgwLCBwb3J0U3RyLmxlbmd0aCgpKSk7CiAKICAgICB9IGVsc2UgewpA QCAtNzY0LDcgKzc2NCw3IEBAIFN0cmluZyBkZWNvZGVVUkxFc2NhcGVTZXF1ZW5jZXMoY29uc3Qg U3QKIAogICAgIC8vIENvbnZlcnQgdGhhdCA4LWJpdCB0byBVVEYtMTYuIEl0J3Mgbm90IGNsZWFy IElFIGRvZXMgdGhpcyBhdCBhbGwgdG8KICAgICAvLyBKYXZhU2NyaXB0IFVSTHMsIGJ1dCBGaXJl Zm94IGFuZCBTYWZhcmkgZG8uCi0gICAgdXJsX2Nhbm9uOjpSYXdDYW5vbk91dHB1dFQ8dXJsX3Bh cnNlOjpVVEYxNkNoYXI+IHV0ZjE2OworICAgIHVybF9jYW5vbjo6UmF3Q2Fub25PdXRwdXRUPGNo YXIxNj4gdXRmMTY7CiAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCB1bmVzY2FwZWQubGVuZ3RoKCk7 IGkrKykgewogICAgICAgICB1bnNpZ25lZCBjaGFyIHVjaCA9IHN0YXRpY19jYXN0PHVuc2lnbmVk IGNoYXI+KHVuZXNjYXBlZC5hdChpKSk7CiAgICAgICAgIGlmICh1Y2ggPCAweDgwKSB7CkluZGV4 OiBXZWJDb3JlL3BsYXRmb3JtL0tVUkxHb29nbGVQcml2YXRlLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbGF0Zm9ybS9LVVJMR29vZ2xlUHJpdmF0ZS5oCShyZXZpc2lvbiA0MTk4MCkKKysrIFdl YkNvcmUvcGxhdGZvcm0vS1VSTEdvb2dsZVByaXZhdGUuaAkod29ya2luZyBjb3B5KQpAQCAtNzIs NyArNzIsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAgLy8gUmVwbGFjZXMgdGhl IGdpdmVuIGNvbXBvbmVudHMsIG1vZGlmeWluZyB0aGUgY3VycmVudCBVUkwuIFRoZSBjdXJyZW50 CiAgICAgICAgIC8vIFVSTCBtdXN0IGJlIHZhbGlkLgotICAgICAgICB0eXBlZGVmIHVybF9jYW5v bjo6UmVwbGFjZW1lbnRzPHVybF9wYXJzZTo6VVRGMTZDaGFyPiBSZXBsYWNlbWVudHM7CisgICAg ICAgIHR5cGVkZWYgdXJsX2Nhbm9uOjpSZXBsYWNlbWVudHM8Y2hhcjE2PiBSZXBsYWNlbWVudHM7 CiAgICAgICAgIHZvaWQgcmVwbGFjZUNvbXBvbmVudHMoY29uc3QgUmVwbGFjZW1lbnRzJik7CiAK ICAgICAgICAgLy8gU2V0dGVycyBmb3IgdGhlIGRhdGEuIFVzaW5nIHRoZSBBU0NJSSB2ZXJzaW9u IHdoZW4geW91IGtub3cgdGhlCg==