<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>248152</bug_id>
          
          <creation_ts>2022-11-20 11:37:38 -0800</creation_ts>
          <short_desc>[web-animations] keyframes should be recomputed when a parent element changes value for a non-inherited property set to &quot;inherit&quot;</short_desc>
          <delta_ts>2023-01-31 14:06:11 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Animations</component>
          <version>Safari Technology Preview</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>BrowserCompat, InRadar, WPTImpact</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>251433</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Antoine Quint">graouts</reporter>
          <assigned_to name="Antoine Quint">graouts</assigned_to>
          <cc>dino</cc>
    
    <cc>graouts</cc>
    
    <cc>karlcow</cc>
    
    <cc>koivisto</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1913752</commentid>
    <comment_count>0</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2022-11-20 11:37:38 -0800</bug_when>
    <thetext>We are failing a number of WPT tests where a keyframes uses an &quot;inherit&quot; value for a given property and that property changes on a parent dynamically. For instance, in web-animations/responsive/perspective.html:

test(function() {
    container.style.perspective = &apos;none&apos;;
    var player = element.animate([{perspective: &apos;inherit&apos;}, {perspective: &apos;20px&apos;}], 4000);
    player.pause();

    player.currentTime = 1000;
    assert_equals(getComputedStyle(element).perspective, &apos;none&apos;);

    container.style.perspective = &apos;100px&apos;;
    assert_equals(getComputedStyle(element).perspective, &apos;80px&apos;);

    container.style.perspective = &apos;none&apos;;
    assert_equals(getComputedStyle(element).perspective, &apos;none&apos;);
}, &apos;perspective responsive to inherited changes&apos;);

This makes us fail a number of similar WPT tests under web-animations/responsive/.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1913754</commentid>
    <comment_count>1</comment_count>
      <attachid>463630</attachid>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2022-11-20 11:45:34 -0800</bug_when>
    <thetext>Created attachment 463630
Test

Adding a standalone test using a CSS animation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1913755</commentid>
    <comment_count>2</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2022-11-20 11:47:05 -0800</bug_when>
    <thetext>Currently this seems to only work in Chrome (Canary anyway).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1914848</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-11-27 11:38:16 -0800</bug_when>
    <thetext>&lt;rdar://problem/102694235&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1929748</commentid>
    <comment_count>4</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2023-01-31 06:11:35 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/9381</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1929867</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-01-31 14:06:08 -0800</bug_when>
    <thetext>Committed 259645@main (25ead8e66edd): &lt;https://commits.webkit.org/259645@main&gt;

Reviewed commits have been landed. Closing PR #9381 and removing active labels.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>463630</attachid>
            <date>2022-11-20 11:45:34 -0800</date>
            <delta_ts>2022-11-20 11:45:34 -0800</delta_ts>
            <desc>Test</desc>
            <filename>bug-248152-keyframe-update-inherit.html</filename>
            <type>text/html</type>
            <size>694</size>
            <attacher name="Antoine Quint">graouts</attacher>
            
              <data encoding="base64">PHN0eWxlPgoKQGtleWZyYW1lcyBpbmhlcml0LWFuaW0gewogICAgZnJvbSB7IGxlZnQ6IGluaGVy
aXQgfQogICAgdG8gICB7IGxlZnQ6IDEwMHB4IH0KfQoKI3BhcmVudCB7CiAgICBsZWZ0OiAwcHg7
Cn0KCiNjaGlsZCB7CiAgICBhbmltYXRpb246IGluaGVyaXQtYW5pbSAxcyBsaW5lYXI7Cn0KCjwv
c3R5bGU+CjxkaXYgaWQ9InBhcmVudCI+CiAgICA8ZGl2IGlkPSJjaGlsZCI+PC9kaXY+CjwvZGl2
Pgo8c2NyaXB0PgoKY29uc3QgcGFyZW50ID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcigiI3BhcmVu
dCIpOwpjb25zdCBjaGlsZCA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoIiNjaGlsZCIpOwoKY29u
c3QgYW5pbWF0aW9uID0gY2hpbGQuZ2V0QW5pbWF0aW9ucygpWzBdOwphbmltYXRpb24uY3VycmVu
dFRpbWUgPSA1MDA7CmFuaW1hdGlvbi5wYXVzZSgpOwoKY29uc29sZS5sb2coYEFuaW1hdGVkIGxl
ZnQgc3R5bGUgd2l0aCBpbml0aWFsIGxlZnQgdmFsdWU6ICR7Z2V0Q29tcHV0ZWRTdHlsZShjaGls
ZCkubGVmdH0gKGV4cGVjdGVkIDUwcHgpYCk7CgpwYXJlbnQuc3R5bGUubGVmdCA9ICI1MHB4IjsK
Y29uc29sZS5sb2coYEFuaW1hdGVkIGxlZnQgc3R5bGUgd2l0aCBpbml0aWFsIGxlZnQgdmFsdWU6
ICR7Z2V0Q29tcHV0ZWRTdHlsZShjaGlsZCkubGVmdH0gKGV4cGVjdGVkIDc1cHgpYCk7CiAgICAK
PC9zY3JpcHQ+Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>