248144 2022-11-20 07:44:27 -0800 [GTK4] PlatformKeyboardEvent::currentStateOfModifierKeys is not implemented 2023-07-11 10:18:06 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED DUPLICATE 258965 https://bugs.webkit.org/show_bug.cgi?id=248143 P2 Normal --- 210100 1 mcatanzaro webkit-unassigned alicem bugs-noreply mcatanzaro oldest_to_newest 1913731 0 mcatanzaro 2022-11-20 07:44:27 -0800 PlatformKeyboardEvent::getCurrentModifierState (which is renamed to PlatformKeyboardEvent::currentStateOfModifierKeys in https://github.com/WebKit/WebKit/pull/6672) has hardcoded shift/ctrl/alt/meta all to 0. In GTK 3 the code did gtk_get_current_event_state(), but that's not possible in GTK 4. I also notice that PlatformKeyboardEvent::modifiersContainCapsLock hardcodes caps lock to 0. At least shift and caps lock both actually work when typing in this Bugzilla. 1914413 1 alicem 2022-11-23 19:14:28 -0800 The real question is why it does that instead of having modifiers as part of the event already. Like that code was never correct to begin with. 1929389 2 mcatanzaro 2023-01-30 07:23:33 -0800 (In reply to Alexander Mikhaylenko from comment #1) > The real question is why it does that instead of having modifiers as part of > the event already. Like that code was never correct to begin with. The name of the function, PlatformKeyboardEvent::currentStateOfModifierKeys, is kinda unambiguous, though. It's asking for the *current* state of the modifier keys, not the state of modifier keys corresponding to any particular event. And it is a static function, not a method that operates on a particular event. Looks like it's used only by DragController.cpp and EventHandler.cpp (plus some platform-specific places that don't affect GTK). In DragController it's used to synthesize mouse events, which looks pretty reasonable. In EventHandler.cpp it's again used to synthesize mouse events in EventHandler::fakeMouseMoveEventTimerFired. So this code looks decent enough. Only problem is we need to implement it. I wonder if that's even possible with GTK 4. 1966227 3 mcatanzaro 2023-07-11 10:18:06 -0700 *** This bug has been marked as a duplicate of bug 258965 ***