248042 2022-11-17 09:02:02 -0800 Background Queue monitor to remove outdated hashes of PR from queue and update timeline 2022-11-24 09:02:16 -0800 1 1 1 Unclassified WebKit Tools / Tests Safari Technology Preview Unspecified Unspecified NEW InRadar P2 Normal --- 248037 1 ahmad.saleem792 webkit-unassigned jbedard webkit-bug-importer oldest_to_newest 1913197 0 ahmad.saleem792 2022-11-17 09:02:02 -0800 Hi Team, Another improvement to EWS (at least to user from psychology point of view - might be zero tangible benefit), it would be to run another background script on all queue PRs for build requests and check every 10 minutes or 20 minutes (can be tweaked) to ensure that if any PR has build request but now it is update or outdated build hash then remove it from the queue. This will help for those EWS system (e.g., mac-wk1 etc.), which take time or slow because with background script running and removing outdated hashes from queue, it will not show 18 hours queue to contributors and demotivate them. With showing just six hours queue since now it has clean all outdated hashes from build pipeline, it would be good and smarter approach IMO. Again - I am just suggesting but the pros and cons from inside knowledge can be validated by Tools team from Apple. Thanks! 1913220 1 jbedard 2022-11-17 10:08:15 -0800 If we were going to do this, we should do it on hook reception instead of polling. That being said, it's less of a benefit than you might think because the very first thing every queue does before running a job is check if the PR and commit it's running on are stale. 1913223 2 ahmad.saleem792 2022-11-17 10:14:01 -0800 (In reply to Jonathan Bedard from comment #1) > If we were going to do this, we should do it on hook reception instead of > polling. > > That being said, it's less of a benefit than you might think because the > very first thing every queue does before running a job is check if the PR > and commit it's running on are stale. Indeed! Hence I said in first line (psychology point of view - might be zero tangible benefit).. 😆 1914504 3 webkit-bug-importer 2022-11-24 09:02:16 -0800 <rdar://problem/102649650>