248012 2022-11-16 19:08:42 -0800 Update commit message template to request an explanation of why a PR fixes the bug 2022-11-18 08:30:43 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer abifox fujii jbedard webkit-bug-importer zalan oldest_to_newest 1913039 0 ddkilzer 2022-11-16 19:08:42 -0800 Update commit message template to request a brief explanation of why a PR fixes the bug. It's always easiest to explain what a patch does, but when reviewing a patch or looking at a previously committed patch, the most useful information that a commit message could contain is why (or how) the changes in the patch actually fix the bug. Most folks already do this, so this just formalizes a placeholder for it. 1913040 1 webkit-bug-importer 2022-11-16 19:09:22 -0800 <rdar://problem/102447501> 1913042 2 ddkilzer 2022-11-16 19:16:31 -0800 Pull request: https://github.com/apple/WebKit/pull/214 1913045 3 ddkilzer 2022-11-16 19:28:24 -0800 Pull request: https://github.com/WebKit/WebKit/pull/6579 1913346 4 fujii 2022-11-17 17:42:34 -0800 We have one more template there. https://github.com/WebKit/WebKit/blob/main/.github/pull_request_template.md 1913360 5 ddkilzer 2022-11-17 19:51:16 -0800 (In reply to Fujii Hironori from comment #4) > We have one more template there. > https://github.com/WebKit/WebKit/blob/main/.github/pull_request_template.md Thanks! Updated the PR. 1913460 6 ews-feeder 2022-11-18 08:30:41 -0800 Committed 256835@main (0e7830380b81): <https://commits.webkit.org/256835@main> Reviewed commits have been landed. Closing PR #6579 and removing active labels.