24794 2009-03-24 17:49:54 -0700 Can enter auto scroll from a non-scrollable area 2009-08-12 19:46:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED InRadar P2 Normal --- 1 jhoneycutt jberlin beidson bweinstein oldest_to_newest 115093 0 jhoneycutt 2009-03-24 17:49:54 -0700 From discussion in bug #24722, it is possible to enter auto scroll when the area isn't scrollable. To reproduce, 1. Load http://google.com 2. Size the page until there are no scroll bars 3. Middle-click the page The auto scroll icon and cursor show, but the page is not scrollable. 123579 1 aroben 2009-05-29 11:45:19 -0700 <rdar://problem/6933057> 127559 2 31701 jberlin 2009-06-22 20:33:25 -0700 Created attachment 31701 Cancels the scroll if there are no vertical or horizonal scrollbars. 127703 3 31744 jberlin 2009-06-23 15:23:53 -0700 Created attachment 31744 Does not instantiate an autoscroll when there are no scrollbars on the frame view. Assumes that there is no situation in which a frame does not have a frameview but the user should still be able to do an auto / pan scroll. 127705 4 31744 beidson 2009-06-23 15:26:22 -0700 Comment on attachment 31744 Does not instantiate an autoscroll when there are no scrollbars on the frame view. Code change looks fine, but can we layout test this bad boy? 127706 5 31744 beidson 2009-06-23 15:27:09 -0700 Comment on attachment 31744 Does not instantiate an autoscroll when there are no scrollbars on the frame view. Re-read precisely what this is about, I guess we can't quite test this yet. r+ 127812 6 eric 2009-06-23 22:31:43 -0700 Is this patch supposed to be obsoleted? Or should it be landed? 127904 7 jberlin 2009-06-24 06:46:32 -0700 (In reply to comment #6) > Is this patch supposed to be obsoleted? Or should it be landed? > Obsoleted. I did not take into account the case where there is a scrollable element inside of a frame view even then though frame view might not have scrollbars. 128067 8 31744 eric 2009-06-24 18:50:06 -0700 Comment on attachment 31744 Does not instantiate an autoscroll when there are no scrollbars on the frame view. Clearing review flag on obsoleted patch. 139706 9 bweinstein 2009-08-12 19:46:16 -0700 This bug was fixed as collateral damage with the fix of http://trac.webkit.org/changeset/47163. 31701 2009-06-22 20:33:25 -0700 2009-06-23 14:52:58 -0700 Cancels the scroll if there are no vertical or horizonal scrollbars. preventAutoScrollInNonScrollArea.txt text/plain 2160 jberlin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NDk3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDYtMjIgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXg6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDc5NCAoPHJkYXI6 Ly9wcm9ibGVtLzY5MzMwNTc+KSwKKyAgICAgICAgd2hlcmUgaXQgd2FzIHBvc3NpYmxlIHRvIGVu dGVyIGF1dG8gc2Nyb2xsIHdoZW4gdGhlIGFyZWEgaXNuJ3Qgc2Nyb2xsYWJsZS4KKworICAgICAg ICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxl cjo6aGFuZGxlQXV0b3Njcm9sbCk6CisKIDIwMDktMDYtMjIgIFNhbSBXZWluaWcgIDxzYW1Ad2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KSW5kZXg6 IFdlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFn ZS9FdmVudEhhbmRsZXIuY3BwCShyZXZpc2lvbiA0NDk1MCkKKysrIFdlYkNvcmUvcGFnZS9FdmVu dEhhbmRsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MDQsMjIgKzYwNCwzMSBAQCB2b2lkIEV2 ZW50SGFuZGxlcjo6aGFuZGxlQXV0b3Njcm9sbChSZW5kCiAgICAgICAgIHJldHVybjsgICAgIAog CiAgICAgc2V0QXV0b3Njcm9sbFJlbmRlcmVyKHJlbmRlcmVyKTsKLQorICAgIGJvb2wgc2Nyb2xs Q2FuY2VsZWQgPSBmYWxzZTsKICNpZiBFTkFCTEUoUEFOX1NDUk9MTElORykKICAgICBpZiAobV9w YW5TY3JvbGxJblByb2dyZXNzKSB7CiAgICAgICAgIG1fcGFuU2Nyb2xsU3RhcnRQb3MgPSBjdXJy ZW50TW91c2VQb3NpdGlvbigpOwotICAgICAgICBpZiAoRnJhbWVWaWV3KiB2aWV3ID0gbV9mcmFt ZS0+dmlldygpKQotICAgICAgICAgICAgdmlldy0+YWRkUGFuU2Nyb2xsSWNvbihtX3BhblNjcm9s bFN0YXJ0UG9zKTsKKyAgICAgICAgaWYgKEZyYW1lVmlldyogdmlldyA9IG1fZnJhbWUtPnZpZXco KSkgeworICAgICAgICAgICAgLy8gQ2hlY2sgdG8gbWFrZSBzdXJlIHRoZXJlIGlzIHNvbWV0aGlu ZyB0byBzY3JvbGwuIAorICAgICAgICAgICAgaWYgKHZpZXctPnZlcnRpY2FsU2Nyb2xsYmFyKCkg fHwgdmlldy0+aG9yaXpvbnRhbFNjcm9sbGJhcigpKQorICAgICAgICAgICAgICAgIHZpZXctPmFk ZFBhblNjcm9sbEljb24obV9wYW5TY3JvbGxTdGFydFBvcyk7CisgICAgICAgICAgICBlbHNlIHsK KyAgICAgICAgICAgICAgICBtX3BhblNjcm9sbEluUHJvZ3Jlc3MgPSBmYWxzZTsKKyAgICAgICAg ICAgICAgICBzY3JvbGxDYW5jZWxlZCA9IHRydWU7CisgICAgICAgICAgICB9CisgICAgICAgIH0g IAorCiAgICAgICAgIC8vIElmIHdlJ3JlIG5vdCBpbiB0aGUgdG9wIGZyYW1lIHdlIG5vdGlmeSBp dCB0aGF0IHdlIGRvaW5nIGEgcGFuU2Nyb2xsLgogICAgICAgICBpZiAoUGFnZSogcGFnZSA9IG1f ZnJhbWUtPnBhZ2UoKSkgewogICAgICAgICAgICAgRnJhbWUqIG1haW5GcmFtZSA9IHBhZ2UtPm1h aW5GcmFtZSgpOwogICAgICAgICAgICAgaWYgKG1fZnJhbWUgIT0gbWFpbkZyYW1lKQotICAgICAg ICAgICAgICAgIG1haW5GcmFtZS0+ZXZlbnRIYW5kbGVyKCktPnNldFBhblNjcm9sbEluUHJvZ3Jl c3ModHJ1ZSk7CisgICAgICAgICAgICAgICAgbWFpbkZyYW1lLT5ldmVudEhhbmRsZXIoKS0+c2V0 UGFuU2Nyb2xsSW5Qcm9ncmVzcyghc2Nyb2xsQ2FuY2VsZWQpOwogICAgICAgICB9CiAgICAgfQog I2VuZGlmCiAKLSAgICBzdGFydEF1dG9zY3JvbGxUaW1lcigpOworICAgIGlmICghc2Nyb2xsQ2Fu Y2VsZWQpCisgICAgICAgIHN0YXJ0QXV0b3Njcm9sbFRpbWVyKCk7CiB9CiAKIHZvaWQgRXZlbnRI YW5kbGVyOjphdXRvc2Nyb2xsVGltZXJGaXJlZChUaW1lcjxFdmVudEhhbmRsZXI+KikK 31744 2009-06-23 15:23:53 -0700 2009-06-24 18:50:06 -0700 Does not instantiate an autoscroll when there are no scrollbars on the frame view. preventAutoScrollInNonScrollArea.txt text/plain 1514 jberlin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTAwNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDYtMjMgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXg6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDc5NCAoPHJkYXI6 Ly9wcm9ibGVtLzY5MzMwNTc+CisgICAgICAgIFdoZXJlIGl0IHdhcyBwb3NzaWJsZSB0byBlbnRl ciBhdXRvIHNjcm9sbCB3aGVuIHRoZSBhcmVhIGlzbid0IHNjcm9sbGFibGUuCisKKyAgICAgICAg KiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6 OmhhbmRsZU1vdXNlUHJlc3NFdmVudCk6CisKIDIwMDktMDYtMjMgIFNpbW9uIEZyYXNlciAgPHNp bW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dC4K SW5kZXg6IFdlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCShyZXZpc2lvbiA0NDk5MCkKKysrIFdlYkNvcmUvcGFn ZS9FdmVudEhhbmRsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTMxLDEwICsxMTMxLDE1IEBA IGJvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVNb3VzZVByZXNzRXZlbnQKICAgICAgICAgfQogCiAg ICAgICAgIGlmIChyZW5kZXJlcikgewotICAgICAgICAgICAgbV9wYW5TY3JvbGxJblByb2dyZXNz ID0gdHJ1ZTsKLSAgICAgICAgICAgIGhhbmRsZUF1dG9zY3JvbGwocmVuZGVyZXIpOwotICAgICAg ICAgICAgaW52YWxpZGF0ZUNsaWNrKCk7Ci0gICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAg ICAgICAgIGlmIChGcmFtZVZpZXcqIHZpZXcgPSBtX2ZyYW1lLT52aWV3KCkpIHsKKyAgICAgICAg ICAgICAgICAvLyBDaGVjayB0byBtYWtlIHN1cmUgdGhlcmUgaXMgc29tZXRoaW5nIHRvIHNjcm9s bC4KKyAgICAgICAgICAgICAgICBpZiAodmlldy0+dmVydGljYWxTY3JvbGxiYXIoKSB8fCB2aWV3 LT5ob3Jpem9udGFsU2Nyb2xsYmFyKCkpIHsKKyAgICAgICAgICAgICAgICAgICAgbV9wYW5TY3Jv bGxJblByb2dyZXNzID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICAgICAgaGFuZGxlQXV0b3Njcm9s bChyZW5kZXJlcik7CisgICAgICAgICAgICAgICAgICAgIGludmFsaWRhdGVDbGljaygpOworICAg ICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAg ICAgICB9CiAgICAgICAgIH0KICAgIH0KICNlbmRpZgo=