247913 2022-11-14 13:23:31 -0800 Percent-width blocks cannot form a re-layout boundary 2025-04-03 16:55:27 -0700 1 1 1 Unclassified WebKit Layout and Rendering Safari Technology Preview Unspecified Unspecified REOPENED https://jsfiddle.net/y07soapn/show InRadar P2 Normal --- 248967 1 ahmad.saleem792 ahmad.saleem792 bfulgham commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1912412 0 ahmad.saleem792 2022-11-14 13:23:31 -0800 Hi Team, While going through Blink Commits, I came across another, which we should merge since this fixes another failing test: Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/da179e152dff0ab3e3dabc72299bd4fb586881c9 Webkit GitHub - https://github.com/WebKit/WebKit/blob/7ed06b348948ce6b702c93bcd2be63960cf56952/Source/WebCore/rendering/RenderObject.cpp#LL534 Failing Test (passes in Chrome Canary 110 & Firefox Nightly 108) - https://jsfiddle.net/8d47mtvL/show Just wanted to create a bug to track for future purposes. Note - Both Safari 16.1 and Safari Tech Preview 157 fail this. Thanks! 1913828 1 ews-feeder 2022-11-21 02:22:12 -0800 Committed 256901@main (b42824bb6c99): <https://commits.webkit.org/256901@main> Reviewed commits have been landed. Closing PR #6677 and removing active labels. 1913830 2 webkit-bug-importer 2022-11-21 02:23:15 -0800 <rdar://problem/102577429> 1917657 3 commit-queue 2022-12-08 11:53:53 -0800 Re-opened since this is blocked by bug 248967 1946183 4 ahmad.saleem792 2023-04-03 05:47:01 -0700 @Alan - I noticed that I didn't did 'const' part in this merge for object().style(). Could this help in the performance issue in page loading? I can do PR but is it possible to run it via some A/B testing internally to see whether 'const' part does not regress performance? const auto* style = object->style(); 1946200 5 ahmad.saleem792 2023-04-03 07:36:25 -0700 (In reply to Ahmad Saleem from comment #4) > @Alan - I noticed that I didn't did 'const' part in this merge for > object().style(). Could this help in the performance issue in page loading? > > I can do PR but is it possible to run it via some A/B testing internally to > see whether 'const' part does not regress performance? > > const auto* style = object->style(); This compiles: const auto& style = object->style(); if (!style.width().isFixed() || !style.height().isFixed()) return false; 1946204 6 zalan 2023-04-03 07:59:07 -0700 (In reply to Ahmad Saleem from comment #4) > @Alan - I noticed that I didn't did 'const' part in this merge for > object().style(). Could this help in the performance issue in page loading? > > I can do PR but is it possible to run it via some A/B testing internally to > see whether 'const' part does not regress performance? > > const auto* style = object->style(); I am not sure if that's what the PLT regression is about. I think the expensive part of this change is where we can't (incorrectly) do boundary layout anymore on certain type of content (which means spending more time in layout). We probably need to find a different way of addressing this correctness issue. 2100138 7 ahmad.saleem792 2025-03-03 19:16:13 -0800 Pull request: https://github.com/WebKit/WebKit/pull/41828 2100487 8 ews-feeder 2025-03-04 19:09:34 -0800 Committed 291607@main (8fafd9511671): <https://commits.webkit.org/291607@main> Reviewed commits have been landed. Closing PR #41828 and removing active labels. 2108688 9 ahmad.saleem792 2025-04-03 16:55:27 -0700 Reverted once again - https://commits.webkit.org/293192@main (Although I have more information now that it only happens on specific machine and specific test case).