<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>247900</bug_id>
          
          <creation_ts>2022-11-14 08:11:28 -0800</creation_ts>
          <short_desc>Add support for skip-ews GitHub label</short_desc>
          <delta_ts>2023-01-26 11:26:28 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=250859</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Jonathan Bedard">jbedard</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ap</cc>
    
    <cc>jbedard</cc>
    
    <cc>mark.lam</cc>
    
    <cc>ryanhaddad</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1912316</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2022-11-14 08:11:28 -0800</bug_when>
    <thetext>Add support for Skip-EWS GitHub label. This label can be applied to a PR to skip EWS runs. There might be various scenarios in which people might want to apply such a label.

Foe e.g:
- Some engineers might want to abort EWS as soon as the they know that the change is going to be bad (e.g: an important ews on their patch failed, and they don&apos;t want to keep running on all other ewses).
- Someone just re-uploaded the change after doing a trivial change (add reviewer name, fix typo in PR title etc.)
- Admins wants to stop a bad PR (which might be breaking EWS bots) from further processing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1912318</commentid>
    <comment_count>1</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2022-11-14 08:14:05 -0800</bug_when>
    <thetext>Note that, in bugzilla world, there are three ways to do similar thing:
1) r- the patch
2) mark the patch as obsolete from bugzilla UI
3) --no-ews while uploading the patch

In GitHub world, we don&apos;t have any way to do this.

Equivalent of r- in GitHub is marking the PR as Request changes, which still triggers the EWS. There is no way to mark a commit as obsolete in GitHub UI without uploading a new commit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1912321</commentid>
    <comment_count>2</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2022-11-14 08:19:44 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/6476</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1913002</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-11-16 17:26:13 -0800</bug_when>
    <thetext>Committed 256760@main (57ba798e7aa4): &lt;https://commits.webkit.org/256760@main&gt;

Reviewed commits have been landed. Closing PR #6476 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1913003</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-11-16 17:27:17 -0800</bug_when>
    <thetext>&lt;rdar://problem/102444473&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1913332</commentid>
    <comment_count>5</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2022-11-17 16:25:11 -0800</bug_when>
    <thetext>Re-opening for pull request https://github.com/apple/WebKit/pull/216</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1913463</commentid>
    <comment_count>6</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-11-18 08:37:23 -0800</bug_when>
    <thetext>Committed 252432.837@safari-7614-branch (8dbf19696f48): &lt;https://commits.webkit.org/252432.837@safari-7614-branch&gt;

Reviewed commits have been landed. Closing PR #216 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>