24790 2009-03-24 17:09:16 -0700 [GTK] webkitsoupauthdialog.h lacks WEBKIT_API before function 2009-03-28 14:18:54 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 cosimoc webkit-unassigned gustavo xan.lopez oldest_to_newest 115084 0 cosimoc 2009-03-24 17:09:16 -0700 SSIA; this causes e.g. gir-repository not to find webkit_soup_auth_dialog_get_type() in the libwebkit-1.0.so file, breaking the build. 115085 1 28918 cosimoc 2009-03-24 17:10:09 -0700 Created attachment 28918 proposed fix 115116 2 zecke 2009-03-25 00:25:00 -0700 SSIA? Could you provide a log of the build breakage? 115121 3 cosimoc 2009-03-25 03:19:34 -0700 Subject Says It All :) It's not the WebKit build itself that breaks; the issue is that the gobject-introspection scanner won't find the function while parsing the .h files, as it's defined with the wrong visibility (AFAICS that's what WEBKIT_API does). If you really need it, I can provide you with the failed build log for gir-repository, but I would need to recompile WebKit without this patch and I can't do it right now. 115132 4 zecke 2009-03-25 04:19:52 -0700 You assume I know what SSIA and gir are... now I know it is related to gobject introspection but more input would be welcome... this dialog is private... it shouldn't exist/be visible... so how does this "error" come into existence? 115138 5 cosimoc 2009-03-25 06:53:33 -0700 gir-repository is a scanner which grabs all the public API inside the installed *.h files from a library and generates a .typelib file containing all the introspection information to be used by the gobject-introspection system. This error arises when you have a function which is declared as public inside the .h file (webkitauthsoupdialog.h in this case) but doesn't have the right visibility setting inside the shared object. We can solve this in two ways - adding the right visibility to the function (which is what this patch does) - removing the header from the installed webkit API files which, if the dialog is really private and not meant to be created by some third party client other than WebKit itself, seems a better solution to me. In this case, I guess all we have to do is to remove the header from the relevant section inside GNUMakefile.am I hope this somewhat clarifies the issue, sorry for not having been clearer in the first place. 115298 6 zecke 2009-03-25 22:38:53 -0700 Thanks for the clarification. Now the question is how to proceed. We have bug #24598 which wants to make the dialog type public as well. I think for gir the best way would be to make the a noinst header. 115698 7 gustavo 2009-03-28 14:05:02 -0700 (In reply to comment #6) > Thanks for the clarification. Now the question is how to proceed. We have bug > #24598 which wants to make the dialog type public as well. I think for gir the > best way would be to make the a noinst header. > I think the feature needs to be public, for people customizing the session to be able to add/remove it, at least. 115699 8 xan.lopez 2009-03-28 14:17:16 -0700 As Gustavo says we really want to have this exported, the whole idea behind making it a session was that people could configure/remove it from outside of WebKit. I've committed the patch as r42075, closing as FIXED. 115700 9 xan.lopez 2009-03-28 14:18:54 -0700 Er, I meant "the whole idea behind making it a session FEATURE". 28918 2009-03-24 17:10:09 -0700 2009-03-28 14:17:43 -0700 proposed fix soupdialogapi.patch text/plain 649 cosimoc ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHNvdXBhdXRoZGlhbG9nLmggYi9X ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRzb3VwYXV0aGRpYWxvZy5oCmluZGV4IDJjMDMwYjQuLjBi YjZiNGQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHNvdXBhdXRoZGlhbG9n LmgKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0c291cGF1dGhkaWFsb2cuaApAQCAtMTcs NiArMTcsOCBAQAogICogQm9zdG9uLCBNQSAwMjExMC0xMzAxLCBVU0EuCiAgKi8KIAorI2luY2x1 ZGUgPHdlYmtpdC93ZWJraXRkZWZpbmVzLmg+CisKICNpbmNsdWRlIDxndGsvZ3RrLmg+CiAjaW5j bHVkZSA8bGlic291cC9zb3VwLmg+CiAKQEAgLTQyLDcgKzQ0LDggQEAgdHlwZWRlZiBzdHJ1Y3Qg ewogICAgIEd0a1dpZGdldCogKCpjdXJyZW50X3RvcGxldmVsKSAoV2ViS2l0U291cEF1dGhEaWFs b2cqIGZlYXR1cmUsIFNvdXBNZXNzYWdlKiBtZXNzYWdlKTsKIH0gV2ViS2l0U291cEF1dGhEaWFs b2dDbGFzczsKIAotR1R5cGUgd2Via2l0X3NvdXBfYXV0aF9kaWFsb2dfZ2V0X3R5cGUgKHZvaWQp OworV0VCS0lUX0FQSSBHVHlwZQord2Via2l0X3NvdXBfYXV0aF9kaWFsb2dfZ2V0X3R5cGUgKHZv aWQpOwogCiBHX0VORF9ERUNMUwogCg==