247875 2022-11-13 20:44:17 -0800 REGRESSION(255715@main) [WinCairo] TestWebCore.WebCoreBundleTest.BundlePathFromNameTypeDirectory is failing 2022-11-14 01:52:17 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii don.olmstead ross.kirsling webkit-bug-importer oldest_to_newest 1912168 0 fujii 2022-11-13 20:44:17 -0800 REGRESSION(255715@main) [WinCairo] TestWebCore.WebCoreBundleTest.BundlePathFromNameTypeDirectory is failing > TestWebCore.WebCoreBundleTest.BundlePathFromNameTypeDirectory > > C:\home\webkit\gc\Tools\TestWebKitAPI\Tests\WebCore\win\WebCoreBundle.cpp:70 > Expected equality of these values: > expected.utf8().data() > Which is: "C:\\home\\webkit\\gc\\WebKitBuild\\Debug\\bin64\\WebKit.resources\\en.lproj\\mediaControlsLocalizedStrings.js" > actual.utf8().data() > Which is: "" 1912169 1 463512 fujii 2022-11-13 20:57:04 -0800 Created attachment 463512 Patch 1912201 2 463512 ross.kirsling 2022-11-14 00:09:07 -0800 Comment on attachment 463512 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463512&action=review r=me with a comment, given that the GTK failure seems to be an existing flaky test. > Tools/TestWebKitAPI/Tests/WebCore/win/WebCoreBundle.cpp:70 > + actual = WebCore::webKitBundlePath("Localizable"_s, "strings"_s, ""_s); > + expected = FileSystem::pathByAppendingComponents(m_root, { "en.lproj"_s, "Localizable.strings"_s }); > + EXPECT_STREQ(expected.utf8().data(), actual.utf8().data()); These lines don't need #if ENABLE(MODERN_MEDIA_CONTROLS)? 1912211 3 463512 fujii 2022-11-14 00:54:07 -0800 Comment on attachment 463512 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463512&action=review >> Tools/TestWebKitAPI/Tests/WebCore/win/WebCoreBundle.cpp:70 >> + EXPECT_STREQ(expected.utf8().data(), actual.utf8().data()); > > These lines don't need #if ENABLE(MODERN_MEDIA_CONTROLS)? No, it doesn't. Localizable.strings is used by both conditions. 1912232 4 ews-feeder 2022-11-14 01:51:21 -0800 Committed 256644@main (341038cce116): <https://commits.webkit.org/256644@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463512. 1912233 5 webkit-bug-importer 2022-11-14 01:52:17 -0800 <rdar://problem/102311470> 463512 2022-11-13 20:57:04 -0800 2022-11-14 01:51:21 -0800 Patch bug-247875-20221114135702.patch text/plain 2120 fujii RnJvbSAwOWJmYWE5OWY0ZDhjOWNlMjI4Mjk1MTZhNzNiNjEwZDllMmE5Yzc3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBIaXJvbm9yaSA8SGlyb25vcmkuRnVqaWlAc29ueS5j b20+CkRhdGU6IE1vbiwgMTQgTm92IDIwMjIgMTM6NDU6MDkgKzA5MDAKU3ViamVjdDogW1BBVENI XSBSRUdSRVNTSU9OKDI1NTcxNUBtYWluKSBbV2luQ2Fpcm9dCiBUZXN0V2ViQ29yZS5XZWJDb3Jl QnVuZGxlVGVzdC5CdW5kbGVQYXRoRnJvbU5hbWVUeXBlRGlyZWN0b3J5IGlzIGZhaWxpbmcKIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDc4NzUKClJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgoKQWZ0ZXIgMjU1NzE1QG1haW4gY2hhbmdlZCBXaW5DYWlybyB0byBl bmFibGVkIHRoZSBtb2Rlcm4gbWVkaWEKY29udHJvbHMsIHRoZSB0ZXN0IHdhcyBmYWlsaW5nIGJl Y2F1c2UKbWVkaWFDb250cm9sc0xvY2FsaXplZFN0cmluZ3MuanMgd2FzIG1pc3NpbmcuCgoqIFRv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS93aW4vV2ViQ29yZUJ1bmRsZS5jcHA6CihX ZWJDb3JlQnVuZGxlVGVzdC5CdW5kbGVQYXRoRnJvbU5hbWVUeXBlRGlyZWN0b3J5KToKVGVzdCB0 aGUgcGF0aCBvZiAibWVkaWFDb250cm9sc0xvY2FsaXplZFN0cmluZ3MuanMiCm9ubHkgaWYgIUVO QUJMRShNT0RFUk5fTUVESUFfQ09OVFJPTFMpLgpBZGRlZCBhIHRlc3Qgb2YgIkxvY2FsaXphYmxl LnN0cmluZ3MiIGZpbGUuCi0tLQogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL3dp bi9XZWJDb3JlQnVuZGxlLmNwcCB8IDYgKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRp b25zKCspCgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL3dp bi9XZWJDb3JlQnVuZGxlLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS93 aW4vV2ViQ29yZUJ1bmRsZS5jcHAKaW5kZXggNzBjYjA5MGEzYjJkLi4wODFhZTc2MGY3ZTYgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS93aW4vV2ViQ29yZUJ1 bmRsZS5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL3dpbi9XZWJD b3JlQnVuZGxlLmNwcApAQCAtNjUsOSArNjUsMTUgQEAgVEVTVF9GKFdlYkNvcmVCdW5kbGVUZXN0 LCBCdW5kbGVQYXRoRnJvbU5hbWVUeXBlRGlyZWN0b3J5KQogICAgIGF1dG8gZXhwZWN0ZWQgPSBG aWxlU3lzdGVtOjpwYXRoQnlBcHBlbmRpbmdDb21wb25lbnRzKG1fcm9vdCwgeyAiV2ViSW5zcGVj dG9yVUkiX3MsICJQcm90b2NvbCJfcywgIkluc3BlY3RvckJhY2tlbmRDb21tYW5kcy5qcyJfcyB9 KTsKICAgICBFWFBFQ1RfU1RSRVEoZXhwZWN0ZWQudXRmOCgpLmRhdGEoKSwgYWN0dWFsLnV0Zjgo KS5kYXRhKCkpOwogCisgICAgYWN0dWFsID0gV2ViQ29yZTo6d2ViS2l0QnVuZGxlUGF0aCgiTG9j YWxpemFibGUiX3MsICJzdHJpbmdzIl9zLCAiIl9zKTsKKyAgICBleHBlY3RlZCA9IEZpbGVTeXN0 ZW06OnBhdGhCeUFwcGVuZGluZ0NvbXBvbmVudHMobV9yb290LCB7ICJlbi5scHJvaiJfcywgIkxv Y2FsaXphYmxlLnN0cmluZ3MiX3MgfSk7CisgICAgRVhQRUNUX1NUUkVRKGV4cGVjdGVkLnV0Zjgo KS5kYXRhKCksIGFjdHVhbC51dGY4KCkuZGF0YSgpKTsKKworI2lmICFFTkFCTEUoTU9ERVJOX01F RElBX0NPTlRST0xTKQogICAgIGFjdHVhbCA9IFdlYkNvcmU6OndlYktpdEJ1bmRsZVBhdGgoIm1l ZGlhQ29udHJvbHNMb2NhbGl6ZWRTdHJpbmdzIl9zLCAianMiX3MsICIiX3MpOwogICAgIGV4cGVj dGVkID0gRmlsZVN5c3RlbTo6cGF0aEJ5QXBwZW5kaW5nQ29tcG9uZW50cyhtX3Jvb3QsIHsgImVu Lmxwcm9qIl9zLCAibWVkaWFDb250cm9sc0xvY2FsaXplZFN0cmluZ3MuanMiX3MgfSk7CiAgICAg RVhQRUNUX1NUUkVRKGV4cGVjdGVkLnV0ZjgoKS5kYXRhKCksIGFjdHVhbC51dGY4KCkuZGF0YSgp KTsKKyNlbmRpZgogCiAgICAgYWN0dWFsID0gV2ViQ29yZTo6d2ViS2l0QnVuZGxlUGF0aCgiZmls ZS1kb2VzLW5vdCJfcywgImV4aXN0Il9zLCAiZmlsZSJfcyk7CiAgICAgZXhwZWN0ZWQgPSBlbXB0 eVN0cmluZygpOwo=