247856 2022-11-13 03:11:33 -0800 Simplify includesAdjacentEdges in BorderEdge.h 2022-11-13 20:41:20 -0800 1 1 1 Unclassified WebKit Layout and Rendering Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ahmad.saleem792 webkit-unassigned bfulgham ntim simon.fraser webkit-bug-importer zalan oldest_to_newest 1912076 0 ahmad.saleem792 2022-11-13 03:11:33 -0800 Hi Team, While going through Blink commits, I came across another simplification / refactoring for "adjacency test" for Border Painting: Blink Commit - https://chromium.googlesource.com/chromium/blink/+/45cd7b0546450187bb5f781d47778b739911341f Webkit GitHub - https://github.com/WebKit/WebKit/blob/5a9504aef82d929917a680a05a3fc17f7f6b4dde/Source/WebCore/rendering/BorderEdge.h#L77 I am raising this bug so if this can be applied in Webkit context. Thanks! 1912085 1 ntim 2022-11-13 08:09:06 -0800 (In reply to Ahmad Saleem from comment #0) > I am raising this bug so if this can be applied in Webkit context. Yep, the equivalent would be: flags.containsAny({ BoxSideFlag::Top, BoxSideFlag::Bottom }) && flags.containsAny({ BoxSideFlag::Left, BoxSideFlag::Right }) 1912094 2 ahmad.saleem792 2022-11-13 12:05:25 -0800 https://github.com/WebKit/WebKit/pull/6445 1912166 3 ews-feeder 2022-11-13 20:40:10 -0800 Committed 256631@main (cf6c7427c391): <https://commits.webkit.org/256631@main> Reviewed commits have been landed. Closing PR #6445 and removing active labels. 1912167 4 webkit-bug-importer 2022-11-13 20:41:20 -0800 <rdar://problem/102302676>