24782 2009-03-24 12:38:30 -0700 CSS clip with auto values broken 2009-03-24 13:46:34 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser oldest_to_newest 115003 0 simon.fraser 2009-03-24 12:38:30 -0700 The fix for bug 24753 broke css clip with auto values. 115005 1 simon.fraser 2009-03-24 12:39:17 -0700 This breakage shows in two tests: fast/clip/016.html fast/clip/outline-overflowClip.html 115032 2 28909 simon.fraser 2009-03-24 13:40:10 -0700 Created attachment 28909 Patch, changelog 115033 3 28909 mitz 2009-03-24 13:43:32 -0700 Comment on attachment 28909 Patch, changelog > - left = Length(rect->left()->computeLengthIntForLength(style(), zoomFactor), Fixed); > + > + top = convertToLength(rect->top(), style(), zoomFactor); You are adding extra whitespace there. r=me 115035 4 simon.fraser 2009-03-24 13:46:34 -0700 http://trac.webkit.org/changeset/41950 28909 2009-03-24 13:40:10 -0700 2009-03-24 13:43:32 -0700 Patch, changelog 24782_patch.txt text/plain 7209 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTNhOWUwYy4uOWQ2ZDJiMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAwOS0wMy0yNCAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yNDc4MgorCisgICAgICAgIEZpeCByZWdyZXNzaW9uIHdpdGggQ1NTIGNsaXAg cmVjdHMgd2l0aCBub24tbGVuZ3RoIHZhbHVlcywgYnkgcmV2ZXJ0aW5nIHRvCisgICAgICAgIHRo ZSBvcmlnaW5hbCBjb2RlLCBidXQgcGFzc2luZyB0aGUgem9vbSBtdWx0aXBsaWVyIHRocm91Z2gg Y29udmVydFRvTGVuZ3RoKCkuCisgICAgICAgIAorICAgICAgICBBbHNvIG1ha2Ugc3R5bGlzdGlj IGNoYW5nZSBpbiBjcmVhdGVUcmFuc2Zvcm1PcGVyYXRpb25zKCksIHJlbmFtaW5nICdpblN0eWxl JworICAgICAgICB0byAnc3R5bGUuCisgICAgICAgIAorICAgICAgICBUZXN0ZWQgYnkgZXhpc3Rp bmcgdGVzdHMuCisKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpjb252ZXJ0VG9MZW5ndGgpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVT ZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0eSk6CisgICAgICAgIChXZWJDb3JlOjpDU1NTdHlsZVNlbGVj dG9yOjpjcmVhdGVUcmFuc2Zvcm1PcGVyYXRpb25zKToKKwogMjAwOS0wMy0yMyAgU2ltb24gRnJh c2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnR0 aSBLb2l2aXN0bwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAg Yi9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAppbmRleCAwZmM1NGFjLi41ZWE5ODI4 IDEwMDY0NAotLS0gYS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAorKysgYi9XZWJD b3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcApAQCAtMjcwMyw3ICsyNzAzLDcgQEAgdm9pZCBD U1NSdWxlU2V0OjphZGRSdWxlc0Zyb21TaGVldChDU1NTdHlsZVNoZWV0KiBzaGVldCwgY29uc3Qg TWVkaWFRdWVyeUV2YWx1YXQKIC8vIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIC8vIHRo aXMgaXMgbW9zdGx5IGJvcmluZyBzdHVmZiBvbiBob3cgdG8gYXBwbHkgYSBjZXJ0YWluIHJ1bGUg dG8gdGhlIHJlbmRlcnN0eWxlLi4uCiAKLXN0YXRpYyBMZW5ndGggY29udmVydFRvTGVuZ3RoKENT U1ByaW1pdGl2ZVZhbHVlICpwcmltaXRpdmVWYWx1ZSwgUmVuZGVyU3R5bGUgKnN0eWxlLCBib29s ICpvayA9IDApCitzdGF0aWMgTGVuZ3RoIGNvbnZlcnRUb0xlbmd0aChDU1NQcmltaXRpdmVWYWx1 ZSAqcHJpbWl0aXZlVmFsdWUsIFJlbmRlclN0eWxlICpzdHlsZSwgZG91YmxlIG11bHRpcGxpZXIg PSAxLCBib29sICpvayA9IDApCiB7CiAgICAgLy8gVGhpcyBmdW5jdGlvbiBpcyB0b2xlcmFudCBv ZiBhIG51bGwgc3R5bGUgdmFsdWUuIFRoZSBvbmx5IHBsYWNlIHN0eWxlIGlzIHVzZWQgaXMgaW4K ICAgICAvLyBsZW5ndGggbWVhc3VyZW1lbnRzLCBsaWtlICdlbXMnIGFuZCAncHgnLiBBbmQgaW4g dGhvc2UgY2FzZXMgc3R5bGUgaXMgb25seSB1c2VkCkBAIC0yNzE5LDcgKzI3MTksNyBAQCBzdGF0 aWMgTGVuZ3RoIGNvbnZlcnRUb0xlbmd0aChDU1NQcmltaXRpdmVWYWx1ZSAqcHJpbWl0aXZlVmFs dWUsIFJlbmRlclN0eWxlICpzdAogICAgICAgICAgICAgaWYgKG9rKQogICAgICAgICAgICAgICAg ICpvayA9IGZhbHNlOwogICAgICAgICB9IGVsc2UgaWYgKENTU1ByaW1pdGl2ZVZhbHVlOjppc1Vu aXRUeXBlTGVuZ3RoKHR5cGUpKQotICAgICAgICAgICAgbCA9IExlbmd0aChwcmltaXRpdmVWYWx1 ZS0+Y29tcHV0ZUxlbmd0aEludEZvckxlbmd0aChzdHlsZSksIEZpeGVkKTsKKyAgICAgICAgICAg IGwgPSBMZW5ndGgocHJpbWl0aXZlVmFsdWUtPmNvbXB1dGVMZW5ndGhJbnRGb3JMZW5ndGgoc3R5 bGUsIG11bHRpcGxpZXIpLCBGaXhlZCk7CiAgICAgICAgIGVsc2UgaWYgKHR5cGUgPT0gQ1NTUHJp bWl0aXZlVmFsdWU6OkNTU19QRVJDRU5UQUdFKQogICAgICAgICAgICAgbCA9IExlbmd0aChwcmlt aXRpdmVWYWx1ZS0+Z2V0RG91YmxlVmFsdWUoKSwgUGVyY2VudCk7CiAgICAgICAgIGVsc2UgaWYg KHR5cGUgPT0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19OVU1CRVIpCkBAIC0zOTU0LDExICszOTU0 LDExIEBAIHZvaWQgQ1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0eShpbnQgaWQsIENTU1Zh bHVlICp2YWx1ZSkKICAgICAgICAgICAgIFJlY3QqIHJlY3QgPSBwcmltaXRpdmVWYWx1ZS0+Z2V0 UmVjdFZhbHVlKCk7CiAgICAgICAgICAgICBpZiAoIXJlY3QpCiAgICAgICAgICAgICAgICAgcmV0 dXJuOwotCi0gICAgICAgICAgICB0b3AgPSBMZW5ndGgocmVjdC0+dG9wKCktPmNvbXB1dGVMZW5n dGhJbnRGb3JMZW5ndGgoc3R5bGUoKSwgem9vbUZhY3RvciksIEZpeGVkKTsKLSAgICAgICAgICAg IHJpZ2h0ID0gTGVuZ3RoKHJlY3QtPnJpZ2h0KCktPmNvbXB1dGVMZW5ndGhJbnRGb3JMZW5ndGgo c3R5bGUoKSwgem9vbUZhY3RvciksIEZpeGVkKTsKLSAgICAgICAgICAgIGJvdHRvbSA9IExlbmd0 aChyZWN0LT5ib3R0b20oKS0+Y29tcHV0ZUxlbmd0aEludEZvckxlbmd0aChzdHlsZSgpLCB6b29t RmFjdG9yKSwgRml4ZWQpOwotICAgICAgICAgICAgbGVmdCA9IExlbmd0aChyZWN0LT5sZWZ0KCkt PmNvbXB1dGVMZW5ndGhJbnRGb3JMZW5ndGgoc3R5bGUoKSwgem9vbUZhY3RvciksIEZpeGVkKTsK KyAgICAgICAgICAgIAorICAgICAgICAgICAgdG9wID0gY29udmVydFRvTGVuZ3RoKHJlY3QtPnRv cCgpLCBzdHlsZSgpLCB6b29tRmFjdG9yKTsKKyAgICAgICAgICAgIHJpZ2h0ID0gY29udmVydFRv TGVuZ3RoKHJlY3QtPnJpZ2h0KCksIHN0eWxlKCksIHpvb21GYWN0b3IpOworICAgICAgICAgICAg Ym90dG9tID0gY29udmVydFRvTGVuZ3RoKHJlY3QtPmJvdHRvbSgpLCBzdHlsZSgpLCB6b29tRmFj dG9yKTsKKyAgICAgICAgICAgIGxlZnQgPSBjb252ZXJ0VG9MZW5ndGgocmVjdC0+bGVmdCgpLCBz dHlsZSgpLCB6b29tRmFjdG9yKTsKICAgICAgICAgfSBlbHNlIGlmIChwcmltaXRpdmVWYWx1ZS0+ Z2V0SWRlbnQoKSAhPSBDU1NWYWx1ZUF1dG8pIHsKICAgICAgICAgICAgIHJldHVybjsKICAgICAg ICAgfQpAQCAtNDgyNyw3ICs0ODI3LDcgQEAgdm9pZCBDU1NTdHlsZVNlbGVjdG9yOjphcHBseVBy b3BlcnR5KGludCBpZCwgQ1NTVmFsdWUgKnZhbHVlKQogICAgICAgICB9CiAgICAgICAgIGVsc2Ug ewogICAgICAgICAgICAgYm9vbCBvayA9IHRydWU7Ci0gICAgICAgICAgICBMZW5ndGggbCA9IGNv bnZlcnRUb0xlbmd0aChwcmltaXRpdmVWYWx1ZSwgc3R5bGUoKSwgJm9rKTsKKyAgICAgICAgICAg IExlbmd0aCBsID0gY29udmVydFRvTGVuZ3RoKHByaW1pdGl2ZVZhbHVlLCBzdHlsZSgpLCAxLCAm b2spOwogICAgICAgICAgICAgaWYgKG9rKQogICAgICAgICAgICAgICAgIG1fc3R5bGUtPnNldE1h cnF1ZWVJbmNyZW1lbnQobCk7CiAgICAgICAgIH0KQEAgLTU4OTMsNyArNTg5Myw3IEBAIHN0YXRp YyBUcmFuc2Zvcm1PcGVyYXRpb246Ok9wZXJhdGlvblR5cGUgZ2V0VHJhbnNmb3JtT3BlcmF0aW9u VHlwZShXZWJLaXRDU1NUcmFuCiAgICAgcmV0dXJuIFRyYW5zZm9ybU9wZXJhdGlvbjo6Tk9ORTsK IH0KIAotYm9vbCBDU1NTdHlsZVNlbGVjdG9yOjpjcmVhdGVUcmFuc2Zvcm1PcGVyYXRpb25zKENT U1ZhbHVlKiBpblZhbHVlLCBSZW5kZXJTdHlsZSogaW5TdHlsZSwgVHJhbnNmb3JtT3BlcmF0aW9u cyYgb3V0T3BlcmF0aW9ucykKK2Jvb2wgQ1NTU3R5bGVTZWxlY3Rvcjo6Y3JlYXRlVHJhbnNmb3Jt T3BlcmF0aW9ucyhDU1NWYWx1ZSogaW5WYWx1ZSwgUmVuZGVyU3R5bGUqIHN0eWxlLCBUcmFuc2Zv cm1PcGVyYXRpb25zJiBvdXRPcGVyYXRpb25zKQogewogICAgIFRyYW5zZm9ybU9wZXJhdGlvbnMg b3BlcmF0aW9uczsKICAgICBpZiAoaW5WYWx1ZSAmJiAhaW5WYWx1ZS0+aXNQcmltaXRpdmVWYWx1 ZSgpKSB7CkBAIC01OTU4LDEzICs1OTU4LDEzIEBAIGJvb2wgQ1NTU3R5bGVTZWxlY3Rvcjo6Y3Jl YXRlVHJhbnNmb3JtT3BlcmF0aW9ucyhDU1NWYWx1ZSogaW5WYWx1ZSwgUmVuZGVyU3R5bGUqCiAg ICAgICAgICAgICAgICAgICAgIExlbmd0aCB0eCA9IExlbmd0aCgwLCBGaXhlZCk7CiAgICAgICAg ICAgICAgICAgICAgIExlbmd0aCB0eSA9IExlbmd0aCgwLCBGaXhlZCk7CiAgICAgICAgICAgICAg ICAgICAgIGlmICh2YWwtPm9wZXJhdGlvblR5cGUoKSA9PSBXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1 ZTo6VHJhbnNsYXRlWVRyYW5zZm9ybU9wZXJhdGlvbikKLSAgICAgICAgICAgICAgICAgICAgICAg IHR5ID0gY29udmVydFRvTGVuZ3RoKGZpcnN0VmFsdWUsIGluU3R5bGUsICZvayk7CisgICAgICAg ICAgICAgICAgICAgICAgICB0eSA9IGNvbnZlcnRUb0xlbmd0aChmaXJzdFZhbHVlLCBzdHlsZSwg MSwgJm9rKTsKICAgICAgICAgICAgICAgICAgICAgZWxzZSB7IAotICAgICAgICAgICAgICAgICAg ICAgICAgdHggPSBjb252ZXJ0VG9MZW5ndGgoZmlyc3RWYWx1ZSwgaW5TdHlsZSwgJm9rKTsKKyAg ICAgICAgICAgICAgICAgICAgICAgIHR4ID0gY29udmVydFRvTGVuZ3RoKGZpcnN0VmFsdWUsIHN0 eWxlLCAxLCAmb2spOwogICAgICAgICAgICAgICAgICAgICAgICAgaWYgKHZhbC0+b3BlcmF0aW9u VHlwZSgpICE9IFdlYktpdENTU1RyYW5zZm9ybVZhbHVlOjpUcmFuc2xhdGVYVHJhbnNmb3JtT3Bl cmF0aW9uKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKHZhbC0+bGVuZ3RoKCkg PiAxKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIENTU1ByaW1pdGl2ZVZhbHVl KiBzZWNvbmRWYWx1ZSA9IHN0YXRpY19jYXN0PENTU1ByaW1pdGl2ZVZhbHVlKj4odmFsLT5pdGVt V2l0aG91dEJvdW5kc0NoZWNrKDEpKTsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dHkgPSBjb252ZXJ0VG9MZW5ndGgoc2Vjb25kVmFsdWUsIGluU3R5bGUsICZvayk7CisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHR5ID0gY29udmVydFRvTGVuZ3RoKHNlY29uZFZhbHVl LCBzdHlsZSwgMSwgJm9rKTsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAg ICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgICAgIH0KQEAgLTU5ODIsMTkgKzU5 ODIsMTkgQEAgYm9vbCBDU1NTdHlsZVNlbGVjdG9yOjpjcmVhdGVUcmFuc2Zvcm1PcGVyYXRpb25z KENTU1ZhbHVlKiBpblZhbHVlLCBSZW5kZXJTdHlsZSoKICAgICAgICAgICAgICAgICAgICAgTGVu Z3RoIHR5ID0gTGVuZ3RoKDAsIEZpeGVkKTsKICAgICAgICAgICAgICAgICAgICAgTGVuZ3RoIHR6 ID0gTGVuZ3RoKDAsIEZpeGVkKTsKICAgICAgICAgICAgICAgICAgICAgaWYgKHZhbC0+b3BlcmF0 aW9uVHlwZSgpID09IFdlYktpdENTU1RyYW5zZm9ybVZhbHVlOjpUcmFuc2xhdGVaVHJhbnNmb3Jt T3BlcmF0aW9uKQotICAgICAgICAgICAgICAgICAgICAgICAgdHogPSBjb252ZXJ0VG9MZW5ndGgo Zmlyc3RWYWx1ZSwgaW5TdHlsZSwgJm9rKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIHR6ID0g Y29udmVydFRvTGVuZ3RoKGZpcnN0VmFsdWUsIHN0eWxlLCAxLCAmb2spOwogICAgICAgICAgICAg ICAgICAgICBlbHNlIGlmICh2YWwtPm9wZXJhdGlvblR5cGUoKSA9PSBXZWJLaXRDU1NUcmFuc2Zv cm1WYWx1ZTo6VHJhbnNsYXRlWVRyYW5zZm9ybU9wZXJhdGlvbikKLSAgICAgICAgICAgICAgICAg ICAgICAgIHR5ID0gY29udmVydFRvTGVuZ3RoKGZpcnN0VmFsdWUsIGluU3R5bGUsICZvayk7Cisg ICAgICAgICAgICAgICAgICAgICAgICB0eSA9IGNvbnZlcnRUb0xlbmd0aChmaXJzdFZhbHVlLCBz dHlsZSwgMSwgJm9rKTsKICAgICAgICAgICAgICAgICAgICAgZWxzZSB7IAotICAgICAgICAgICAg ICAgICAgICAgICAgdHggPSBjb252ZXJ0VG9MZW5ndGgoZmlyc3RWYWx1ZSwgaW5TdHlsZSwgJm9r KTsKKyAgICAgICAgICAgICAgICAgICAgICAgIHR4ID0gY29udmVydFRvTGVuZ3RoKGZpcnN0VmFs dWUsIHN0eWxlLCAxLCAmb2spOwogICAgICAgICAgICAgICAgICAgICAgICAgaWYgKHZhbC0+b3Bl cmF0aW9uVHlwZSgpICE9IFdlYktpdENTU1RyYW5zZm9ybVZhbHVlOjpUcmFuc2xhdGVYVHJhbnNm b3JtT3BlcmF0aW9uKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKHZhbC0+bGVu Z3RoKCkgPiAyKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIENTU1ByaW1pdGl2 ZVZhbHVlKiB0aGlyZFZhbHVlID0gc3RhdGljX2Nhc3Q8Q1NTUHJpbWl0aXZlVmFsdWUqPih2YWwt Pml0ZW1XaXRob3V0Qm91bmRzQ2hlY2soMikpOwotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB0eiA9IGNvbnZlcnRUb0xlbmd0aCh0aGlyZFZhbHVlLCBpblN0eWxlLCAmb2spOworICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0eiA9IGNvbnZlcnRUb0xlbmd0aCh0aGlyZFZh bHVlLCBzdHlsZSwgMSwgJm9rKTsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9CiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgaWYgKHZhbC0+bGVuZ3RoKCkgPiAxKSB7CiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIENTU1ByaW1pdGl2ZVZhbHVlKiBzZWNvbmRWYWx1ZSA9 IHN0YXRpY19jYXN0PENTU1ByaW1pdGl2ZVZhbHVlKj4odmFsLT5pdGVtV2l0aG91dEJvdW5kc0No ZWNrKDEpKTsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdHkgPSBjb252ZXJ0VG9M ZW5ndGgoc2Vjb25kVmFsdWUsIGluU3R5bGUsICZvayk7CisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHR5ID0gY29udmVydFRvTGVuZ3RoKHNlY29uZFZhbHVlLCBzdHlsZSwgMSwgJm9r KTsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgICAgICAg ICB9CiAgICAgICAgICAgICAgICAgICAgIH0K