247793 2022-11-11 02:11:32 -0800 Clicking a link to a download file served by a service-worker with a fetch event handler yields "Frame load interrupted" error 2022-11-16 03:01:50 -0800 1 1 1 Unclassified WebKit Service Workers Safari 16 All Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=247885 InRadar P2 Normal --- 1 steffen.weber youennf achristensen cdumez webkit-bug-importer youennf oldest_to_newest 1911774 0 463490 steffen.weber 2022-11-11 02:11:32 -0800 Created attachment 463490 reduced test-case When clicking a link to a file that Safari has to download (because of its MIME-type, a "Content-disposition" header, or a "download" attribute on the link) and which is served by a service worker with a non-empty fetch event handler, the download hangs and the developer console shows an error: "Failed to load resource: Frame load interrupted". This is a regression in Safari 16.0 or 16.1. We've been able to reproduce it on macOS 13 (Safari 16.1 18614.2.9.1.12 and Safari Technology Preview as of yesterday), on iPadOS 16.1 and on Linux (Epiphany 42.4 "Powered by WebKitGTK 2.38.2"). I've attached a reduced test-case. Remember that you have to open it on a secure origin (localhost or HTTPS) because it uses a service worker. The bug disappears when you remove the fetch event handler (or the service worker as a whole). The bug also disappears when you link to a file that Safari doesn't have to download but can display itself. 1912113 1 webkit-bug-importer 2022-11-13 14:52:30 -0800 <rdar://problem/102296700> 1912199 2 youennf 2022-11-14 00:03:17 -0800 It appears the reduced test case only contains an empty file. Can you upload a new reduced test case? 1912203 3 463514 steffen.weber 2022-11-14 00:15:55 -0800 Created attachment 463514 reduced test-case (for real) Accidentally uploaded the wrong file and had already deleted the files locally. But fortunately the test-case was easy enough to recreate it. :) 1912212 4 youennf 2022-11-14 01:06:21 -0800 I can see the "Failed to load resource: Frame load interrupted", which is probably unexpected. But I do not see the download hang (in WebKit ToT and STP 157). The file seems properly downloaded and unzipped. 1912217 5 youennf 2022-11-14 01:21:01 -0800 I'll work on fixing the "Frame load interrupted". It seems this message was there in Safari 15.5 1912218 6 youennf 2022-11-14 01:22:55 -0800 @Steffen, let me know whether your main issue is the download hang. Since I cannot reproduce, I might ask a sysdiagnose. For now, I will use this bug entry for the console log message. 1912220 7 youennf 2022-11-14 01:24:46 -0800 Pull request: https://github.com/WebKit/WebKit/pull/6463 1912246 8 463519 steffen.weber 2022-11-14 02:18:21 -0800 Created attachment 463519 reduced test-case v3 It seems like the two issues (the hanging download and the console error) are indeed unrelated. I had wrongly assumed they were related and focused on creating a reduced test-case that triggered the console error in Epiphany and later didn't verify the results in Safari again. (It's way easier for me to test in Epiphany.) Anyway, I have created another test-case (v3) that triggers the real bug (the hanging download) in Safari. It turns out you have to add "FetchEvent.preloadResponse" to the mix to trigger this bug. Please have a look at the updated test-case. 1912249 9 youennf 2022-11-14 02:35:17 -0800 Thanks Steffen, I can reproduce and will fix the issue. 1912815 10 ews-feeder 2022-11-16 00:52:06 -0800 Committed 256725@main (30bd7667b181): <https://commits.webkit.org/256725@main> Reviewed commits have been landed. Closing PR #6463 and removing active labels. 1912829 11 steffen.weber 2022-11-16 03:00:53 -0800 Thank you! May I ask in which Safari release this fix will appear? Any chance to get the fix earlier than Safari 17 in March / April 2023? 1912830 12 steffen.weber 2022-11-16 03:01:50 -0800 Oops, forgot that this bug is only about the console error. 463490 2022-11-11 02:11:32 -0800 2022-11-14 00:15:55 -0800 reduced test-case safari-bug-dl.zip application/zip 208 steffen.weber UEsDBBQACAAIAKhWa1UAAAAAAAAAAAAAAAAOACAAZW1wdHktZmlsZS50eHRVVA0AB4wbbmOMG25j jBtuY3V4CwABBOgDAAAE6AMAAAMAUEsHCAAAAAACAAAAAAAAAFBLAQIUAxQACAAIAKhWa1UAAAAA AgAAAAAAAAAOACAAAAAAAAAAAACkgQAAAABlbXB0eS1maWxlLnR4dFVUDQAHjBtuY4wbbmOMG25j dXgLAAEE6AMAAAToAwAAUEsFBgAAAAABAAEAXAAAAF4AAAAAAA== 463514 2022-11-14 00:15:55 -0800 2022-11-14 02:18:21 -0800 reduced test-case (for real) safari-bug.zip application/zip 902 steffen.weber UEsDBBQACAAIAJpJblUAAAAAAAAAAKkAAAAPACAAc2FmYXJpLWJ1Zy5odG1sVVQNAAeF+HFjCvhx Y4X4cWN1eAsAAQToAwAABOgDAABNjkEOgjAQRddyisoGXdAewJGVd3A90AFGattMKwRPLwnGuPpv 8fPy4GhDl9dIasxP1xTwnTbYtSkOkDrhmDfyOPOAOYhOJDN3dA8ykWihgVMmOVUJexSu29dQp0U/ UnW+bALzMwCqUai/ln9H6/SbY9ncwuJdQKsc+wkMbgVmTwCzF30AUEsHCCpXNLGFAAAAqQAAAFBL AwQUAAgACAAGSW5VAAAAAAAAAADQAAAAEQAgAHNhZmFyaS1idWctZGwuemlwVVQNAAdt93Fjbfdx Y7r3cWN1eAsAAQToAwAABOgDAAAL8GZmEWHgAMIVYdmhDEiAj0GBITW3oKRSNy0zJ1WvpKIkNISX gb1HOi8ZhksruBkYWV4wMzCACWaGAG92DpBeJqgZAd6MTCLMqOYzIZkPA0saQSRptgV4s7KBdDEC YQyQjgObBABQSwcIU2PEfmYAAADQAAAAUEsDBBQACAAIAE5JblUAAAAAAAAAAF8AAAAQACAAc2Fm YXJpLWJ1Zy1zdy5qc1VUDQAH9fdxY/X3cWP193FjdXgLAAEE6AMAAAToAwAAK07NSdNLTElxLUvN K/HJLC5JzUst0lBPSy1JzlDXUUgrzUsuyczP00gFyWsqVHNxgll6RanFBfl5KeGZJRkaYMUaMPHC 0tTiEk1Na65aIAYAUEsHCE90V7JRAAAAXwAAAFBLAQIUAxQACAAIAJpJblUqVzSxhQAAAKkAAAAP ACAAAAAAAAAAAACkgQAAAABzYWZhcmktYnVnLmh0bWxVVA0AB4X4cWMK+HFjhfhxY3V4CwABBOgD AAAE6AMAAFBLAQIUAxQACAAIAAZJblVTY8R+ZgAAANAAAAARACAAAAAAAAAAAACkgeIAAABzYWZh cmktYnVnLWRsLnppcFVUDQAHbfdxY233cWO693FjdXgLAAEE6AMAAAToAwAAUEsBAhQDFAAIAAgA TkluVU90V7JRAAAAXwAAABAAIAAAAAAAAAAAAKSBpwEAAHNhZmFyaS1idWctc3cuanNVVA0AB/X3 cWP193Fj9fdxY3V4CwABBOgDAAAE6AMAAFBLBQYAAAAAAwADABoBAABWAgAAAAA= 463519 2022-11-14 02:18:21 -0800 2022-11-14 02:18:21 -0800 reduced test-case v3 safari-bug.zip application/zip 1031 steffen.weber UEsDBBQACAAIAMVTblUAAAAAAAAAAKsAAAAPACAAc2FmYXJpLWJ1Zy5odG1sVVQNAAejCnJjCvhx Y6MKcmN1eAsAAQToAwAABOgDAAA9jkEOgjAQRddyisoGXbQ9gJWVd3A90KGM1JZMKwRPbxOIq/+T l7w8c7axz9uMYsxv31bmmC7ara1OJvVMcy4vwEIOcmSVkBfq8Rl5QlaMjlJGvjT6AHLdySs111tR 6L/DgBgZh3udYAAm2X2ctF59aa7bR1yDj2CFpzAZDaVB7xFG700/UEsHCFGQbciFAAAAqwAAAFBL AwQUAAgACAAGSW5VAAAAAAAAAADQAAAAEQAgAHNhZmFyaS1idWctZGwuemlwVVQNAAdt93Fjbfdx Y2EFcmN1eAsAAQToAwAABOgDAAAL8GZmEWHgAMIVYdmhDEiAj0GBITW3oKRSNy0zJ1WvpKIkNISX gb1HOi8ZhksruBkYWV4wMzCACWaGAG92DpBeJqgZAd6MTCLMqOYzIZkPA0saQSRptgV4s7KBdDEC YQyQjgObBABQSwcIU2PEfmYAAADQAAAAUEsDBBQACAAIAJNZblUAAAAAAAAAAKABAAAQACAAc2Fm YXJpLWJ1Zy1zdy5qc1VUDQAHlhRyY/X3cWOWFHJjdXgLAAEE6AMAAAToAwAAjZA9bsMwDIVn6RTa QgGBLxCkW7cORYEiM2PTDlGBdkXGRRHk7pX/OrVoBwES3/vIRymltsKmeRxJ7InVSCjDjkUNU9rt A9CkxHB8CDfv5kf1gWyvYpxAJ1zfeDiVEksHMR78vRyvPzfG2nhEo/91ztQVMqNxL5XgyN18fc6U emwqEjwn+nNmS1ZffhmYSYdemhPbBbxzgPopNWwe5+q+/ERYXErhGHCKGBZ4WHK8rOphArgNsNlj Ae2a5ZufHWttTgVbivcrqcVJv0eIe+/Wnb4AUEsHCAGkXBnSAAAAoAEAAFBLAQIUAxQACAAIAMVT blVRkG3IhQAAAKsAAAAPACAAAAAAAAAAAACkgQAAAABzYWZhcmktYnVnLmh0bWxVVA0AB6MKcmMK +HFjowpyY3V4CwABBOgDAAAE6AMAAFBLAQIUAxQACAAIAAZJblVTY8R+ZgAAANAAAAARACAAAAAA AAAAAACkgeIAAABzYWZhcmktYnVnLWRsLnppcFVUDQAHbfdxY233cWNhBXJjdXgLAAEE6AMAAATo AwAAUEsBAhQDFAAIAAgAk1luVQGkXBnSAAAAoAEAABAAIAAAAAAAAAAAAKSBpwEAAHNhZmFyaS1i dWctc3cuanNVVA0AB5YUcmP193FjlhRyY3V4CwABBOgDAAAE6AMAAFBLBQYAAAAAAwADABoBAADX AgAAAAA=