247756 2022-11-10 12:29:49 -0800 REGRESSION (256493@main): [iOS] 13 API tests crashing in dlopen of SafariServices: Symbol not found: __ZN3WTF16weakRandomUint32Ev 2022-11-10 14:22:11 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=247581 InRadar P2 Normal --- 1 ryanhaddad webkit-unassigned commit-queue darin webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1911616 0 ryanhaddad 2022-11-10 12:29:49 -0800 The following API tests are asserting on iOS bots: TestWebKitAPI.ActionSheetTests.CopyImageElementWithHREF TestWebKitAPI.ActionSheetTests.CopyImageElementWithHREFAndTitle TestWebKitAPI.ActionSheetTests.CopyImageElementWithoutHREF TestWebKitAPI.ActionSheetTests.CopyLinkWritesURLAndPlainText TestWebKitAPI.ActionSheetTests.ImageMapDoesNotDestroySelection TestWebKitAPI.ContextMenu.APIBeforeSPI TestWebKitAPI.ContextMenu.Click TestWebKitAPI.ContextMenu.HintPreviewContainer TestWebKitAPI.ContextMenu.Image TestWebKitAPI.ContextMenu.Legacy TestWebKitAPI.ContextMenu.SuggestedActions TestWebKitAPI.ShareSheetTests.ShareAnchorElementAsURL TestWebKitAPI.ShareSheetTests.ShareImgElementWithBase64URL ASSERTION FAILED: dlopen(/System/Library/Frameworks/SafariServices.framework/SafariServices, 0x0002): Symbol not found: __ZN3WTF16weakRandomUint32Ev Referenced from: <4FE07132-A75C-36C9-9969-C90FAE38102F> /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Cryptexes/OS/System/Library/PrivateFrameworks/SafariSharedUI.framework/SafariSharedUI Expected in: <EF5F3D90-B681-3D72-BA41-D3C800E556A4> /Volumes/Data/worker/Apple-iOS-16-Simulator-Debug-WK2-Tests/build/WebKitBuild/Debug-iphonesimulator/JavaScriptCore.framework/JavaScriptCore result /Volumes/Data/worker/Apple-iOS-16-Simulator-Debug-Build/build/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm(61) : void *SafariServicesLibrary()_block_invoke 1 0x115e6fd49 WTFCrash 2 0x135fba3f5 invocation function for block in SafariServicesLibrary() 3 0x135fba35e SafariServicesLibrary() 4 0x135fba2b9 initSSReadingList() 5 0x135fad706 -[WKActionSheetAssistant defaultActionsForImageSheet:] 6 0x135fab6d5 __40-[WKActionSheetAssistant showImageSheet]_block_invoke 7 0x135fab2eb -[WKActionSheetAssistant showImageSheet] 8 0x13749ecf6 -[WKContentView(WKInteraction) _showImageSheet] 9 0x1374da525 -[WKContentView(WKTesting) _simulateLongPressActionAtLocation:]::$_85::operator()(WebKit::InteractionInformationAtPosition) const 10 0x1374da4c9 __63-[WKContentView(WKTesting) _simulateLongPressActionAtLocation:]_block_invoke 11 0x13749ffc8 WTF::BlockPtr<void (WebKit::InteractionInformationAtPosition)>::operator()(WebKit::InteractionInformationAtPosition) const 12 0x13749fbe8 -[WKContentView(WKInteraction) _invokeAndRemovePendingHandlersValidForCurrentPositionInformation] 13 0x1374a4667 -[WKContentView(WKInteraction) _positionInformationDidChange:] 14 0x135f9c4a1 WebKit::PageClientImpl::positionInformationDidChange(WebKit::InteractionInformationAtPosition const&) 15 0x1360025c9 WebKit::WebPageProxy::didReceivePositionInformation(WebKit::InteractionInformationAtPosition const&) 16 0x13719b887 void IPC::callMemberFunctionImpl<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebKit::InteractionInformationAtPosition const&), std::__1::tuple<WebKit::InteractionInformationAtPosition>, 0ul>(WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(WebKit::InteractionInformationAtPosition const&), std::__1::tuple<WebKit::InteractionInformationAtPosition>&&, std::__1::integer_sequence<unsigned long, 0ul>) 17 0x13719ac0d void IPC::callMemberFunction<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebKit::InteractionInformationAtPosition const&), std::__1::tuple<WebKit::InteractionInformationAtPosition>, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<WebKit::InteractionInformationAtPosition>&&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(WebKit::InteractionInformationAtPosition const&)) 18 0x13713f001 void IPC::handleMessage<Messages::WebPageProxy::DidReceivePositionInformation, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebKit::InteractionInformationAtPosition const&)>(IPC::Connection&, IPC::Decoder&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(WebKit::InteractionInformationAtPosition const&)) 19 0x13713560a WebKit::WebPageProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 20 0x1375b23b3 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 21 0x13611b5ac WebKit::AuxiliaryProcessProxy::dispatchMessage(IPC::Connection&, IPC::Decoder&) 22 0x13639af09 WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 23 0x1375842af IPC::Connection::dispatchMessage(IPC::Decoder&) 24 0x13758467a IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 25 0x137584de4 IPC::Connection::dispatchIncomingMessages() 26 0x1375a64bd IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_16::operator()() const 27 0x1375a6409 WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_16, void>::call() 28 0x115e9fa22 WTF::Function<void ()>::operator()() const 29 0x115f4055e WTF::RunLoop::performWork() 30 0x115f45afe WTF::RunLoop::performWork(void*) 31 0x10b772ebd __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.ActionSheetTests.CopyImageElementWithHREF&test=TestWebKitAPI.ActionSheetTests.CopyImageElementWithHREFAndTitle&test=TestWebKitAPI.ActionSheetTests.CopyImageElementWithoutHREF&test=TestWebKitAPI.ActionSheetTests.CopyLinkWritesURLAndPlainText&test=TestWebKitAPI.ActionSheetTests.ImageMapDoesNotDestroySelection&test=TestWebKitAPI.ContextMenu.APIBeforeSPI&test=TestWebKitAPI.ContextMenu.Click&test=TestWebKitAPI.ContextMenu.HintPreviewContainer&test=TestWebKitAPI.ContextMenu.Image&test=TestWebKitAPI.ContextMenu.Legacy&test=TestWebKitAPI.ContextMenu.SuggestedActions&test=TestWebKitAPI.ShareSheetTests.ShareAnchorElementAsURL&test=TestWebKitAPI.ShareSheetTests.ShareImgElementWithBase64URL 1911619 1 ryanhaddad 2022-11-10 12:32:08 -0800 It looks like https://commits.webkit.org/256493@main renamed weakRandomUint32 -> weakRandomNumber 1911620 2 webkit-bug-importer 2022-11-10 12:32:55 -0800 <rdar://problem/102206582> 1911636 3 ryanhaddad 2022-11-10 13:31:06 -0800 This is impacting iOS API test EWS, so I think I'll revert for now. 1911642 4 ryanhaddad 2022-11-10 13:38:06 -0800 *** Bug 247758 has been marked as a duplicate of this bug. *** 1911644 5 ryanhaddad 2022-11-10 13:38:20 -0800 Reverted in https://commits.webkit.org/256547@main 1911658 6 darin 2022-11-10 14:22:11 -0800 I changed Safari to not depend on this even before making the WebKit change: rdar://102058171 (Remove unnecessary use of WTF's weakRandomUint32 from SafariShared) How can I take advantage of this and re-land <https://commits.webkit.org/256493@main>?