247658 2022-11-08 17:22:41 -0800 [WinCairo] ASSERTION FAILED: result in WebKit::NetworkProcess::allowsFirstPartyForCookies 2022-11-09 20:57:32 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 247582 https://bugs.webkit.org/show_bug.cgi?id=246858 P2 Normal --- 1 fujii fujii achristensen csaavedra oldest_to_newest 1911154 0 fujii 2022-11-08 17:22:41 -0800 WinCairo WK2 Debug layout test are observing random crashes for http tests these days. ASSERTION FAILED: result C:\jenkins_slave\wincairo-main\Source\WebKit\NetworkProcess/NetworkProcess.cpp(435) : WebKit::NetworkProcess::allowsFirstPartyForCookies Backtrace: # Child-SP RetAddr Call Site 00 0000002c`1ebad8e0 00007fff`3f3c35de WTF!WTFCrash(void)+0x10 [C:\jenkins_slave\wincairo-main\Source\WTF\wtf\Assertions.cpp @ 327] 01 0000002c`1ebad910 00007fff`400a23fc WebKit2!WTFCrashWithInfo(int __formal = 0n435, char * __formal = 0x00007fff`4838a9e0 "C:\jenkins_slave\wincairo-main\Source\WebKit\NetworkProcess/NetworkProcess.cpp", char * __formal = 0x00007fff`48387f28 "WebKit::NetworkProcess::allowsFirstPartyForCookies", int __formal = 0n1699)+0x1e [C:\jenkins_slave\wincairo-main\WebKitBuild\Debug\WTF\Headers\wtf\Assertions.h @ 755] 02 0000002c`1ebad940 00007fff`400aae4e WebKit2!WebKit::NetworkProcess::allowsFirstPartyForCookies(class WTF::ObjectIdentifier<enum WebCore::ProcessIdentifierType> processIdentifier = class WTF::ObjectIdentifier<enum WebCore::ProcessIdentifierType>, class WTF::URL * firstParty = 0x0000002c`1ebae2b8)+0x30c [C:\jenkins_slave\wincairo-main\Source\WebKit\NetworkProcess\NetworkProcess.cpp @ 435] 03 0000002c`1ebada30 00007fff`3f6cf858 WebKit2!WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad(class WebKit::NetworkResourceLoadParameters * loadParameters = 0x0000002c`1ebae250, class std::optional<WTF::ObjectIdentifier<enum WebKit::NetworkResourceLoadIdentifierType> > * existingLoaderToResume = 0x0000002c`1ebae140 nullopt)+0xbe [C:\jenkins_slave\wincairo-main\Source\WebKit\NetworkProcess\NetworkConnectionToWebProcess.cpp @ 556] 04 0000002c`1ebae0f0 00007fff`3f6cd44b WebKit2!IPC::callMemberFunctionImpl<WebKit::NetworkConnectionToWebProcess,void (class WebKit::NetworkConnectionToWebProcess * object = 0x00000172`e8c99540, <function> * function = 0x0000002c`1ebae1d0, class std::tuple<WebKit::NetworkResourceLoadParameters,std::optional<WTF::ObjectIdentifier<enum WebKit::NetworkResourceLoadIdentifierType> > > * args = 0x0000002c`1ebae240, struct std::integer_sequence<unsigned __int64,0,1> __formal = struct std::integer_sequence<unsigned __int64,0,1>)+0xd8 [C:\jenkins_slave\wincairo-main\Source\WebKit\Platform\IPC\HandleMessage.h @ 132] 05 0000002c`1ebae190 00007fff`3f6f31bc WebKit2!IPC::callMemberFunction<WebKit::NetworkConnectionToWebProcess,void (class std::tuple<WebKit::NetworkResourceLoadParameters,std::optional<WTF::ObjectIdentifier<enum WebKit::NetworkResourceLoadIdentifierType> > > * args = 0x0000002c`1ebae240, class WebKit::NetworkConnectionToWebProcess * object = 0x00000172`e8c99540, <function> * function = 0x0000002c`1ebae6a0)+0x7b [C:\jenkins_slave\wincairo-main\Source\WebKit\Platform\IPC\HandleMessage.h @ 138] 06 0000002c`1ebae210 00007fff`3f6ac99f WebKit2!IPC::handleMessage<Messages::NetworkConnectionToWebProcess::ScheduleResourceLoad,WebKit::NetworkConnectionToWebProcess,void (class IPC::Connection * connection = 0x00000172`e8e8df90, class IPC::Decoder * decoder = 0x00000172`e8d44cf0, class WebKit::NetworkConnectionToWebProcess * object = 0x00000172`e8c99540, <function> * function = 0x0000002c`1ebaeab0)+0x12c [C:\jenkins_slave\wincairo-main\Source\WebKit\Platform\IPC\HandleMessage.h @ 260] 07 0000002c`1ebae6f0 00007fff`400a9f6d WebKit2!WebKit::NetworkConnectionToWebProcess::didReceiveNetworkConnectionToWebProcessMessage(class IPC::Connection * connection = 0x00000172`e8e8df90, class IPC::Decoder * decoder = 0x00000172`e8d44cf0)+0xcf [C:\jenkins_slave\wincairo-main\WebKitBuild\Debug\WebKit\DerivedSources\NetworkConnectionToWebProcessMessageReceiver.cpp @ 345] 08 0000002c`1ebaeec0 00007fff`4044c260 WebKit2!WebKit::NetworkConnectionToWebProcess::didReceiveMessage(class IPC::Connection * connection = 0x00000172`e8e8df90, class IPC::Decoder * decoder = 0x00000172`e8d44cf0)+0x10d [C:\jenkins_slave\wincairo-main\Source\WebKit\NetworkProcess\NetworkConnectionToWebProcess.cpp @ 218] 09 0000002c`1ebaf010 00007fff`4044bef9 WebKit2!IPC::Connection::dispatchMessage(class IPC::Decoder * decoder = 0x00000172`e8d44cf0)+0x1c0 [C:\jenkins_slave\wincairo-main\Source\WebKit\Platform\IPC\Connection.cpp @ 1199] 0a 0000002c`1ebaf090 00007fff`4044b78d WebKit2!IPC::Connection::dispatchMessage(class std::unique_ptr<IPC::Decoder,std::default_delete<IPC::Decoder> > * message = 0x0000002c`1ebaf1d8 unique_ptr {...})+0x2f9 [C:\jenkins_slave\wincairo-main\Source\WebKit\Platform\IPC\Connection.cpp @ 1244] 0b 0000002c`1ebaf160 00007fff`4044ebef WebKit2!IPC::Connection::dispatchOneIncomingMessage(void)+0x10d [C:\jenkins_slave\wincairo-main\Source\WebKit\Platform\IPC\Connection.cpp @ 1304] 0c 0000002c`1ebaf210 00007fff`40451b8b WebKit2!`IPC::Connection::enqueueIncomingMessage'::`19'::<lambda_2>::operator()(void)+0x1f [C:\jenkins_slave\wincairo-main\Source\WebKit\Platform\IPC\Connection.cpp @ 1161] 0d 0000002c`1ebaf240 00007fff`9ecca503 WebKit2!WTF::Detail::CallableWrapper<`IPC::Connection::enqueueIncomingMessage'::`19'::<lambda_2>,void>::call(void)+0x1b [C:\jenkins_slave\wincairo-main\WebKitBuild\Debug\WTF\Headers\wtf\Function.h @ 53] 0e 0000002c`1ebaf270 00007fff`9ed58f88 WTF!WTF::Function<void __cdecl(void)+0x93 [C:\jenkins_slave\wincairo-main\Source\WTF\wtf\Function.h @ 83] 0f 0000002c`1ebaf2b0 00007fff`9ee41df1 WTF!WTF::RunLoop::performWork(void)+0x198 [C:\jenkins_slave\wincairo-main\Source\WTF\wtf\RunLoop.cpp @ 147] 10 0000002c`1ebaf3c0 00007fff`9ee41d54 WTF!WTF::RunLoop::wndProc(struct HWND__ * hWnd = 0x00000000`3f001fae, unsigned int message = 0x401, unsigned int64 wParam = 0x00000172`e5064100, int64 lParam = 0n0)+0x41 [C:\jenkins_slave\wincairo-main\Source\WTF\wtf\win\RunLoopWin.cpp @ 57] 11 0000002c`1ebaf400 00007fff`bdede858 WTF!WTF::RunLoop::RunLoopWndProc(struct HWND__ * hWnd = 0x00000000`3f001fae, unsigned int message = 0x401, unsigned int64 wParam = 0x00000172`e5064100, int64 lParam = 0n0)+0x54 [C:\jenkins_slave\wincairo-main\Source\WTF\wtf\win\RunLoopWin.cpp @ 39] 12 0000002c`1ebaf450 00007fff`bdede299 USER32!UserCallWinProcCheckWow+0x2f8 13 0000002c`1ebaf5e0 00007fff`9ee412d6 USER32!DispatchMessageWorker+0x249 14 0000002c`1ebaf660 00007fff`3f4fa64b WTF!WTF::RunLoop::run(void)+0x66 [C:\jenkins_slave\wincairo-main\Source\WTF\wtf\win\RunLoopWin.cpp @ 74] 15 0000002c`1ebaf6f0 00007fff`3f4f9ec3 WebKit2!WebKit::AuxiliaryProcessMainBase<WebKit::NetworkProcess,0>::run(int argc = 0n7, char ** argv = 0x00000172`e50481f0)+0xab [C:\jenkins_slave\wincairo-main\Source\WebKit\Shared\AuxiliaryProcessMain.h @ 72] 16 0000002c`1ebaf740 00007fff`3f4f9ddc WebKit2!WebKit::AuxiliaryProcessMain<WebKit::NetworkProcessMainCurl>(int argc = 0n7, char ** argv = 0x00000172`e50481f0)+0x73 [C:\jenkins_slave\wincairo-main\Source\WebKit\Shared\AuxiliaryProcessMain.h @ 98] 17 0000002c`1ebaf800 00007ff7`e084101d WebKit2!WebKit::NetworkProcessMain(int argc = 0n7, char ** argv = 0x00000172`e50481f0)+0x1c [C:\jenkins_slave\wincairo-main\Source\WebKit\NetworkProcess\curl\NetworkProcessMainCurl.cpp @ 45] 18 0000002c`1ebaf830 00007ff7`e084125c WebKitNetworkProcess!main(int argc = 0n7, char ** argv = 0x00000172`e50481f0)+0x1d [C:\jenkins_slave\wincairo-main\Source\WebKit\NetworkProcess\EntryPoint\win\NetworkProcessMain.cpp @ 35] 19 (Inline Function) --------`-------- WebKitNetworkProcess!invoke_main(void)+0x22 [D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl @ 78] 1a 0000002c`1ebaf860 00007fff`bd2b7034 WebKitNetworkProcess!__scrt_common_main_seh(void)+0x10c [D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl @ 288] 1b 0000002c`1ebaf8a0 00007fff`be2e26a1 KERNEL32!BaseThreadInitThunk+0x14 1c 0000002c`1ebaf8d0 00000000`00000000 ntdll!RtlUserThreadStart+0x21 256080@main is the first internal jenkins job reported this crash. 256065@main (bug#246504) modified NetworkProcess::allowsFirstPartyForCookies. It's suspicious. 1911181 1 fujii 2022-11-08 23:05:20 -0800 This seems a race condition between UI process sending Messages::NetworkProcess::AddAllowedFirstPartyForCookies and web process requesting a request. 1911182 2 fujii 2022-11-08 23:21:22 -0800 In debug build, the network process will crash. However, in release build, it terminates the web process. I'm observing the web process termination in WinCairo Release http layout tests. This is a critical regression. We should disable allowsFirstPartyForCookies check soon until the problem solved. 1911183 3 463464 fujii 2022-11-08 23:51:36 -0800 Created attachment 463464 Patch 1911233 4 fujii 2022-11-09 04:03:00 -0800 Bug 247582 is going to fix the bug. 1911459 5 fujii 2022-11-09 20:57:32 -0800 *** This bug has been marked as a duplicate of bug 247582 *** 463464 2022-11-08 23:51:36 -0800 2022-11-09 04:03:29 -0800 Patch bug-247658-20221109165135.patch text/plain 3782 fujii RnJvbSAxOTUyMzcyMjk0ZTcwMTkzNmYyYmRjOTgzMmIwN2JjNGQxNzk3NWFmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBIaXJvbm9yaSA8SGlyb25vcmkuRnVqaWlAc29ueS5j b20+CkRhdGU6IFdlZCwgOSBOb3YgMjAyMiAxNjozOToxOCArMDkwMApTdWJqZWN0OiBbUEFUQ0hd IERpc2FibGUgdGhlIGFsbG93c0ZpcnN0UGFydHlGb3JDb29raWVzIGNoZWNrIGluIHRoZSBuZXR3 b3JrCiBwcm9jZXNzIGZvciBub24tQ29jb2EgcG9ydHMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTI0NzY1OAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpCdWcj MjQ0MDY4IGNoYW5nZWQgdGhlIG5ldHdvcmsgcHJvY2VzcyB0byBjaGVjayB0aGUKZmlyc3RQYXJ0 eUZvckNvb2tpZXMgb2YgYSBuZXR3b3JrIHJlcXVlc3Qgd2FzIHZhbGlkLiBIb3dldmVyLCB0aGVy ZSBpcwphIHJhY2UgY29uZGl0aW9uIGJldHdlZW4gcmVjZWl2aW5nIEFkZEFsbG93ZWRGaXJzdFBh cnR5Rm9yQ29va2llcwptZXNzYWdlIGZyb20gdGhlIFVJIHByb2Nlc3MgYW5kIHJlY2VpdmluZyBh IG5ldHdvcmsgcmVxdWVzdCBmcm9tIHRoZQp3ZWIgcHJvY2Vzcy4gSWYgdGhlIHJlcXVlc3QgaXNu J3QgdmFsaWQsIGFuIGFzc2VydGlvbiBmYWlscyBpbiBkZWJ1ZwpidWlsZCwgd2ViIHByb2Nlc3Mg aXMgdGVybWluYXRlZCBpbiByZWxlYXNlIGJ1aWxkLiBUaGlzIGlzIGEgY3JpdGljYWwKcmVncmVz c2lvbi4gRGlzYWJsZWQgdGhlIGFsbG93c0ZpcnN0UGFydHlGb3JDb29raWVzIGNoZWNrIGZvcgpu b24tQ29jb2EgcG9ydHMgdGVtcG9yYXJpbHkgdW50aWwgdGhlIHByb2JsZW0gc29sdmVkLgoKKiBT b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNz LmNwcDoKKFdlYktpdDo6TmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OnNjaGVkdWxlUmVz b3VyY2VMb2FkKToKKiBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNz LmNwcDoKKFdlYktpdDo6TmV0d29ya1Byb2Nlc3M6OmFsbG93c0ZpcnN0UGFydHlGb3JDb29raWVz KToKLS0tCiAuLi4vV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQ cm9jZXNzLmNwcCB8IDQgLS0tLQogU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3Jr UHJvY2Vzcy5jcHAgICAgICAgICAgICAgfCA2ICsrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCA2IGlu c2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5jcHAgYi9Tb3VyY2Uv V2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcApp bmRleCAwOTQ5MDBjNTcxYzEuLmJjZDNmMDUzMTBkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5jcHAKKysrIGIv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vz cy5jcHAKQEAgLTU1MCwxMSArNTUwLDcgQEAgc3RkOjp1bmlxdWVfcHRyPFNlcnZpY2VXb3JrZXJG ZXRjaFRhc2s+IE5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjpjcmVhdGVGZXQKIAogdm9p ZCBOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6c2NoZWR1bGVSZXNvdXJjZUxvYWQoTmV0 d29ya1Jlc291cmNlTG9hZFBhcmFtZXRlcnMmJiBsb2FkUGFyYW1ldGVycywgc3RkOjpvcHRpb25h bDxOZXR3b3JrUmVzb3VyY2VMb2FkSWRlbnRpZmllcj4gZXhpc3RpbmdMb2FkZXJUb1Jlc3VtZSkK IHsKLSAgICAvLyBGSVhNRTogVGhpcyBzaG91bGRuJ3QgYmUgZGlmZmVyZW50IG9uIGRpZmZlcmVu dCBwbGF0Zm9ybXMuCi0gICAgLy8gSXQgbWF5IGJlIHJlbGF0ZWQgdG8gdGhlIGRpZmZlcmVuY2Ug aW4gbmV0d29ya1Byb2Nlc3NGb3JTZXNzaW9uLgotI2lmICFQTEFURk9STShHVEspICYmICFQTEFU Rk9STShXUEUpCiAgICAgTkVUV09SS19QUk9DRVNTX01FU1NBR0VfQ0hFQ0sobV9uZXR3b3JrUHJv Y2Vzcy0+YWxsb3dzRmlyc3RQYXJ0eUZvckNvb2tpZXMobV93ZWJQcm9jZXNzSWRlbnRpZmllciwg bG9hZFBhcmFtZXRlcnMucmVxdWVzdC5maXJzdFBhcnR5Rm9yQ29va2llcygpKSk7Ci0jZW5kaWYK IAogICAgIENPTk5FQ1RJT05fUkVMRUFTRV9MT0coTG9hZGluZywgInNjaGVkdWxlUmVzb3VyY2VM b2FkOiAocGFyZW50UElEPSVkLCBwYWdlUHJveHlJRD0lIiBQUkl1NjQgIiwgd2ViUGFnZUlEPSUi IFBSSXU2NCAiLCBmcmFtZUlEPSUiIFBSSXU2NCAiLCByZXNvdXJjZUlEPSUiIFBSSXU2NCAiLCBl eGlzdGluZ0xvYWRlclRvUmVzdW1lPSUiIFBSSXU2NCAiKSIsIGxvYWRQYXJhbWV0ZXJzLnBhcmVu dFBJRCwgbG9hZFBhcmFtZXRlcnMud2ViUGFnZVByb3h5SUQudG9VSW50NjQoKSwgbG9hZFBhcmFt ZXRlcnMud2ViUGFnZUlELnRvVUludDY0KCksIGxvYWRQYXJhbWV0ZXJzLndlYkZyYW1lSUQub2Jq ZWN0KCkudG9VSW50NjQoKSwgbG9hZFBhcmFtZXRlcnMuaWRlbnRpZmllci50b1VJbnQ2NCgpLCB2 YWx1ZU9yRGVmYXVsdChleGlzdGluZ0xvYWRlclRvUmVzdW1lKS50b1VJbnQ2NCgpKTsKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAg Yi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcAppbmRleCA4 N2UyM2UyOWVhYWIuLjNhNGQ3MDc0MjNlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3 b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3Jr UHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKQEAgLTQwNSw2ICs0MDUsNyBAQCBib29sIE5ldHdv cmtQcm9jZXNzOjphbGxvd3NGaXJzdFBhcnR5Rm9yQ29va2llcyhXZWJDb3JlOjpQcm9jZXNzSWRl bnRpZmllciBwcm9jZQogICAgIGlmIChmaXJzdFBhcnR5LmlzQWJvdXRCbGFuaygpKQogICAgICAg ICByZXR1cm4gdHJ1ZTsKIAorI2lmIFBMQVRGT1JNKENPQ09BKQogICAgIGF1dG8gaXRlcmF0b3Ig PSBtX2FsbG93ZWRGaXJzdFBhcnRpZXNGb3JDb29raWVzLmZpbmQocHJvY2Vzc0lkZW50aWZpZXIp OwogICAgIGlmIChpdGVyYXRvciA9PSBtX2FsbG93ZWRGaXJzdFBhcnRpZXNGb3JDb29raWVzLmVu ZCgpKSB7CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwpAQCAtNDIwLDYgKzQyMSwxMSBA QCBib29sIE5ldHdvcmtQcm9jZXNzOjphbGxvd3NGaXJzdFBhcnR5Rm9yQ29va2llcyhXZWJDb3Jl OjpQcm9jZXNzSWRlbnRpZmllciBwcm9jZQogICAgIGF1dG8gcmVzdWx0ID0gaXRlcmF0b3ItPnZh bHVlLmNvbnRhaW5zKGZpcnN0UGFydHlEb21haW4pOwogICAgIEFTU0VSVChyZXN1bHQpOwogICAg IHJldHVybiByZXN1bHQ7CisjZWxzZQorICAgIC8vIEZJWE1FOiBUaGVyZSBpcyBhIHJhY2UgY29u ZGl0aW9uIGJldHdlZW4gcmVjZWl2aW5nIEFkZEFsbG93ZWRGaXJzdFBhcnR5Rm9yQ29va2llcyBt ZXNzYWdlIGZyb20gdGhlIFVJIHByb2Nlc3MKKyAgICAvLyBhbmQgcmVjZWl2aW5nIGEgbmV0d29y ayByZXF1ZXN0IGZyb20gdGhlIHdlYiBwcm9jZXNzLgorICAgIHJldHVybiB0cnVlOworI2VuZGlm CiB9CiAKIHZvaWQgTmV0d29ya1Byb2Nlc3M6OmNsZWFyQ2FjaGVkQ3JlZGVudGlhbHMoUEFMOjpT ZXNzaW9uSUQgc2Vzc2lvbklEKQo=