247581 2022-11-07 13:03:57 -0800 Improve clarity of cryptographically random number functions 2022-11-10 16:32:09 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=247471 https://bugs.webkit.org/show_bug.cgi?id=247756 InRadar P2 Normal --- 247758 1 darin darin commit-queue don.olmstead webkit-bug-importer oldest_to_newest 1910854 0 darin 2022-11-07 13:03:57 -0800 1) Change the 3 callers of cryptographicallyRandomUint32 to use cryptographicallyRandomNumber instead. 2) Remove cryptographicallyRandomUint32. 3) Move cryptographicallyRandomUint64 to CryptographicallyRandomNumber.h 4) Move cryptographicallyRandomUnitInterval to CryptographicallyRandomNumber.h. 5) Rename cryptographicallyRandomUint64 to cryptographicallyRandomUInt64 or cryptographicallyRandom<uint64_t>. 6) Consider renaming cryptographicallyRandomNumber to cryptographicallyRandomUInt32 or cryptographicallyRandom<uint32_t>. 7) Consider renaming weakRandom to weakRandomUInt32 or weakRandom<uint32_t>. 8) Consider renaming RandomNumber.h to WeakRandomNumber.h. 9) Document that cryptographicallyRandomUnitInterval has only 32 bits of randomness in it to further discourage uninformed use of it. 1910865 1 webkit-bug-importer 2022-11-07 13:39:08 -0800 <rdar://problem/102057413> 1910909 2 darin 2022-11-07 15:50:17 -0800 Pull request: https://github.com/WebKit/WebKit/pull/6227 1911323 3 ews-feeder 2022-11-09 11:42:13 -0800 Committed 256493@main (017574a4e19b): <https://commits.webkit.org/256493@main> Reviewed commits have been landed. Closing PR #6227 and removing active labels. 1911638 4 commit-queue 2022-11-10 13:33:16 -0800 Re-opened since this is blocked by bug 247758 1911646 5 ryanhaddad 2022-11-10 13:39:14 -0800 Reverted because this caused API test crashes on iOS simulator. Details in https://bugs.webkit.org/show_bug.cgi?id=247756 1911662 6 darin 2022-11-10 14:32:17 -0800 I’ll re-land this with a stub that keeps the iOS simulator working. 1911668 7 darin 2022-11-10 14:40:25 -0800 Pull request: https://github.com/WebKit/WebKit/pull/6366 1911705 8 ews-feeder 2022-11-10 16:32:06 -0800 Committed 256555@main (08e4dc175b88): <https://commits.webkit.org/256555@main> Reviewed commits have been landed. Closing PR #6366 and removing active labels.