247514 2022-11-04 17:51:05 -0700 Fix MaxCoefficient static variable value in Decimal.cpp 2024-01-23 16:52:16 -0800 1 1 1 Unclassified WebKit New Bugs Safari Technology Preview Unspecified Unspecified RESOLVED DUPLICATE 248784 https://bugs.webkit.org/show_bug.cgi?id=248784 InRadar P2 Normal --- 1 ahmad.saleem792 webkit-unassigned ap bfulgham cdumez webkit-bug-importer oldest_to_newest 1910474 0 ahmad.saleem792 2022-11-04 17:51:05 -0700 Hi Team, Just going through Blink Commits, came across following commit: Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=174294 and Webkit is still using wrong one, I think matching would be fine rather than updating comment to reflect current value. https://github.com/WebKit/WebKit/blob/06829a72816b3507674af7be8a740a4964ae3518/Source/WebCore/platform/Decimal.cpp#L51 I am just creating this bug to do PR and merge above commit. Let me know if someone want me to just update comment. Thanks! 1911290 1 ap 2022-11-09 10:09:43 -0800 ch.dumez@samsung.com! Sadly, no test modified in the commit. 1911299 2 ahmad.saleem792 2022-11-09 10:32:37 -0800 (In reply to Alexey Proskuryakov from comment #1) > ch.dumez@samsung.com! Sadly, no test modified in the commit. https://github.com/WebKit/WebKit/pull/6160 1911300 3 ahmad.saleem792 2022-11-09 10:33:50 -0800 (In reply to Ahmad Saleem from comment #2) > (In reply to Alexey Proskuryakov from comment #1) > > ch.dumez@samsung.com! Sadly, no test modified in the commit. > > https://github.com/WebKit/WebKit/pull/6160 Latest position is that whether there is std:decimal to replace our use case or whether we just add 'DecmialTest.cpp' API for testing similar to Chrome. 1911316 4 cdumez 2022-11-09 10:56:39 -0800 (In reply to Alexey Proskuryakov from comment #1) > ch.dumez@samsung.com! Sadly, no test modified in the commit. There were tests modified in MY commit :) 1911932 5 webkit-bug-importer 2022-11-11 16:52:17 -0800 <rdar://problem/102261978> 1920790 6 ahmad.saleem792 2022-12-20 08:41:30 -0800 Will fix via https://github.com/WebKit/WebKit/pull/7908 in one go with test-case as well. 2007066 7 bfulgham 2024-01-23 16:52:16 -0800 *** This bug has been marked as a duplicate of bug 248784 ***