247498 2022-11-04 12:27:18 -0700 StyleProperties::fontValue needs to return emptyString in many more cases where font sub properties have unusual values 2022-11-14 01:27:55 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=247810 https://bugs.webkit.org/show_bug.cgi?id=217625 https://bugs.webkit.org/show_bug.cgi?id=87129 InRadar P2 Normal --- 1 darin darin darin mmaxfield ntim obrufau webkit-bug-importer oldest_to_newest 1910400 0 darin 2022-11-04 12:27:18 -0700 StyleProperties::fontValue needs to return emptyString in many more cases where font subproperties have values other than their initial values. We already do this in the fontShorthandValue function for computed style, but we need it for specified style too. 1910401 1 darin 2022-11-04 12:27:39 -0700 A significant part of the work here is to add test cases, preferably WPT tests. 1910538 2 darin 2022-11-05 09:56:33 -0700 I’m not actually sure what the desired behavior is here. I might need someone’s help to write the tests before changing any of the code. Tim, what do you think? 1911869 3 webkit-bug-importer 2022-11-11 11:28:23 -0800 <rdar://problem/102248342> 1911964 4 ntim 2022-11-11 22:18:06 -0800 > I’m not actually sure what the desired behavior is here. https://github.com/w3c/csswg-drafts/issues/8062 The font shorthand serialization should be empty when the subproperties are not representable by the shorthand. We seem to have similar issues with other props too, see bug 247810 1911985 5 darin 2022-11-12 07:54:29 -0800 I am working on a patch for this right now. Tim, hope you weren’t already working on it. 1911986 6 darin 2022-11-12 07:55:40 -0800 The part I was not clear on was the "implicit" flag bit. 1911998 7 darin 2022-11-12 09:21:21 -0800 Pull request: https://github.com/WebKit/WebKit/pull/6426 1912198 8 ews-feeder 2022-11-13 23:53:58 -0800 Committed 256635@main (d3d6e16bf1f0): <https://commits.webkit.org/256635@main> Reviewed commits have been landed. Closing PR #6426 and removing active labels. 1912225 9 ntim 2022-11-14 01:27:55 -0800 *** Bug 169259 has been marked as a duplicate of this bug. ***