<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>247364</bug_id>
          
          <creation_ts>2022-11-02 08:06:14 -0700</creation_ts>
          <short_desc>Remove CSSKeyframesRule.insertRule()</short_desc>
          <delta_ts>2022-12-30 03:16:06 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=57910</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>BrowserCompat, InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ahmad Saleem">ahmad.saleem792</reporter>
          <assigned_to name="Karl Dubost">karlcow</assigned_to>
          <cc>dino</cc>
    
    <cc>karlcow</cc>
    
    <cc>ntim</cc>
    
    <cc>rbuis</cc>
    
    <cc>sabouhallawa</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1909780</commentid>
    <comment_count>0</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2022-11-02 08:06:14 -0700</bug_when>
    <thetext>Hi Team,

I couldn&apos;t find bug so I am creating this to alias &quot;insertRule&quot; as &quot;append&quot; or remove since it was removed in Blink (2015) and was never supported by Gecko &amp; Internet Explorer 11.

Web-Spec - https://drafts.csswg.org/css-animations/#interface-csskeyframesrule

Blink commit for aliasing - https://src.chromium.org/viewvc/blink?view=revision&amp;revision=194122
Blink commit for removing - https://src.chromium.org/viewvc/blink?view=revision&amp;revision=195797

Current IDL file - https://github.com/WebKit/WebKit/blob/1a4522de8a5d226a336c85237dd15144174fadfc/Source/WebCore/css/CSSKeyframesRule.idl#L35

It shows that we still support this.

Just wanted to create a bug for future purposes to remove this and align with Web-Specs.

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1909850</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2022-11-02 13:59:44 -0700</bug_when>
    <thetext>We intentionally kept it in bug 57910, but perhaps it&apos;s less relevant now. Could be difficult to confirm.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1910292</commentid>
    <comment_count>2</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2022-11-04 00:21:40 -0700</bug_when>
    <thetext>Intent to Remove for Blink in 2015
https://groups.google.com/a/chromium.org/g/blink-dev/c/wW7w8Hro78s/m/JDULF2oM9iIJ

Changed in Gecko in 2013
https://bugzilla.mozilla.org/show_bug.cgi?id=841896</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1910293</commentid>
    <comment_count>3</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2022-11-04 00:24:25 -0700</bug_when>
    <thetext>Also has a finger in the wind evaluation.
https://cs.github.com/?scopeName=All+repos&amp;scope=&amp;q=CSSKeyframesRule.insertRule+language%3AJavaScript

0 match on GitHub code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1911247</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-11-09 07:07:17 -0800</bug_when>
    <thetext>&lt;rdar://problem/102141002&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1922062</commentid>
    <comment_count>5</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2022-12-27 22:55:22 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/8084</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1922275</commentid>
    <comment_count>6</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-12-30 03:16:04 -0800</bug_when>
    <thetext>Committed 258361@main (c26a65e62e39): &lt;https://commits.webkit.org/258361@main&gt;

Reviewed commits have been landed. Closing PR #8084 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>