24735 2009-03-20 20:35:29 -0700 Poor setDragImage support on Windows 2009-07-24 17:08:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Windows Vista RESOLVED FIXED P2 Normal --- 1 sebastian jberlin aroben jberlin oliver oldest_to_newest 114623 0 sebastian 2009-03-20 20:35:29 -0700 At the start of a drag operation you can use event.dataTransfer.setDragImage(...) to change the graphic to display by the cursor during the operation. On Mac this is supported for both images and elements. On Windows Safari has support for only images as the first parameter of setDragImage. It is not supported on <a> and <img> tags that has their own implementations that can't be overridden. Google Chrome has the function but no graphics shows up around the cursor for any drag operation. All versions should behave like the Mac version. 127786 1 jberlin 2009-06-23 18:45:11 -0700 <rdar://problem/5015942> 127789 2 jberlin 2009-06-23 18:47:10 -0700 *** Bug 24734 has been marked as a duplicate of this bug. *** 127918 3 31785 jberlin 2009-06-24 08:52:52 -0700 Created attachment 31785 Adds the ability to set an element as the drag image on Windows Does not fix the case of dragging a link where the default link image is still used, even when the -webkit-user-drag is set to "element". This is the same behavior as is found on OS X. 127926 4 31785 aroben 2009-06-24 09:45:53 -0700 Comment on attachment 31785 Adds the ability to set an element as the drag image on Windows > DragImageRef ClipboardWin::createDragImage(IntPoint& loc) const > { > HBITMAP result = 0; > - //FIXME: Need to be able to draw element <rdar://problem/5015942> > if (m_dragImage) { > result = createDragImageFromImage(m_dragImage->image()); > loc = m_dragLoc; > + } else if (m_dragImageElement) { > + Node* node = dragImageElement(); > + result = node->document()->frame()->nodeImage(node); > + loc = m_dragLoc; > } It's strange to use m_dragImageElement on the first line, then dragImageElement() on the second. I don't really have a preference, but using m_dragImageElement consistently would match the code above more closely. r=me 127935 5 jberlin 2009-06-24 10:04:34 -0700 (In reply to comment #4) > (From update of attachment 31785 [review]) > > DragImageRef ClipboardWin::createDragImage(IntPoint& loc) const > > { > > HBITMAP result = 0; > > - //FIXME: Need to be able to draw element <rdar://problem/5015942> > > if (m_dragImage) { > > result = createDragImageFromImage(m_dragImage->image()); > > loc = m_dragLoc; > > + } else if (m_dragImageElement) { > > + Node* node = dragImageElement(); changed to be: Node* node = m_dragImageElement.get(); > > + result = node->document()->frame()->nodeImage(node); > > + loc = m_dragLoc; > > } > > It's strange to use m_dragImageElement on the first line, then > dragImageElement() on the second. I don't really have a preference, but using > m_dragImageElement consistently would match the code above more closely. > > r=me > 128436 6 eric 2009-06-26 01:37:28 -0700 Does jberlin have commit-bit or does aroben plan to land this with modifications? 128483 7 aroben 2009-06-26 08:38:36 -0700 (In reply to comment #6) > Does jberlin have commit-bit Yes. <http://trac.webkit.org/search?q=jberlin&noquickjump=1&changeset=on> 128485 8 jberlin 2009-06-26 08:47:04 -0700 (In reply to comment #6) > Does jberlin have commit-bit or does aroben plan to land this with > modifications? > I did commit, but I didn't mark it as fixed because the bug mentions the desire to see the link tag be able to be given a custom setDragImage and that is currently not supported on either mac or windows. Sorry I didn't respond earlier. For some reason I kept getting an "internal error" message when I navigated to this page. 128489 9 31785 jberlin 2009-06-26 09:09:51 -0700 Comment on attachment 31785 Adds the ability to set an element as the drag image on Windows committed with revision 45087 134686 10 jberlin 2009-07-24 17:08:00 -0700 Created a new bug for not being able to set the drag image of a link: https://bugs.webkit.org/show_bug.cgi?id=27670 Marking this bug as fixed, since the last committed patch addressed all other concerns. 31785 2009-06-24 08:52:52 -0700 2009-06-26 09:09:51 -0700 Adds the ability to set an element as the drag image on Windows addSetDragImageToElementForWindows.txt text/plain 5235 jberlin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTA4MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjcgQEAKKzIwMDktMDYtMjQgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQ YXJ0aWFsbHkgZml4ZXM6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y NDczNQorICAgICAgICAoPHJkYXI6Ly9wcm9ibGVtLzUwMTU5NDI+KQorICAgICAgICBXaGVyZSBv biB3aW5kb3dzIGl0IHdhcyBub3QgcG9zc2libGUgdG8gc2V0IGFuIGVsZW1lbnQgYXMgdGhlIGRy YWcKKyAgICAgICAgaW1hZ2UgdXNpbmcgc2V0RHJhZ0ltYWdlIG9uIHRoZSBkYXRhVHJhbnNmZXIg b2JqZWN0LgorICAgICAgICAKKyAgICAgICAgRG9lcyBub3QgImZpeCIgdGhlIGNhc2Ugb2YgZHJh Z2dpbmcgYSBsaW5rIHdoZXJlIHRoZSBkZWZhdWx0IGxpbmsgaW1hZ2UKKyAgICAgICAgaXMgc3Rp bGwgdXNlZCwgZXZlbiB3aGVuIHRoZSAtd2Via2l0LXVzZXItZHJhZyBpcyBzZXQgdG8gImVsZW1l bnQiLiBUaGlzCisgICAgICAgIGlzIHRoZSBzYW1lIGJlaGF2aW9yIGFzIGlzIGZvdW5kIG9uIE9T IFguCisgICAgICAgIAorICAgICAgICBBZGRlZCBhIG1hbnVhbCB0ZXN0IGJlY2F1c2UgaXQgaXMg bm90IHBvc3NpYmxlIHRvIGNoZWNrIHRoYXQgd2hhdCBpcworICAgICAgICBjb250YWluZWQgaW4g dGhlIGltYWdlIHNuYXBzaG90IGlzIGluZGVlZCB0aGUgcmVxdWVzdGVkIGVsZW1lbnQuCisKKyAg ICAgICAgKiBkb20vQ2xpcGJvYXJkLmg6CisgICAgICAgIChXZWJDb3JlOjpDbGlwYm9hcmQ6OmRy YWdJbWFnZUVsZW1lbnQpOgorICAgICAgICBNYWRlIGdldHRpbmcgdGhlIHJhdyBwb2ludGVyIGZy b20gdGhlIFJlZlB0ciBhIGNvbnN0IG9wZXJhdGlvbi4KKyAgICAgICAgKiBtYW51YWwtdGVzdHMv ZHJhZy13aXRoLWRpdi1vci1pbWFnZS1hcy1kYXRhLWltYWdlLmh0bWw6IEFkZGVkLgorICAgICAg ICAqIHBsYXRmb3JtL3dpbi9DbGlwYm9hcmRXaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2xp cGJvYXJkV2luOjpjcmVhdGVEcmFnSW1hZ2UpOgorICAgICAgICBHZXQgYW4gaW1hZ2Ugb2YgdGhl IHJlbmRlcmVkIGVsZW1lbnQgYW5kIGl0cyBzdWJ0cmVlLgorCiAyMDA5LTA2LTI0ICBOaWtvbGFz IFppbW1lcm1hbm4gIDxuaWtvbGFzLnppbW1lcm1hbm5AdG9yY2htb2JpbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCkluZGV4OiBXZWJDb3JlL2RvbS9DbGlwYm9hcmQu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9DbGlwYm9hcmQuaAkocmV2aXNpb24gNDUwODAp CisrKyBXZWJDb3JlL2RvbS9DbGlwYm9hcmQuaAkod29ya2luZyBjb3B5KQpAQCAtNTcsNyArNTcs NyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIEludFBvaW50IGRyYWdMb2NhdGlvbigp IGNvbnN0IHsgcmV0dXJuIG1fZHJhZ0xvYzsgfQogICAgICAgICBDYWNoZWRJbWFnZSogZHJhZ0lt YWdlKCkgY29uc3QgeyByZXR1cm4gbV9kcmFnSW1hZ2UuZ2V0KCk7IH0KICAgICAgICAgdmlydHVh bCB2b2lkIHNldERyYWdJbWFnZShDYWNoZWRJbWFnZSosIGNvbnN0IEludFBvaW50JikgPSAwOwot ICAgICAgICBOb2RlKiBkcmFnSW1hZ2VFbGVtZW50KCkgeyByZXR1cm4gbV9kcmFnSW1hZ2VFbGVt ZW50LmdldCgpOyB9CisgICAgICAgIE5vZGUqIGRyYWdJbWFnZUVsZW1lbnQoKSBjb25zdCB7IHJl dHVybiBtX2RyYWdJbWFnZUVsZW1lbnQuZ2V0KCk7IH0KICAgICAgICAgdmlydHVhbCB2b2lkIHNl dERyYWdJbWFnZUVsZW1lbnQoTm9kZSosIGNvbnN0IEludFBvaW50JikgPSAwOwogICAgICAgICAK ICAgICAgICAgdmlydHVhbCBEcmFnSW1hZ2VSZWYgY3JlYXRlRHJhZ0ltYWdlKEludFBvaW50JiBk cmFnTG9jYXRpb24pIGNvbnN0ID0gMDsKSW5kZXg6IFdlYkNvcmUvbWFudWFsLXRlc3RzL2RyYWct d2l0aC1kaXYtb3ItaW1hZ2UtYXMtZGF0YS1pbWFnZS5odG1sCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvbWFudWFsLXRlc3RzL2RyYWctd2l0aC1kaXYtb3ItaW1hZ2UtYXMtZGF0YS1pbWFnZS5odG1s CShyZXZpc2lvbiAwKQorKysgV2ViQ29yZS9tYW51YWwtdGVzdHMvZHJhZy13aXRoLWRpdi1vci1p bWFnZS1hcy1kYXRhLWltYWdlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNTUgQEAKKzxo dG1sPgorICAgIDxoZWFkPgorICAgICAgICA8dGl0bGU+VGVzdCBmb3IgV2ViS2l0IGJ1ZyAyNDcz NTogUG9vciBzZXREcmFnSW1hZ2Ugc3VwcG9ydCBvbiBXaW5kb3dzPC90aXRsZT4KKyAgICAgICAg PHN0eWxlIHR5cGU9InRleHQvY3NzIj4KKworICAgICAgICAgICAgLmRyYWdnYWJsZSB7CisgICAg ICAgICAgICAgICAgLXdlYmtpdC11c2VyLWRyYWc6IGVsZW1lbnQ7CisgICAgICAgICAgICAgICAg LXdlYmtpdC11c2VyLXNlbGVjdDogbm9uZTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIAor ICAgICAgICAgICAgI2xpbmtUb1VzZUFzSW1hZ2UgeworICAgICAgICAgICAgICAgIGJhY2tncm91 bmQtY29sb3I6IHNpbHZlcjsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIAorICAgICAgICAg ICAgI2RpdlRvVXNlQXNJbWFnZSB7CisgICAgICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjog cGluazsKKyAgICAgICAgICAgIH0KKworICAgICAgICA8L3N0eWxlPgorCisgICAgICAgIDxzY3Jp cHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KKyAgICAgICAgICAgIGZ1bmN0aW9uIGRyYWdEaXZB bmRTZWVJbWFnZURyYWdnZWQoKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIGV2ZW50 LmRhdGFUcmFuc2Zlci5zZXREcmFnSW1hZ2UoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImltZ1Rv VXNlQXNJbWFnZSIpLCBldmVudC5wYWdlWCwgZXZlbnQucGFnZVkpOworICAgICAgICAgICAgfQor ICAgICAgICAgICAgCisgICAgICAgICAgICBmdW5jdGlvbiBkcmFnSW1hZ2VBbmRTZWVEaXZEcmFn Z2VkKCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBldmVudC5kYXRhVHJhbnNmZXIu c2V0RHJhZ0ltYWdlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJkaXZUb1VzZUFzSW1hZ2UiKSwg ZXZlbnQucGFnZVgsIGV2ZW50LnBhZ2VZKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgPC9zY3Jp cHQ+CisgICAgPC9oZWFkPgorICAgIDxib2R5ID4KKyAgICAgICAgPGgzPlRlc3QgZm9yIDxhIGhy ZWY9J2h0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDczNSc+V2ViS2l0 IGJ1ZyAyNDczNTwvYT46IFBvb3Igc2V0RHJhZ0ltYWdlIHN1cHBvcnQgb24gV2luZG93czwvaDM+ CisKKyAgICAgICAgPHA+SW5zdHJ1Y3Rpb25zOiA8L3A+CisgICAgICAgIDxwPldoZW4geW91IGRy YWcgdGhlIGZpcnN0IGRpdiwgdGhlIGltYWdlIHVuZGVyIHRoZSBjdXJzb3Igc2hvdWxkIGJlIG9m IHRoZSBzZWNvbmQgaW1hZ2UuIDwvcD4KKyAgICAgICAgPHA+V2hlbiB5b3UgZHJhZyB0aGUgZmly c3QgaW1hZ2UsIHRoZSBpbWFnZSB1bmRlciB0aGUgY3Vyc29yIHNob3VsZCBiZSBvZiB0aGUgc2Vj b25kIGRpdi4gPC9wPgorICAgICAgICAKKyAgICAgICAgPGJyIC8+CisgICAgICAgIDxiciAvPgor ICAgICAgICAKKyAgICAgICAgPGRpdiBjbGFzcz0iZHJhZ2dhYmxlIiBvbmRyYWdzdGFydD0iZHJh Z0RpdkFuZFNlZUltYWdlRHJhZ2dlZCgpIj4gRHJhZyBtZSwgSSBhbSBhIGRpdiEgKGZpcnN0IGRp dik8L2Rpdj4NCisgICAgICAgIDxiciAvPg0KKyAgICAgICAgPGJyIC8+DQorICAgICAgICA8aW1n IHNyYz0icmVzb3VyY2VzL3dlYmtpdC1iYWNrZ3JvdW5kLnBuZyIgY2xhc3M9ImRyYWdnYWJsZSIg b25kcmFnc3RhcnQ9ImRyYWdJbWFnZUFuZFNlZURpdkRyYWdnZWQoKSIgLz4NCisgICAgICAgIDxi ciAvPg0KKyAgICAgICAgPGJyIC8+DQorICAgICAgICA8aW1nIHNyYz0icmVzb3VyY2VzL2RyYWct aW1hZ2UucG5nIiBpZD0iaW1nVG9Vc2VBc0ltYWdlIiAvPg0KKyAgICAgICAgPGJyIC8+DQorICAg ICAgICA8YnIgLz4NCisgICAgICAgIDxkaXYgaWQ9ImRpdlRvVXNlQXNJbWFnZSI+IFdoZW4gYSBk cmFnIGlzIHN0YXJ0ZWQgb24gdGhlIGltYWdlLCB0aGlzIGlzIHRoZSBkaXYgdGhhdCBpcyB1c2Vk IGFzIHRoZSBkcmFnIGltYWdlISAoc2Vjb25kIGRpdik8L2Rpdj4NCisgICAgCisgICAgPC9ib2R5 PgorPC9odG1sPgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ2xpcGJvYXJkV2luLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL3dpbi9DbGlwYm9hcmRXaW4uY3BwCShyZXZp c2lvbiA0NTA4MCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vd2luL0NsaXBib2FyZFdpbi5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTYwOCwxMCArNjA4LDEzIEBAIHZvaWQgQ2xpcGJvYXJkV2luOjpzZXRE cmFnSW1hZ2VFbGVtZW50KE4KIERyYWdJbWFnZVJlZiBDbGlwYm9hcmRXaW46OmNyZWF0ZURyYWdJ bWFnZShJbnRQb2ludCYgbG9jKSBjb25zdAogewogICAgIEhCSVRNQVAgcmVzdWx0ID0gMDsKLSAg ICAvL0ZJWE1FOiBOZWVkIHRvIGJlIGFibGUgdG8gZHJhdyBlbGVtZW50IDxyZGFyOi8vcHJvYmxl bS81MDE1OTQyPgogICAgIGlmIChtX2RyYWdJbWFnZSkgewogICAgICAgICByZXN1bHQgPSBjcmVh dGVEcmFnSW1hZ2VGcm9tSW1hZ2UobV9kcmFnSW1hZ2UtPmltYWdlKCkpOyAgICAgICAgCiAgICAg ICAgIGxvYyA9IG1fZHJhZ0xvYzsKKyAgICB9IGVsc2UgaWYgKG1fZHJhZ0ltYWdlRWxlbWVudCkg eworICAgICAgICBOb2RlKiBub2RlID0gZHJhZ0ltYWdlRWxlbWVudCgpOworICAgICAgICByZXN1 bHQgPSBub2RlLT5kb2N1bWVudCgpLT5mcmFtZSgpLT5ub2RlSW1hZ2Uobm9kZSk7CisgICAgICAg IGxvYyA9IG1fZHJhZ0xvYzsKICAgICB9CiAgICAgcmV0dXJuIHJlc3VsdDsKIH0K