247313 2022-11-01 05:08:02 -0700 Code style does not allow currently used member function explanation comments for vfuncs, ipc messages 2022-11-02 02:29:13 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kkinnunen kkinnunen cdumez rniwa webkit-bug-importer oldest_to_newest 1909528 0 kkinnunen 2022-11-01 05:08:02 -0700 Code style does not allow currently used member function explanation comments for vfuncs, ipc messages Current style defines that comments must be English sentences. Currently code uses: class GPUProcessConnection : public RefCounted<GPUProcessConnection>, public IPC::Connection::Client { public: /// ... // IPC::Connection::Client void didClose(IPC::Connection&) override; // ... }; When trying to solve this by using: // IPC::Connection::Client overrides. .. then some reviewer complains. When trying to solve this by using: // IPC::Connection::Client .. then another reviewer complains. It is not good that review results of seemingly deterministic rule-based system depends on personal preferences of who happens to review the patch. This causes non-deterministic churn during reviews. The code style could define this case so that there would be no need for personal preferences. 1909529 1 webkit-bug-importer 2022-11-01 05:08:57 -0700 <rdar://problem/101801434> 1909530 2 kkinnunen 2022-11-01 05:10:10 -0700 Pull request: https://github.com/WebKit/WebKit/pull/5996 1909739 3 ews-feeder 2022-11-02 02:29:10 -0700 Committed 256221@main (09420100638c): <https://commits.webkit.org/256221@main> Reviewed commits have been landed. Closing PR #5996 and removing active labels.