247206 2022-10-28 11:28:20 -0700 [GLib] Improvements for generate-api-header.py 2022-11-07 07:23:03 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 210100 1 mcatanzaro mcatanzaro bugs-noreply mcatanzaro oldest_to_newest 1909052 0 mcatanzaro 2022-10-28 11:28:20 -0700 generate-api-header.py has worked well enough so far, but there are a few problems: * It cannot expand USE(2022_GLIB_API) because its regex cannot handle underscores, and only handles flag names where all alphabetical characters occur before all numeric characters. The regex should be more permissive * It expands USE(FOO) to WTF_USE_FOO, but only HAVE(FOO) flags should receive the WTF_ prefix * It doesn't handle ENABLE_ at all * It translates FOO(BAR) to FOO_BAR, but we really want it to be translated to "defined(FOO_BAR) && FOO_BAR" because unifdef will ignore any directive that it cannot fully evaluate, leaving unwanted guards in the generated headers. 1909210 1 mcatanzaro 2022-10-30 06:26:11 -0700 (In reply to Michael Catanzaro from comment #0) > * It expands USE(FOO) to WTF_USE_FOO, but only HAVE(FOO) flags should > receive the WTF_ prefix This actually doesn't matter, since we control exactly which defines get passed to unifdef, and unifdef is supposed to remove them all. Since our normal build flags are not used, there is no requirement to expand things exactly the same way that the rest of the build would. 1909213 2 mcatanzaro 2022-10-30 06:59:09 -0700 Pull request: https://github.com/WebKit/WebKit/pull/5943 1910773 3 ews-feeder 2022-11-07 07:23:00 -0800 Committed 256403@main (40b3dbe8a327): <https://commits.webkit.org/256403@main> Reviewed commits have been landed. Closing PR #5943 and removing active labels.