247149 2022-10-27 13:52:43 -0700 WebSocket: Allow relative URLs and http(s) scheme 2023-08-14 06:54:18 -0700 1 1 1 Unclassified WebKit DOM Other All All RESOLVED FIXED InRadar P2 Normal --- 1 me annevk achristensen m.kurz+webkitbugs webkit-bug-importer youennf oldest_to_newest 1908823 0 me 2022-10-27 13:52:43 -0700 See: https://github.com/whatwg/websockets/pull/37 & https://github.com/whatwg/websockets/issues/20 WIP patch: https://github.com/WebKit/WebKit/pull/5875 1910173 1 webkit-bug-importer 2022-11-03 13:53:19 -0700 <rdar://problem/101929623> 1910424 2 achristensen 2022-11-04 14:05:47 -0700 This is significantly different than Firefox's approach. I think Anne's comment "If we accept HTTP(S) schemes though we probably first want to normalize them to ws/wss, for the sake of consistency with the existing url getter" is interesting and should be considered. Tests need updating. 1910430 3 me 2022-11-04 14:24:19 -0700 (In reply to Alex Christensen from comment #2) > This is significantly different than Firefox's approach. > > I think Anne's comment "If we accept HTTP(S) schemes though we probably > first want to normalize them to ws/wss, for the sake of consistency with the > existing url getter" is interesting and should be considered. > > Tests need updating. I tested both against the same site and they behaved as expected, although slight deviations may exist? I have a pr against WPT which should help with ensuring things are working as expected. I don't know the exact processes but once that is merged I'll need help rolling wpt so this patch can be tested properly. I thought it made more sense for the url getter to reflect the url that was passed in so it is not normalized. Do you feel strongly that it should be? 1954658 4 annevk 2023-05-11 03:07:30 -0700 Pull request: https://github.com/WebKit/WebKit/pull/13751 1954708 5 ews-feeder 2023-05-11 08:16:05 -0700 Committed 263968@main (b5e7897d6636): <https://commits.webkit.org/263968@main> Reviewed commits have been landed. Closing PR #13751 and removing active labels.