24711 2009-03-19 19:48:20 -0700 1.95.toFixed(1) should equal "1.9" but does not 2010-08-27 12:56:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED DUPLICATE 44745 javascript: alert(1.95.toFixed(1) === "2.0" ? "FAIL" : "PASS") HasReduction, InRadar P2 Normal --- 1 jwalden+bwo webkit-unassigned apeller barraclough brendan bugzilla33 emacemac7 gavin.sharp mrbkap zwarich oldest_to_newest 114435 0 jwalden+bwo 2009-03-19 19:48:20 -0700 https://bugzilla.mozilla.org/show_bug.cgi?id=484293 This is reproducible in Safari 4 beta on 10.4 (r41760) and on Windows XP (just 4b). May you have as much pleasure dealing with this as I did in (incorrectly) checking SpiderMonkey's behavior, because it would be the height of unfairness for me to hog all the fun. :-) 114448 1 mrowe 2009-03-19 23:33:49 -0700 <rdar://problem/6702946> 114453 2 zwarich 2009-03-20 01:10:09 -0700 I don't understand why 1.9 is the correct value. The ECMA spec gives an algorithm for toFixed in 15.7.4.5. This algorithm is copied almost literally by the implementation in JavaScriptCore. I'll double check this case by hand. 114454 3 jwalden+bwo 2009-03-20 01:18:11 -0700 Cameron, see the Mozilla bug, it's all calculated by hand there -- just the problem of a flipped equality. But if you do feel like running it out by hand, by all means feel free, because you'll get an even better idea of how much fun can be had here. 114459 4 ap 2009-03-20 01:22:34 -0700 See also: bug 16651, bug 16653. 114471 5 zwarich 2009-03-20 02:23:51 -0700 Okay, I see our mistake. This will be a bit of work to fix. There may be similar problems in other places. 165698 6 bugzilla33 2009-11-22 01:06:45 -0800 toFixed rounds, not floors ! bug 24711 is not a Bug !! (1.95) . toFixed( 1 ) = 2.0 because: Math.round ( 1.95 * 10 ) / 10 equal 2 165700 7 bugzilla33 2009-11-22 01:16:04 -0800 Not a Bug. All browsers before returns string value (IE, Opera, Konqueror, Chrome, Firefox) rounding a Number to defined scale. 270672 8 barraclough 2010-08-27 12:48:23 -0700 For a simpler explanation of why this is a valid bug, try: javascript:alert((1.95).toPrecision(21)) (but! this also doesn't work in ToT!) - the correct result should be 1.94999999999999995559. Since the precise mathematical value passed to toFixed is closer to 1.9 than 2.0, 1.9 is the correct result. This should be fixed by https://bugs.webkit.org/show_bug.cgi?id=44745 *** This bug has been marked as a duplicate of bug 44745 *** 270679 9 barraclough 2010-08-27 12:56:54 -0700 *** Bug 31777 has been marked as a duplicate of this bug. ***