24705 2009-03-19 16:26:52 -0700 Can't set location.href in chromium 2009-03-20 16:57:51 -0700 1 1 1 Unclassified WebKit WebCore Misc. 525.x (Safari 3.2) PC All RESOLVED FIXED P2 Normal --- 1 davemoore levin sam oldest_to_newest 114403 0 davemoore 2009-03-19 16:26:52 -0700 A bug in the V8 bindings is preventing chromium from setting the href on the location object...any attempt throws a security error, not just for javascript protocols. See chromium bug http://code.google.com/p/chromium/issues/detail?id=8603 114404 1 28770 davemoore 2009-03-19 16:30:28 -0700 Created attachment 28770 Patch 114497 2 dglazkov 2009-03-20 09:17:08 -0700 Dave, can we possibly prefix this with V8, so that it's clear that this is a V8-specific modification. Also, I want to make sure Sam is ok with this. Adding him to cc. 114501 3 davemoore 2009-03-20 09:26:13 -0700 I had it that way at one point, but Mike felt that it was better to do it without #ifdef'ing it 114539 4 sam 2009-03-20 12:44:12 -0700 Seems fine to me. The CustomSetter clearly overrides this for JSC. 114555 5 dglazkov 2009-03-20 14:28:09 -0700 Gah. I didn't realize I wasn't on cc list. 114579 6 levin 2009-03-20 16:00:00 -0700 Assigned to levin for landing. 114607 7 levin 2009-03-20 16:57:51 -0700 Committed as r41882. 28770 2009-03-19 16:30:28 -0700 2009-03-20 14:28:24 -0700 Patch 24705.diff text/plain 1227 davemoore SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQxODQ0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDMt MTkgIERhdmUgTW9vcmUgIDxkYXZlbW9vcmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI0NzA1CisKKyAgICAgICAgQSBidWcgaW4gdGhlIFY4IGJpbmRpbmdzIGlz IHByZXZlbnRpbmcgY2hyb21pdW0gZnJvbSBzZXR0aW5nIHRoZSBocmVmIG9uIHRoZQorICAgICAg ICBsb2NhdGlvbiBvYmplY3QuLi5hbnkgYXR0ZW1wdCB0aHJvd3MgYSBzZWN1cml0eSBlcnJvciwg bm90IGp1c3QgZm9yIGphdmFzY3JpcHQKKyAgICAgICAgcHJvdG9jb2wKKworICAgICAgICAqIHBh Z2UvTG9jYXRpb24uaWRsOgorCiAyMDA5LTAzLTE5ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtv dkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRl eDogcGFnZS9Mb2NhdGlvbi5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGFnZS9Mb2NhdGlvbi5pZGwJKHJl dmlzaW9uIDQxODQ0KQorKysgcGFnZS9Mb2NhdGlvbi5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTM3 LDcgKzM3LDcgQEAgbW9kdWxlIHdpbmRvdyB7CiAgICAgICAgIEN1c3RvbURlbGV0ZVByb3BlcnR5 LAogICAgICAgICBDdXN0b21HZXRQcm9wZXJ0eU5hbWVzCiAgICAgXSBMb2NhdGlvbiB7Ci0gICAg ICAgICAgICAgICAgIGF0dHJpYnV0ZSBbQ3VzdG9tU2V0dGVyLCBWOERpc2FsbG93U2hhZG93aW5n XSBET01TdHJpbmcgaHJlZjsKKyAgICAgICAgICAgICAgICAgYXR0cmlidXRlIFtEb05vdENoZWNr RG9tYWluU2VjdXJpdHlPblNldCwgQ3VzdG9tU2V0dGVyLCBWOERpc2FsbG93U2hhZG93aW5nXSBE T01TdHJpbmcgaHJlZjsKIAogICAgICAgICBbQ3VzdG9tLCBWOE9uSW5zdGFuY2VdIHZvaWQgYXNz aWduKGluIERPTVN0cmluZyB1cmwpOwogICAgICAgICBbQ3VzdG9tLCBWOE9uSW5zdGFuY2VdIHZv aWQgcmVwbGFjZShpbiBET01TdHJpbmcgdXJsKTsK