<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>247034</bug_id>
          
          <creation_ts>2022-10-25 17:18:09 -0700</creation_ts>
          <short_desc>[git-webkit] Deeply inspect potential gardening commits</short_desc>
          <delta_ts>2022-10-26 08:55:10 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>246542</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Jonathan Bedard">jbedard</reporter>
          <assigned_to name="Jonathan Bedard">jbedard</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1908293</commentid>
    <comment_count>0</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2022-10-25 17:18:09 -0700</bug_when>
    <thetext>Gardening commits should not be considered &quot;pickable.&quot; While we&apos;re pretty good at identifying commits as gardening commits, many of the strings used can also be used in legitimate commit messages. If we inspect the files changed in a commit, however, gardening commits become obvious. We can&apos;t performantly check all commits on a branch, but we can inspect every potential gardening commit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1908294</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-10-25 17:18:25 -0700</bug_when>
    <thetext>&lt;rdar://problem/101568509&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1908296</commentid>
    <comment_count>2</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2022-10-25 17:19:44 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/5789</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1908428</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-10-26 08:09:38 -0700</bug_when>
    <thetext>Committed 256014@main (28f6affda692): &lt;https://commits.webkit.org/256014@main&gt;

Reviewed commits have been landed. Closing PR #5789 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1908440</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-10-26 08:55:10 -0700</bug_when>
    <thetext>Committed 252432.685@safari-7614-branch (d93ba4173c65): &lt;https://commits.webkit.org/252432.685@safari-7614-branch&gt;

Reviewed commits have been landed. Closing PR #162 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>