24699 2009-03-19 10:39:06 -0700 REGRESSION: Java Applets broken 2009-03-24 09:27:22 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://java.sun.com/applets/jdk/1.4/demo/applets/ArcTest/example1.html InRadar P2 Normal --- 1 amit sam amit ap finnur.webkit sam oldest_to_newest 114336 0 amit 2009-03-19 10:39:06 -0700 Java applets that do not specify 'codebase' in the embed/object tag do not work. This is due to a recent Revision 41568. If codebase is not specified, then HTMLAppletElement::createRenderer sets it using args.set("codeBase", document()->baseURL().string()); This sets it to the page url instead of it's base path. 114359 1 finnur.webkit 2009-03-19 13:08:43 -0700 Amit. Isn't that by design? http://java.sun.com/j2se/1.4.2/docs/guide/misc/applet.html Quote: CODEBASE = codebaseURL This OPTIONAL attribute specifies the base URL of the applet--the directory that contains the applet's code. If this attribute is not specified, then the document's URL is used. 114370 2 jon 2009-03-19 13:57:40 -0700 Also reported against Chromium, see http://code.google.com/p/chromium/issues/detail?id=8936 114642 3 ap 2009-03-21 04:21:07 -0700 <rdar://problem/6707494> 114863 4 28871 sam 2009-03-23 16:05:29 -0700 Created attachment 28871 patch 114864 5 28871 andersca 2009-03-23 16:12:19 -0700 Comment on attachment 28871 patch r=me 114866 6 sam 2009-03-23 16:19:18 -0700 FIxed in r41922. 114914 7 ap 2009-03-23 23:41:01 -0700 +String KURL::baseAsString() const +{ + return m_string.left(m_pathAfterLastSlash); +} It's quite confusing that KURL now uses "base" in different meanings. It's especially so when comparing to CFURLRef/NSURL, which remember the base URL they were created with, and have accessors for it. 114940 8 sam 2009-03-24 08:36:16 -0700 (In reply to comment #7) > +String KURL::baseAsString() const > +{ > + return m_string.left(m_pathAfterLastSlash); > +} > > It's quite confusing that KURL now uses "base" in different meanings. It's > especially so when comparing to CFURLRef/NSURL, which remember the base URL > they were created with, and have accessors for it. > Good point. Do you have a suggestion for a better name? 114945 9 ap 2009-03-24 09:27:22 -0700 Maybe parentDirectoryPath()? This will also make it clearer that the method only works properly for hierarchical URL schemes. 28871 2009-03-23 16:05:29 -0700 2009-03-23 16:12:19 -0700 patch javaCodeBase.diff text/plain 2200 sam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQxOTIx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDktMDMt MjMgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yNDY5OQorICAgICAgICBSRUdSRVNTSU9OOiBKYXZhIEFwcGxldHMg YnJva2VuCisKKyAgICAgICAgRml4IGxvYWRpbmcgSmF2YSBhcHBsZXRzIHdpdGhvdXQgYSBjb2Rl QmFzZS4gT25seSBwYXNzIHRoZSBiYXNlICh1cCB0byB0aGUKKyAgICAgICAgdGhlIGxhc3QgcGF0 aCBjb21wb25lbnQpIG9mIHRoZSBiYXNlVVJMIHRvIHRoZSBwbHVnLWluLgorCisgICAgICAgICog aHRtbC9IVE1MQXBwbGV0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MQXBwbGV0 RWxlbWVudDo6Y3JlYXRlUmVuZGVyZXIpOgorICAgICAgICAqIHBsYXRmb3JtL0tVUkwuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6S1VSTDo6YmFzZUFzU3RyaW5nKToKKyAgICAgICAgKiBwbGF0Zm9y bS9LVVJMLmg6CisKIDIwMDktMDMtMjMgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBodG1sL0hUTUxBcHBsZXRF bGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBodG1sL0hUTUxBcHBsZXRFbGVtZW50LmNwcAkocmV2 aXNpb24gNDE5MTkpCisrKyBodG1sL0hUTUxBcHBsZXRFbGVtZW50LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTIwLDcgKzEyMCw3IEBAIFJlbmRlck9iamVjdCogSFRNTEFwcGxldEVsZW1lbnQ6OmNy ZWF0ZVIKICAgICAgICAgaWYgKCFjb2RlQmFzZS5pc051bGwoKSkKICAgICAgICAgICAgIGFyZ3Mu c2V0KCJjb2RlQmFzZSIsIGNvZGVCYXNlKTsKICAgICAgICAgZWxzZQotICAgICAgICAgICAgYXJn cy5zZXQoImNvZGVCYXNlIiwgZG9jdW1lbnQoKS0+YmFzZVVSTCgpLnN0cmluZygpKTsKKyAgICAg ICAgICAgIGFyZ3Muc2V0KCJjb2RlQmFzZSIsIGRvY3VtZW50KCktPmJhc2VVUkwoKS5iYXNlQXNT dHJpbmcoKSk7CiAKICAgICAgICAgY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lID0gZ2V0QXR0cmli dXRlKGRvY3VtZW50KCktPmlzSFRNTERvY3VtZW50KCkgPyBuYW1lQXR0ciA6IGlkQXR0cik7CiAg ICAgICAgIGlmICghbmFtZS5pc051bGwoKSkKSW5kZXg6IHBsYXRmb3JtL0tVUkwuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIHBsYXRmb3JtL0tVUkwuY3BwCShyZXZpc2lvbiA0MTkxOSkKKysrIHBsYXRmb3Jt L0tVUkwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MDUsNiArNjA1LDExIEBAIGJvb2wgS1VSTDo6 aGFzUmVmKCkgY29uc3QKICAgICByZXR1cm4gbV9mcmFnbWVudEVuZCAhPSBtX3F1ZXJ5RW5kOwog fQogCitTdHJpbmcgS1VSTDo6YmFzZUFzU3RyaW5nKCkgY29uc3QKK3sKKyAgICByZXR1cm4gbV9z dHJpbmcubGVmdChtX3BhdGhBZnRlckxhc3RTbGFzaCk7Cit9CisKICNpZmRlZiBOREVCVUcKIAog c3RhdGljIGlubGluZSB2b2lkIGFzc2VydFByb3RvY29sSXNHb29kKGNvbnN0IGNoYXIqKQpJbmRl eDogcGxhdGZvcm0vS1VSTC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBsYXRmb3JtL0tVUkwuaAkocmV2aXNp b24gNDE5MTkpCisrKyBwbGF0Zm9ybS9LVVJMLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyMyw2ICsx MjMsOCBAQCBwdWJsaWM6CiAgICAgU3RyaW5nIHJlZigpIGNvbnN0OyAvLyBEb2VzICpub3QqIGlu Y2x1ZGUgdGhlICIjIi4KICAgICBib29sIGhhc1JlZigpIGNvbnN0OwogCisgICAgU3RyaW5nIGJh c2VBc1N0cmluZygpIGNvbnN0OworCiAgICAgU3RyaW5nIHByZXR0eVVSTCgpIGNvbnN0OwogICAg IFN0cmluZyBmaWxlU3lzdGVtUGF0aCgpIGNvbnN0OwogCg==