<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>246939</bug_id>
          
          <creation_ts>2022-10-24 03:13:05 -0700</creation_ts>
          <short_desc>Use the correct paint methods for painting a section rect of RenderWidgets</short_desc>
          <delta_ts>2022-11-01 11:34:54 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>Safari Technology Preview</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ahmad Saleem">ahmad.saleem792</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>karlcow</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1907755</commentid>
    <comment_count>0</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2022-10-24 03:13:05 -0700</bug_when>
    <thetext>Hi Team,

I tried to find the related issue for this but couldn&apos;t and it was fixed in below commit:

Blink Commit - https://src.chromium.org/viewvc/blink?revision=181068&amp;view=revision

We still have this FIXME, so I thought it would be good to fix this bug in Webkit upstream as well.

Remove this and update comment - https://github.com/WebKit/WebKit/blob/05f04306d2dc59ca6b5c255a6e31483799daf9f8/Source/WebCore/rendering/RenderObject.h#L734

Update this - https://github.com/WebKit/WebKit/blob/fc014916474a9e42b1528fc70ecfdbfdce538c44/Source/WebCore/rendering/RenderElement.h#L147

Remove this &quot;FIXME&quot; - https://github.com/WebKit/WebKit/blob/0efc0bf9f32501aa0d73f867043d0ba1cc417d40/Source/WebCore/rendering/RenderWidget.cpp#L343

Just wanted to create bug before doing PR.

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1907810</commentid>
    <comment_count>1</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2022-10-24 08:50:40 -0700</bug_when>
    <thetext>Does the Blink testcase reproduce a bug in WebKit?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1907814</commentid>
    <comment_count>2</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2022-10-24 09:15:17 -0700</bug_when>
    <thetext>(In reply to Simon Fraser (smfr) from comment #1)
&gt; Does the Blink testcase reproduce a bug in WebKit?

I tried but I get error for Chrome and Firefox:

JSFiddle - https://jsfiddle.net/65kpcfar/show

Safari 16 show &apos;grey&apos; square box while Firefox Nightly 108 and Chrome Canary 109 show this error:

Uncaught IndexSizeError: Failed to execute &apos;setBaseAndExtent&apos; on &apos;Selection&apos;: There is no child at offset 1.&quot;

IndexSizeError: Selection.setBaseAndExtent: The focus offset value 1 is out of range&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1909278</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-10-31 03:14:17 -0700</bug_when>
    <thetext>&lt;rdar://problem/101749980&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1909451</commentid>
    <comment_count>4</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2022-10-31 15:48:13 -0700</bug_when>
    <thetext>https://github.com/WebKit/WebKit/pull/5704</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1909595</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-11-01 11:34:51 -0700</bug_when>
    <thetext>Committed 256191@main (fe7889ca7da9): &lt;https://commits.webkit.org/256191@main&gt;

Reviewed commits have been landed. Closing PR #5704 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>