246904 2022-10-22 11:51:58 -0700 AX: Simplify AXObjectCache by making better use of AXIsolatedTree::treeForPageID(std::optional<PageIdentifier>) 2022-10-22 20:51:13 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tyler_w tyler_w aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1907562 0 tyler_w 2022-10-22 11:51:58 -0700 Several places in AXObjectCache manually check that m_pageID is not std::nullopt rather than using the existing AXIsolatedTree::treeForPageID(std::optional<PageIdentifier>) method. 1907563 1 webkit-bug-importer 2022-10-22 11:52:10 -0700 <rdar://problem/101462585> 1907564 2 463168 tyler_w 2022-10-22 11:54:36 -0700 Created attachment 463168 Patch 1907602 3 ews-feeder 2022-10-22 20:51:11 -0700 Committed 255891@main (ff6a48ca8eab): <https://commits.webkit.org/255891@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463168. 463168 2022-10-22 11:54:36 -0700 2022-10-22 20:51:12 -0700 Patch bug-246904-20221022115435.patch text/plain 3281 tyler_w RnJvbSBkNGQxNzAxNzYyYTQ1ZTI5ZDQxZWZkOGMyYzYyZGUyOGI2M2IwZTIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUeWxlciBXaWxjb2NrIDx0eWxlcl93QGFwcGxlLmNvbT4KRGF0 ZTogU2F0LCAyMiBPY3QgMjAyMiAxMTo1MjozNCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEFYOiBT aW1wbGlmeSBBWE9iamVjdENhY2hlIGJ5IG1ha2luZyBiZXR0ZXIgdXNlIG9mCiBBWElzb2xhdGVk VHJlZTo6dHJlZUZvclBhZ2VJRChzdGQ6Om9wdGlvbmFsPFBhZ2VJZGVudGlmaWVyPikKIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDY5MDQgcmRhcjovL3Byb2JsZW0v MTAxNDYyNTg1CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KClNldmVyYWwgcGxhY2VzIGlu IEFYT2JqZWN0Q2FjaGUgbWFudWFsbHkgY2hlY2sgdGhhdCBtX3BhZ2VJRCBpcyBub3Qgc3RkOjpu dWxsb3B0IHJhdGhlciB0aGFuIHVzaW5nIHRoZSBleGlzdGluZwpBWElzb2xhdGVkVHJlZTo6dHJl ZUZvclBhZ2VJRChzdGQ6Om9wdGlvbmFsPFBhZ2VJZGVudGlmaWVyPikgbWV0aG9kLiBUaGlzIHBh dGNoIGZpeGVzIHRoYXQuCgpObyB0ZXN0IGJlY2F1c2UgdGhlcmUgaXMgbm8gYmVoYXZpb3IgY2hh bmdlLgoKKiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwOgoo V2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6Z2V0T3JDcmVhdGVJc29sYXRlZFRyZWUgY29uc3QpOgoo V2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6cmVtb3ZlKToKKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6 OnBlcmZvcm1EZWZlcnJlZENhY2hlVXBkYXRlKToKKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OnJl bGF0aW9uc05lZWRVcGRhdGUpOgotLS0KIC4uLi9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmpl Y3RDYWNoZS5jcHAgICB8IDE5ICsrKysrKystLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA3 IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwCmluZGV4IDJmZTRmZDJkOGVhMy4uOWRjZjIwMjAz ZDM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2Fj aGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5j cHAKQEAgLTgyOSwxMCArODI5LDcgQEAgQVhDb3JlT2JqZWN0KiBBWE9iamVjdENhY2hlOjpyb290 T2JqZWN0KCkKICNpZiBFTkFCTEUoQUNDRVNTSUJJTElUWV9JU09MQVRFRF9UUkVFKQogUmVmUHRy PEFYSXNvbGF0ZWRUcmVlPiBBWE9iamVjdENhY2hlOjpnZXRPckNyZWF0ZUlzb2xhdGVkVHJlZSgp IGNvbnN0CiB7Ci0gICAgaWYgKCFtX3BhZ2VJRCkKLSAgICAgICAgcmV0dXJuIG51bGxwdHI7Ci0K LSAgICBhdXRvIHRyZWUgPSBBWElzb2xhdGVkVHJlZTo6dHJlZUZvclBhZ2VJRCgqbV9wYWdlSUQp OworICAgIFJlZlB0ciB0cmVlID0gQVhJc29sYXRlZFRyZWU6OnRyZWVGb3JQYWdlSUQobV9wYWdl SUQpOwogICAgIGlmICghdHJlZSkgewogICAgICAgICB0cmVlID0gQWNjZXNzaWJpbGl0eTo6cmV0 cmlldmVWYWx1ZUZyb21NYWluVGhyZWFkPFJlZlB0cjxBWElzb2xhdGVkVHJlZT4+KFt0aGlzXSAo KSAtPiBSZWZQdHI8QVhJc29sYXRlZFRyZWU+IHsKICAgICAgICAgICAgIHJldHVybiBBWElzb2xh dGVkVHJlZTo6Y3JlYXRlKGNvbnN0X2Nhc3Q8QVhPYmplY3RDYWNoZSo+KHRoaXMpKTsKQEAgLTkx NSwxMCArOTEyLDggQEAgdm9pZCBBWE9iamVjdENhY2hlOjpyZW1vdmUoQVhJRCBheElEKQogICAg ICAgICByZXR1cm47CiAKICNpZiBFTkFCTEUoQUNDRVNTSUJJTElUWV9JU09MQVRFRF9UUkVFKQot ICAgIGlmIChtX3BhZ2VJRCkgewotICAgICAgICBpZiAoYXV0byB0cmVlID0gQVhJc29sYXRlZFRy ZWU6OnRyZWVGb3JQYWdlSUQoKm1fcGFnZUlEKSkKLSAgICAgICAgICAgIHRyZWUtPnJlbW92ZU5v ZGUoKm9iamVjdCk7Ci0gICAgfQorICAgIGlmIChhdXRvIHRyZWUgPSBBWElzb2xhdGVkVHJlZTo6 dHJlZUZvclBhZ2VJRChtX3BhZ2VJRCkpCisgICAgICAgIHRyZWUtPnJlbW92ZU5vZGUoKm9iamVj dCk7CiAjZW5kaWYKIAogICAgIG9iamVjdC0+ZGV0YWNoKEFjY2Vzc2liaWxpdHlEZXRhY2htZW50 VHlwZTo6RWxlbWVudERlc3Ryb3llZCk7CkBAIC0zNTk4LDggKzM1OTMsOCBAQCB2b2lkIEFYT2Jq ZWN0Q2FjaGU6OnBlcmZvcm1EZWZlcnJlZENhY2hlVXBkYXRlKCkKICAgICBtX2RlZmVycmVkTWVu dUxpc3RDaGFuZ2UuY2xlYXIoKTsKIAogI2lmIEVOQUJMRShBQ0NFU1NJQklMSVRZX0lTT0xBVEVE X1RSRUUpCi0gICAgaWYgKG1fZGVmZXJyZWRSZWdlbmVyYXRlSXNvbGF0ZWRUcmVlICYmIG1fcGFn ZUlEKSB7Ci0gICAgICAgIGlmIChhdXRvIHRyZWUgPSBBWElzb2xhdGVkVHJlZTo6dHJlZUZvclBh Z2VJRCgqbV9wYWdlSUQpKSB7CisgICAgaWYgKG1fZGVmZXJyZWRSZWdlbmVyYXRlSXNvbGF0ZWRU cmVlKSB7CisgICAgICAgIGlmIChhdXRvIHRyZWUgPSBBWElzb2xhdGVkVHJlZTo6dHJlZUZvclBh Z2VJRChtX3BhZ2VJRCkpIHsKICAgICAgICAgICAgIGlmIChhdXRvKiB3ZWJBcmVhID0gcm9vdFdl YkFyZWEoKSkgewogICAgICAgICAgICAgICAgIEFYTE9HKCJSZWdlbmVyYXRpbmcgaXNvbGF0ZWQg dHJlZSBmcm9tIEFYT2JqZWN0Q2FjaGU6OnBlcmZvcm1EZWZlcnJlZENhY2hlVXBkYXRlKCkuIik7 CiAgICAgICAgICAgICAgICAgdHJlZS0+Z2VuZXJhdGVTdWJ0cmVlKCp3ZWJBcmVhKTsKQEAgLTQx MzYsOCArNDEzMSw4IEBAIHZvaWQgQVhPYmplY3RDYWNoZTo6cmVsYXRpb25zTmVlZFVwZGF0ZShi b29sIG5lZWRVcGRhdGUpCiAgICAgbV9yZWxhdGlvbnNOZWVkVXBkYXRlID0gbmVlZFVwZGF0ZTsK IAogI2lmIEVOQUJMRShBQ0NFU1NJQklMSVRZX0lTT0xBVEVEX1RSRUUpCi0gICAgaWYgKG1fcmVs YXRpb25zTmVlZFVwZGF0ZSAmJiBtX3BhZ2VJRCkgewotICAgICAgICBpZiAoYXV0byB0cmVlID0g QVhJc29sYXRlZFRyZWU6OnRyZWVGb3JQYWdlSUQoKm1fcGFnZUlEKSkKKyAgICBpZiAobV9yZWxh dGlvbnNOZWVkVXBkYXRlKSB7CisgICAgICAgIGlmIChhdXRvIHRyZWUgPSBBWElzb2xhdGVkVHJl ZTo6dHJlZUZvclBhZ2VJRChtX3BhZ2VJRCkpCiAgICAgICAgICAgICB0cmVlLT5yZWxhdGlvbnNO ZWVkVXBkYXRlKHRydWUpOwogICAgIH0KICNlbmRpZgo=