<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>246845</bug_id>
          
          <creation_ts>2022-10-20 21:25:58 -0700</creation_ts>
          <short_desc>[WebDriver] Update w3c tests with get_computed_role and get_computed_label fixes</short_desc>
          <delta_ts>2022-11-14 00:34:29 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebDriver</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=246814</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=246813</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Lauro Moura">lmoura</reporter>
          <assigned_to name="Carlos Garcia Campos">cgarcia</assigned_to>
          <cc>bburg</cc>
    
    <cc>cgarcia</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1907232</commentid>
    <comment_count>0</comment_count>
    <who name="Lauro Moura">lmoura</who>
    <bug_when>2022-10-20 21:25:58 -0700</bug_when>
    <thetext>When fixing bug246813, two tests were failing due to issues in the test cases themselves, fixed upstream in [1] in August 2022.

It&apos;ll be a reasonably big bump (last import was from December 2021 and the diff contains around 158 commits) and some extra work will be needed in the test executors. For example, it&apos;ll require changes in webkitpy&apos;s webdriver executor due to the removal of `WebDriverServer` in [2].

[1] https://github.com/web-platform-tests/wpt/commit/76cc414789e2b16ab90a7c6a0c98cfc6f2eb39f4
[2] https://github.com/web-platform-tests/wpt/commit/51c8ca12b4cbc7acd29e90038211d6c516ceb09c</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1908915</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-10-27 21:26:17 -0700</bug_when>
    <thetext>&lt;rdar://problem/101664213&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1909020</commentid>
    <comment_count>2</comment_count>
    <who name="Lauro Moura">lmoura</who>
    <bug_when>2022-10-28 08:00:20 -0700</bug_when>
    <thetext>WIP patch importing https://github.com/web-platform-tests/wpt/commit/76cc414789e2b16ab90a7c6a0c98cfc6f2eb39f4 in https://github.com/lauromoura/WebKit/tree/wip-bug246845-webdriver-bump

Not sure if I was doing the right approach to replace WebDriverServer.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1910983</commentid>
    <comment_count>3</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2022-11-08 01:22:04 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/6244</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1912207</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-11-14 00:34:27 -0800</bug_when>
    <thetext>Committed 256638@main (48b4b1609fe7): &lt;https://commits.webkit.org/256638@main&gt;

Reviewed commits have been landed. Closing PR #6244 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>