246844 2022-10-20 20:40:05 -0700 REGRESSION(cairo 1.17.6)[WinCairo] rendering glitches of twitter.com and yahoo.co.jp 2023-01-04 18:10:36 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=248014 P2 Normal --- 1 fujii webkit-unassigned don.olmstead oldest_to_newest 1907226 0 fujii 2022-10-20 20:40:05 -0700 [WinCairo] some text aren't painted in 150% page zoom scale factor in twitter https://twitter.com/PlayStation_jp/status/1582356592640475136 https://twitter.com/AppleMusicJapan/status/1581977079276789761 https://twitter.com/NiziU__official/status/1583276886855192577 Changing the page zoom scale factor resolved the problem. It seems that this issue is happening for tweets containing Japanese text, English texts and an image. 1907227 1 fujii 2022-10-20 20:41:27 -0700 This seems a regression between the following revision range: WinCairo 254165@main OK WinCairo 254443@main Bad 1907238 2 fujii 2022-10-20 22:25:07 -0700 This issue seems reproducible in https://www.yahoo.co.jp/ . 1. Start WinCairo MiniBrowser with 150% page zoom. WinCairo MiniBrowser adjusts the initial page zoom because it doesn't support device scale factor. If you use 150% DPI display, WinCairo MiniBrowser uses 150% page zoom by default. 2. Load https://www.yahoo.co.jp/ 3. Moving the cursor on the page while scrolling the page with the mouse wheel. 1907241 3 fujii 2022-10-20 23:12:04 -0700 Both twitter.com and yahoo.co.jp issues are reproducible with WinCairo WK1. 1907253 4 fujii 2022-10-21 01:16:16 -0700 This is not a WebKit regression. WebKitRequirementsWin64.zip v2022.03.05 cairo.dll works fine. v2022.09.06 and v2022.10.20 has this bug. 1907421 5 fujii 2022-10-21 14:23:16 -0700 I built Cairo with Meson locally. Cairo 1.17.4: Good Cairo 1.17.6: Bad Cairo latest (2cfd08664): Bad This seems like a Cairo 1.17.6 regression. I'm going to bisect. 1907720 6 fujii 2022-10-23 21:40:55 -0700 This is happening after the following commit. atomic: Add support for WIN32 atomic operations (cd2b91c6) · Commits · cairo / cairo · GitLab https://gitlab.freedesktop.org/cairo/cairo/-/commit/cd2b91c62ea74f6448a8a5cff5dd316f8e692e97 1907941 7 fujii 2022-10-24 18:54:07 -0700 Cairo bug ticket: https://gitlab.freedesktop.org/cairo/cairo/-/issues/598 1908535 8 fujii 2022-10-26 14:23:37 -0700 This bug disappears for WinCairo WK2 if I enable UseGPUProcessForDOMRenderingEnabled (bug#246733). 1908589 9 fujii 2022-10-26 17:30:05 -0700 cairo_surface_destroy is called in ImageDecoder thread. Here is the callstack (taken by WinCairo WK1): > WebKit.dll!WTF::DefaultRefDerefTraits<_cairo_surface>::derefIfNotNull(_cairo_surface * ptr) Line 52 C++ > WebKit.dll!WTF::RefPtr<_cairo_surface,WTF::RawPtrTraits<_cairo_surface>,WTF::DefaultRefDerefTraits<_cairo_surface>>::~RefPtr<_cairo_surface,WTF::RawPtrTraits<_cairo_surface>,WTF::DefaultRefDerefTraits<_cairo_surface>>() Line 74 C++ > WebKit.dll!WebCore::ImageBackingStore::image() Line 44 C++ > WebKit.dll!WebCore::ScalableImageDecoder::createFrameImageAtIndex(unsigned __int64 index, WebCore::SubsamplingLevel __formal, const WebCore::DecodingOptions & __formal) Line 275 C++ > WebKit.dll!WebCore::ImageSource::startAsyncDecodingQueue::__l2::<lambda_1>::operator()() Line 364 C++ > WebKit.dll!WTF::Detail::CallableWrapper<`WebCore::ImageSource::startAsyncDecodingQueue'::`2'::<lambda_1>,void>::call() Line 53 C++ > WTF.dll!WTF::Function<void __cdecl(void)>::operator()() Line 83 C++ > WTF.dll!WTF::WorkQueueBase::dispatch::__l2::<lambda_1>::operator()() Line 70 C++ > WTF.dll!WTF::Detail::CallableWrapper<`WTF::WorkQueueBase::dispatch'::`2'::<lambda_1>,void>::call() Line 53 C++ > WTF.dll!WTF::Function<void __cdecl(void)>::operator()() Line 83 C++ > WTF.dll!WTF::RunLoop::performWork() Line 147 C++ > WTF.dll!WTF::RunLoop::wndProc(HWND__ * hWnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 57 C++ > WTF.dll!WTF::RunLoop::RunLoopWndProc(HWND__ * hWnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 39 C++ > [External Code] > WTF.dll!WTF::RunLoop::run() Line 74 C++ > WTF.dll!WTF::RunLoop::create::__l2::<lambda_1>::operator()() Line 114 C++ > WTF.dll!WTF::Detail::CallableWrapper<`WTF::RunLoop::create'::`2'::<lambda_1>,void>::call() Line 53 C++ > WTF.dll!WTF::Function<void __cdecl(void)>::operator()() Line 83 C++ > WTF.dll!WTF::Thread::entryPoint(WTF::Thread::NewThreadContext * newThreadContext) Line 251 C++ > WTF.dll!WTF::wtfThreadEntryPoint(void * data) Line 151 C++ > [External Code] 1908922 10 463290 fujii 2022-10-27 22:03:05 -0700 Created attachment 463290 Patch to disable async image decoding I hacked WinCairo WK1 to disable async image decoding. But, this bug is still happening. 1909250 11 463316 fujii 2022-10-30 17:48:01 -0700 Created attachment 463316 test case 1909255 12 fujii 2022-10-30 19:13:49 -0700 Both twitter.com and yahoo.co.jp have a text with font-size:0 and a text decoration. twitter.com hides "https://". yahoo.co.jp hides a text of arrow icons of the real time search trend. 1909267 13 fujii 2022-10-30 21:36:31 -0700 PR https://github.com/WebKitForWindows/WebKitRequirements/pull/100 1913026 14 fujii 2022-11-16 18:18:50 -0800 This bug hasn't been reprodusible for WinCairo WK2 since 256189@main turned on UseGPUProcessForDOMRenderingEnabled. WinCairo WK1 still can replicate. 1923058 15 fujii 2023-01-04 18:10:36 -0800 Fixed by https://github.com/WebKitForWindows/WebKitRequirements/releases/tag/v2022.12.22 463290 2022-10-27 22:03:05 -0700 2022-10-30 21:36:00 -0700 Patch to disable async image decoding disable-async-decoding.patch text/plain 4041 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNlLmNwcApp bmRleCBmMTQ4ZThmYmE4YzUuLjdkZjUxY2MyMmExOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VTb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNlLmNwcApAQCAtMzQ4LDcgKzM0OCw3IEBAIHZv aWQgSW1hZ2VTb3VyY2U6OnN0YXJ0QXN5bmNEZWNvZGluZ1F1ZXVlKCkKICAgICBBU1NFUlQoaXNN YWluVGhyZWFkKCkpOwogCiAgICAgLy8gV2UgbmVlZCB0byBwcm90ZWN0IHRoaXMsIG1fZGVjb2Rp bmdRdWV1ZSBhbmQgbV9kZWNvZGVyIGZyb20gYmVpbmcgZGVsZXRlZCB3aGlsZSB3ZSBhcmUgaW4g dGhlIGRlY29kaW5nIGxvb3AuCi0gICAgZGVjb2RpbmdRdWV1ZSgpLmRpc3BhdGNoKFtwcm90ZWN0 ZWRUaGlzID0gUmVmIHsgKnRoaXMgfSwgcHJvdGVjdGVkRGVjb2RpbmdRdWV1ZSA9IFJlZiB7IGRl Y29kaW5nUXVldWUoKSB9LCBwcm90ZWN0ZWRGcmFtZVJlcXVlc3RRdWV1ZSA9IFJlZiB7IGZyYW1l UmVxdWVzdFF1ZXVlKCkgfSwgcHJvdGVjdGVkRGVjb2RlciA9IFJlZiB7ICptX2RlY29kZXIgfSwg c291cmNlVVJMID0gc291cmNlVVJMKCkuc3RyaW5nKCkuaXNvbGF0ZWRDb3B5KCldICgpIG11dGFi bGUgeworICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbcHJvdGVjdGVkVGhpcyA9IFJlZiB7 ICp0aGlzIH0sIHByb3RlY3RlZERlY29kaW5nUXVldWUgPSBSZWYgeyBkZWNvZGluZ1F1ZXVlKCkg fSwgcHJvdGVjdGVkRnJhbWVSZXF1ZXN0UXVldWUgPSBSZWYgeyBmcmFtZVJlcXVlc3RRdWV1ZSgp IH0sIHByb3RlY3RlZERlY29kZXIgPSBSZWYgeyAqbV9kZWNvZGVyIH0sIHNvdXJjZVVSTCA9IHNv dXJjZVVSTCgpLnN0cmluZygpLmlzb2xhdGVkQ29weSgpXSAoKSBtdXRhYmxlIHsKICAgICAgICAg SW1hZ2VGcmFtZVJlcXVlc3QgZnJhbWVSZXF1ZXN0OwogICAgICAgICBTZWNvbmRzIG1pbkRlY29k aW5nRHVyYXRpb24gPSBwcm90ZWN0ZWRUaGlzLT5mcmFtZURlY29kaW5nRHVyYXRpb25Gb3JUZXN0 aW5nKCk7CiAKQEAgLTM4Miw2ICszODIsNyBAQCB2b2lkIEltYWdlU291cmNlOjpzdGFydEFzeW5j RGVjb2RpbmdRdWV1ZSgpCiAgICAgICAgICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICAgICAg ICAgIExPRyhJbWFnZXMsICJJbWFnZVNvdXJjZTo6JXMgLSAlcCAtIHVybDogJXMgW2ZyYW1lICVs ZCB3aWxsIG5vdCBjYWNoZWRdIiwgX19GVU5DVElPTl9fLCBwcm90ZWN0ZWRUaGlzLnB0cigpLCBz b3VyY2VVUkwudXRmOCgpLmRhdGEoKSwgZnJhbWVSZXF1ZXN0LmluZGV4KTsKICAgICAgICAgICAg IH0pOworICAgICAgICAgICAgcHJvdGVjdGVkVGhpcy0+c3RvcEFzeW5jRGVjb2RpbmdRdWV1ZSgp OwogICAgICAgICB9CiAKICAgICAgICAgLy8gRW5zdXJlIGRlc3RydWN0aW9uIGhhcHBlbnMgb24g Y3JlYXRpb24gdGhyZWFkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2Fpcm8vUmVmUHRyQ2Fpcm8uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2Fpcm8vUmVmUHRyQ2Fpcm8uY3BwCmluZGV4IGFjNTBjMWExYjU1Yi4uMGU5MDI5ZjI5 ZWY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9S ZWZQdHJDYWlyby5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fp cm8vUmVmUHRyQ2Fpcm8uY3BwCkBAIC0yMyw3NiArMjMsOTAgQEAKIAogI2luY2x1ZGUgPGNhaXJv Lmg+CiAKKyNpbmNsdWRlIDx3dGYvTWFpblRocmVhZC5oPgorCiBuYW1lc3BhY2UgV1RGIHsKIAog dm9pZCBEZWZhdWx0UmVmRGVyZWZUcmFpdHM8Y2Fpcm9fdD46OnJlZklmTm90TnVsbChjYWlyb190 KiBwdHIpCiB7CisgICAgYXNzZXJ0SXNNYWluVGhyZWFkKCk7CiAgICAgaWYgKExJS0VMWShwdHIp KQogICAgICAgICBjYWlyb19yZWZlcmVuY2UocHRyKTsKIH0KIAogdm9pZCBEZWZhdWx0UmVmRGVy ZWZUcmFpdHM8Y2Fpcm9fdD46OmRlcmVmSWZOb3ROdWxsKGNhaXJvX3QqIHB0cikKIHsKKyAgICBh c3NlcnRJc01haW5UaHJlYWQoKTsKICAgICBpZiAoTElLRUxZKHB0cikpCiAgICAgICAgIGNhaXJv X2Rlc3Ryb3kocHRyKTsKIH0KIAogdm9pZCBEZWZhdWx0UmVmRGVyZWZUcmFpdHM8Y2Fpcm9fc3Vy ZmFjZV90Pjo6cmVmSWZOb3ROdWxsKGNhaXJvX3N1cmZhY2VfdCogcHRyKQogeworICAgIGFzc2Vy dElzTWFpblRocmVhZCgpOwogICAgIGlmIChMSUtFTFkocHRyKSkKICAgICAgICAgY2Fpcm9fc3Vy ZmFjZV9yZWZlcmVuY2UocHRyKTsKIH0KIAogdm9pZCBEZWZhdWx0UmVmRGVyZWZUcmFpdHM8Y2Fp cm9fc3VyZmFjZV90Pjo6ZGVyZWZJZk5vdE51bGwoY2Fpcm9fc3VyZmFjZV90KiBwdHIpCiB7Cisg ICAgYXNzZXJ0SXNNYWluVGhyZWFkKCk7CiAgICAgaWYgKExJS0VMWShwdHIpKQogICAgICAgICBj YWlyb19zdXJmYWNlX2Rlc3Ryb3kocHRyKTsKIH0KIAogdm9pZCBEZWZhdWx0UmVmRGVyZWZUcmFp dHM8Y2Fpcm9fZm9udF9mYWNlX3Q+OjpyZWZJZk5vdE51bGwoY2Fpcm9fZm9udF9mYWNlX3QqIHB0 cikKIHsKKyAgICBhc3NlcnRJc01haW5UaHJlYWQoKTsKICAgICBpZiAoTElLRUxZKHB0cikpCiAg ICAgICAgIGNhaXJvX2ZvbnRfZmFjZV9yZWZlcmVuY2UocHRyKTsKIH0KIAogdm9pZCBEZWZhdWx0 UmVmRGVyZWZUcmFpdHM8Y2Fpcm9fZm9udF9mYWNlX3Q+OjpkZXJlZklmTm90TnVsbChjYWlyb19m b250X2ZhY2VfdCogcHRyKQogeworICAgIGFzc2VydElzTWFpblRocmVhZCgpOwogICAgIGlmIChM SUtFTFkocHRyKSkKICAgICAgICAgY2Fpcm9fZm9udF9mYWNlX2Rlc3Ryb3kocHRyKTsKIH0KIAog dm9pZCBEZWZhdWx0UmVmRGVyZWZUcmFpdHM8Y2Fpcm9fc2NhbGVkX2ZvbnRfdD46OnJlZklmTm90 TnVsbChjYWlyb19zY2FsZWRfZm9udF90KiBwdHIpCiB7CisgICAgYXNzZXJ0SXNNYWluVGhyZWFk KCk7CiAgICAgaWYgKExJS0VMWShwdHIpKQogICAgICAgICBjYWlyb19zY2FsZWRfZm9udF9yZWZl cmVuY2UocHRyKTsKIH0KIAogdm9pZCBEZWZhdWx0UmVmRGVyZWZUcmFpdHM8Y2Fpcm9fc2NhbGVk X2ZvbnRfdD46OmRlcmVmSWZOb3ROdWxsKGNhaXJvX3NjYWxlZF9mb250X3QqIHB0cikKIHsKKyAg ICBhc3NlcnRJc01haW5UaHJlYWQoKTsKICAgICBpZiAoTElLRUxZKHB0cikpCiAgICAgICAgIGNh aXJvX3NjYWxlZF9mb250X2Rlc3Ryb3kocHRyKTsKIH0KIAogdm9pZCBEZWZhdWx0UmVmRGVyZWZU cmFpdHM8Y2Fpcm9fcGF0dGVybl90Pjo6cmVmSWZOb3ROdWxsKGNhaXJvX3BhdHRlcm5fdCogcHRy KQogeworICAgIGFzc2VydElzTWFpblRocmVhZCgpOwogICAgIGlmIChMSUtFTFkocHRyKSkKICAg ICAgICAgY2Fpcm9fcGF0dGVybl9yZWZlcmVuY2UocHRyKTsKIH0KIAogdm9pZCBEZWZhdWx0UmVm RGVyZWZUcmFpdHM8Y2Fpcm9fcGF0dGVybl90Pjo6ZGVyZWZJZk5vdE51bGwoY2Fpcm9fcGF0dGVy bl90KiBwdHIpCiB7CisgICAgYXNzZXJ0SXNNYWluVGhyZWFkKCk7CiAgICAgaWYgKExJS0VMWShw dHIpKQogICAgICAgICBjYWlyb19wYXR0ZXJuX2Rlc3Ryb3kocHRyKTsKIH0KIAogdm9pZCBEZWZh dWx0UmVmRGVyZWZUcmFpdHM8Y2Fpcm9fcmVnaW9uX3Q+OjpyZWZJZk5vdE51bGwoY2Fpcm9fcmVn aW9uX3QqIHB0cikKIHsKKyAgICBhc3NlcnRJc01haW5UaHJlYWQoKTsKICAgICBpZiAoTElLRUxZ KHB0cikpCiAgICAgICAgIGNhaXJvX3JlZ2lvbl9yZWZlcmVuY2UocHRyKTsKIH0KIAogdm9pZCBE ZWZhdWx0UmVmRGVyZWZUcmFpdHM8Y2Fpcm9fcmVnaW9uX3Q+OjpkZXJlZklmTm90TnVsbChjYWly b19yZWdpb25fdCogcHRyKQogeworICAgIGFzc2VydElzTWFpblRocmVhZCgpOwogICAgIGlmIChM SUtFTFkocHRyKSkKICAgICAgICAgY2Fpcm9fcmVnaW9uX2Rlc3Ryb3kocHRyKTsKIH0K 463316 2022-10-30 17:48:01 -0700 2022-10-30 17:48:01 -0700 test case testcase.html text/html 179 fujii PCFET0NUWVBFIGh0bWw+CjxzdHlsZT4KICBzcGFuIHsKICAgICAgZm9udC1zaXplOiAyNHB4Owog ICAgICB0ZXh0LWRlY29yYXRpb246IHVuZGVybGluZTsKICB9CiAgI3ggewogICAgICBmb250LXNp emU6IDA7CiAgfQo8L3N0eWxlPgoKPHNwYW4gaWQ9eD5odHRwczovLzwvc3Bhbj48c3Bhbj5hYmNk PC9zcGFuPgo=