246822 2022-10-20 12:22:08 -0700 Add the class FilterTargetSwitcher 2022-10-20 14:29:15 -0700 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 198416 1 sabouhallawa sabouhallawa dino webkit-bug-importer oldest_to_newest 1907122 0 sabouhallawa 2022-10-20 12:22:08 -0700 This will manage applying a filter to a certain area of drawings with the minimum changes in the existing code. All it needs is a set of callbacks in the existing caller class. And the caller can either add this line of code to the drawing function: FilterTargetSwitcher targetSwitcher(*this, bounds); Or a line like this one if calculating the bounds is expensive: FilterTargetSwitcher targetSwitcher(*this, []() { return path.fastBoundingRect(); }); The constructor of FilterTargetSwitcher will ask the client if there a filter to apply or not. If there is a filter, it will switch the drawing to a temporary ImageBuffer. The client has to make sure all the drawing code from now on will use the context of this ImageBuffer. The destructor will apply the filter to the temporary ImageBuffer and then composite filtered ImageBuffer to the client drawing context. 1907124 1 webkit-bug-importer 2022-10-20 12:30:34 -0700 <rdar://problem/101394417> 1907126 2 sabouhallawa 2022-10-20 12:31:42 -0700 Pull request: https://github.com/WebKit/WebKit/pull/5596 1907155 3 ews-feeder 2022-10-20 14:29:12 -0700 Committed 255802@main (5a02a23fcd77): <https://commits.webkit.org/255802@main> Reviewed commits have been landed. Closing PR #5596 and removing active labels.